You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/14 06:18:34 UTC

[GitHub] [rocketmq] javaChain opened a new issue #2601: why that the message filter module has been deleted, why do you need to start the filterServer?

javaChain opened a new issue #2601:
URL: https://github.com/apache/rocketmq/issues/2601


   https://github.com/apache/rocketmq/issues/452
   4.7.1 brokerstartup will createFilterServer,but org.apache.rocketmq.filtersrv.FiltersrvStartup is deleted?
   ```
   public void start() {
   
           this.scheduledExecutorService.scheduleAtFixedRate(new Runnable() {
               @Override
               public void run() {
                   try {
                       FilterServerManager.this.createFilterServer();
                   } catch (Exception e) {
                       log.error("", e);
                   }
               }
           }, 1000 * 5, 1000 * 30, TimeUnit.MILLISECONDS);
       }
   ```
   this code is not work!
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] githublaohu commented on issue #2601: why that the message filter module has been deleted, why do you need to start the filterServer?

Posted by GitBox <gi...@apache.org>.
githublaohu commented on issue #2601:
URL: https://github.com/apache/rocketmq/issues/2601#issuecomment-760101283


   Provide more powerful functions, hope to provide SPI and hot loading, I guess


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] duhenglucky closed issue #2601: why that the message filter module has been deleted, why do you need to start the filterServer?

Posted by GitBox <gi...@apache.org>.
duhenglucky closed issue #2601:
URL: https://github.com/apache/rocketmq/issues/2601


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] duhenglucky commented on issue #2601: why that the message filter module has been deleted, why do you need to start the filterServer?

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on issue #2601:
URL: https://github.com/apache/rocketmq/issues/2601#issuecomment-761998658


   @javaChain @Jaskey Actully,the filterserver-related functions are replaced by TAG and SQL filtering, which brings better security and also provides better execution performance. The relevant code above should not be cleaned up yet.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Jaskey commented on issue #2601: why that the message filter module has been deleted, why do you need to start the filterServer?

Posted by GitBox <gi...@apache.org>.
Jaskey commented on issue #2601:
URL: https://github.com/apache/rocketmq/issues/2601#issuecomment-760157137


   good insights! @duhenglucky would you please help to answer?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org