[GitHub] [incubator-mxnet] leezu commented on a change in pull request #19034: Switch to GCC 9 for static build

[GitBox <gi...@apache.org>]

leezu commented on a change in pull request #19034:
URL: https://github.com/apache/incubator-mxnet/pull/19034#discussion_r485092319



##########
File path: tools/pip/setup.py
##########
@@ -152,9 +152,12 @@ def skip_markdown_comments(md):
     if os.path.exists(os.path.join(libdir, 'libgfortran.so.3')):
         shutil.copy(os.path.join(libdir, 'libgfortran.so.3'), mxdir)
         package_data['mxnet'].append('mxnet/libgfortran.so.3')
-    else:
+    elif os.path.exists(os.path.join(libdir, 'libgfortran.so.4')):
         shutil.copy(os.path.join(libdir, 'libgfortran.so.4'), mxdir)
         package_data['mxnet'].append('mxnet/libgfortran.so.4')
+    else:
+        shutil.copy(os.path.join(libdir, 'libgfortran.so.5'), mxdir)
+        package_data['mxnet'].append('mxnet/libgfortran.so.5')

Review comment:
       The `tools/pip/` is currently coupled with the `tools/staticbuild`. We should uncouple them but I think it can be part of a separate PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org