[GitHub] eolivelli commented on a change in pull request #946: ISSUE #945: Enabling BookieShell for LocalBookKeeper

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #946: ISSUE #945: Enabling BookieShell for LocalBookKeeper
URL: https://github.com/apache/bookkeeper/pull/946#discussion_r159773385
 
 

 ##########
 File path: bookkeeper-server/conf/bk_server.conf
 ##########
 @@ -48,6 +48,12 @@ journalDirectory=/tmp/bk-txn
 # Directories to store index files. If not specified, will use ledgerDirectories to store.
 # indexDirectories=/tmp/bk-data
 
+# Directory where LocalBookKeeper serializes the bookies config objects, which can be 
+# later used by BookieShell for running against LocalBookKeeper.
+# This config value should match DEFAULT_LOCALBOOKIES_CONFIG_DIR value in  
+# bookkeeper/bookkeeper-server/bin/bookkeeper script file.
+# localBookiesConfigDirectory=/tmp/localbookies-config
 
 Review comment:
   This is used only for testing and devs maybe it is better to move to the very bottom of the file?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services