You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by ki...@apache.org on 2017/01/04 06:51:15 UTC

[trafficserver] branch master updated: TS-5101: fix error handling for ts_lua

This is an automated email from the ASF dual-hosted git repository.

kichan pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
       new  1fa3723   TS-5101: fix error handling for ts_lua
1fa3723 is described below

commit 1fa3723f990ce03bf8a79c89c428e4e1bbbd8e03
Author: Kit Chan <ki...@apache.org>
AuthorDate: Fri Dec 30 10:13:36 2016 -0800

    TS-5101: fix error handling for ts_lua
---
 plugins/experimental/ts_lua/ts_lua_client_request.c  | 4 +++-
 plugins/experimental/ts_lua/ts_lua_client_response.c | 4 +++-
 plugins/experimental/ts_lua/ts_lua_server_response.c | 4 +++-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/plugins/experimental/ts_lua/ts_lua_client_request.c b/plugins/experimental/ts_lua/ts_lua_client_request.c
index 1b9bc8e..d286bb5 100644
--- a/plugins/experimental/ts_lua/ts_lua_client_request.c
+++ b/plugins/experimental/ts_lua/ts_lua_client_request.c
@@ -900,7 +900,9 @@ ts_lua_client_request_set_version(lua_State *L)
 
   version = luaL_checklstring(L, 1, &len);
 
-  sscanf(version, "%2u.%2u", &major, &minor);
+  if (sscanf(version, "%2u.%2u", &major, &minor) != 2) {
+    return luaL_error(L, "failed to set version. Format must be X.Y");
+  }
 
   TSHttpHdrVersionSet(http_ctx->client_request_bufp, http_ctx->client_request_hdrp, TS_HTTP_VERSION(major, minor));
 
diff --git a/plugins/experimental/ts_lua/ts_lua_client_response.c b/plugins/experimental/ts_lua/ts_lua_client_response.c
index 290f6f6..d5c656c 100644
--- a/plugins/experimental/ts_lua/ts_lua_client_response.c
+++ b/plugins/experimental/ts_lua/ts_lua_client_response.c
@@ -367,7 +367,9 @@ ts_lua_client_response_set_version(lua_State *L)
 
   version = luaL_checklstring(L, 1, &len);
 
-  sscanf(version, "%2u.%2u", &major, &minor);
+  if (sscanf(version, "%2u.%2u", &major, &minor) != 2) {
+    return luaL_error(L, "failed to set version. Format must be X.Y");
+  }
 
   TSHttpHdrVersionSet(http_ctx->client_response_bufp, http_ctx->client_response_hdrp, TS_HTTP_VERSION(major, minor));
 
diff --git a/plugins/experimental/ts_lua/ts_lua_server_response.c b/plugins/experimental/ts_lua/ts_lua_server_response.c
index df43d5b..d3e5338 100644
--- a/plugins/experimental/ts_lua/ts_lua_server_response.c
+++ b/plugins/experimental/ts_lua/ts_lua_server_response.c
@@ -351,7 +351,9 @@ ts_lua_server_response_set_version(lua_State *L)
 
   version = luaL_checklstring(L, 1, &len);
 
-  sscanf(version, "%2u.%2u", &major, &minor);
+  if (sscanf(version, "%2u.%2u", &major, &minor) != 2) {
+    return luaL_error(L, "failed to set version. Format must be X.Y");
+  }
 
   TSHttpHdrVersionSet(http_ctx->server_response_bufp, http_ctx->server_response_hdrp, TS_HTTP_VERSION(major, minor));
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].