You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/02/24 10:15:44 UTC

Review Request 43939: Required jsonifying of generic protobuf to be explicit opt-in [mesos].

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43939/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Bugs: MESOS-4754
    https://issues.apache.org/jira/browse/MESOS-4754


Repository: mesos


Description
-------

See JIRA ticket.


Diffs
-----

  src/common/http.cpp f8a0441b35898ae31eb5d5248c710847be3ab37a 
  src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b 

Diff: https://reviews.apache.org/r/43939/diff/


Testing
-------

`make check`


Thanks,

Michael Park


Re: Review Request 43939: Required jsonifying of generic protobuf to be explicit opt-in [mesos].

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43939/#review120485
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43937, 43938, 43939]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 24, 2016, 10:32 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43939/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 10:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4754
>     https://issues.apache.org/jira/browse/MESOS-4754
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See JIRA ticket.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp f8a0441b35898ae31eb5d5248c710847be3ab37a 
>   src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b 
> 
> Diff: https://reviews.apache.org/r/43939/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 43939: Required jsonifying of generic protobuf to be explicit opt-in [mesos].

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43939/
-----------------------------------------------------------

(Updated Feb. 24, 2016, 10:32 a.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Bugs: MESOS-4754
    https://issues.apache.org/jira/browse/MESOS-4754


Repository: mesos


Description (updated)
-------

See JIRA ticket.


Diffs
-----

  src/common/http.cpp f8a0441b35898ae31eb5d5248c710847be3ab37a 
  src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b 

Diff: https://reviews.apache.org/r/43939/diff/


Testing
-------

`make check`


Thanks,

Michael Park


Re: Review Request 43939: Required jsonifying of generic protobuf to be explicit opt-in [mesos].

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43939/
-----------------------------------------------------------

(Updated Feb. 24, 2016, 10:32 a.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Bugs: MESOS-4754
    https://issues.apache.org/jira/browse/MESOS-4754


Repository: mesos


Description (updated)
-------

Required jsonifying of generic protobuf to be explicit opt-in [mesos].


Diffs (updated)
-----

  src/common/http.cpp f8a0441b35898ae31eb5d5248c710847be3ab37a 
  src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b 

Diff: https://reviews.apache.org/r/43939/diff/


Testing
-------

`make check`


Thanks,

Michael Park