You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Lars Trieloff (JIRA)" <ji...@apache.org> on 2006/09/01 17:39:22 UTC
[jira] Created: (COCOON-1906) [PATCH] simple-xml binding does not
work with non file sources
[PATCH] simple-xml binding does not work with non file sources
--------------------------------------------------------------
Key: COCOON-1906
URL: http://issues.apache.org/jira/browse/COCOON-1906
Project: Cocoon
Issue Type: Bug
Components: * Cocoon Core, Blocks: Forms
Affects Versions: 2.2-dev (Current SVN)
Reporter: Lars Trieloff
The cocoon forms flowscript API comes with a helper method form.loadXML, that retrieves data from an xml document. The current implementation however does not work with documents that are referenced not as files, but as SitemapSources, e.g. via the cocoon:/ or xmldb:// pseudo-protocol. In this case the Rhino engine is unable to resolve the ambiguity between two method signatures:
org.mozilla.javascript.EvaluatorException: "resource://org/apache/cocoon/forms/flow/javascript/Form.js", line 287: The choice of Java constructor toSAX matching JavaScript argument types (org.apache.cocoon.components.source.impl.SitemapSource,org.apache.cocoon.forms.util.XMLAdapter) is ambiguous; candidate constructors are:
void toSAX(org.apache.excalibur.xml.sax.XMLizable,org.xml.sax.ContentHandler)
void toSAX(org.apache.excalibur.source.Source,org.xml.sax.ContentHandler)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1906) [PATCH] simple-xml binding does not
work with non file sources
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1906?page=comments#action_12437862 ]
Jean-Baptiste Quenot commented on COCOON-1906:
----------------------------------------------
Hi Lars,
Thanks for your patch, however I don't think it's a good idea to add toSAX(SitemapSource, ContentHandler), because SitemapSource is an implementation of Source. If we added this method, we would also need to add toSAX(XMLDBSource, ContentHandler) as you mention xmldb, and every possible implementation of Source. That doesn't make sense.
Can you come up with a better solution?
> [PATCH] simple-xml binding does not work with non file sources
> --------------------------------------------------------------
>
> Key: COCOON-1906
> URL: http://issues.apache.org/jira/browse/COCOON-1906
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms, * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Lars Trieloff
> Attachments: cocoon-formsbinding-sample.patch, cocoon-formsbinding-sourceutil.patch
>
>
> The cocoon forms flowscript API comes with a helper method form.loadXML, that retrieves data from an xml document. The current implementation however does not work with documents that are referenced not as files, but as SitemapSources, e.g. via the cocoon:/ or xmldb:// pseudo-protocol. In this case the Rhino engine is unable to resolve the ambiguity between two method signatures:
> org.mozilla.javascript.EvaluatorException: "resource://org/apache/cocoon/forms/flow/javascript/Form.js", line 287: The choice of Java constructor toSAX matching JavaScript argument types (org.apache.cocoon.components.source.impl.SitemapSource,org.apache.cocoon.forms.util.XMLAdapter) is ambiguous; candidate constructors are:
> void toSAX(org.apache.excalibur.xml.sax.XMLizable,org.xml.sax.ContentHandler)
> void toSAX(org.apache.excalibur.source.Source,org.xml.sax.ContentHandler)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1906) [PATCH] simple-xml binding does not
work with non file sources
Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1906?page=comments#action_12437578 ]
Alexander Klimetschek commented on COCOON-1906:
-----------------------------------------------
I tried this patch and it works! Would be cool if it gets integrated into trunk soon.
> [PATCH] simple-xml binding does not work with non file sources
> --------------------------------------------------------------
>
> Key: COCOON-1906
> URL: http://issues.apache.org/jira/browse/COCOON-1906
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms, * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Lars Trieloff
> Attachments: cocoon-formsbinding-sample.patch, cocoon-formsbinding-sourceutil.patch
>
>
> The cocoon forms flowscript API comes with a helper method form.loadXML, that retrieves data from an xml document. The current implementation however does not work with documents that are referenced not as files, but as SitemapSources, e.g. via the cocoon:/ or xmldb:// pseudo-protocol. In this case the Rhino engine is unable to resolve the ambiguity between two method signatures:
> org.mozilla.javascript.EvaluatorException: "resource://org/apache/cocoon/forms/flow/javascript/Form.js", line 287: The choice of Java constructor toSAX matching JavaScript argument types (org.apache.cocoon.components.source.impl.SitemapSource,org.apache.cocoon.forms.util.XMLAdapter) is ambiguous; candidate constructors are:
> void toSAX(org.apache.excalibur.xml.sax.XMLizable,org.xml.sax.ContentHandler)
> void toSAX(org.apache.excalibur.source.Source,org.xml.sax.ContentHandler)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-1906) [PATCH] simple-xml binding does not
work with non file sources
Posted by "Lars Trieloff (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1906?page=all ]
Lars Trieloff updated COCOON-1906:
----------------------------------
Attachment: cocoon-formsbinding-sample.patch
This is a small test case that modifies the form2simpleXML sample in the cocoon-forms-sample block to use a cocoon:/ resource instead of an XML file. Running the example leads to the problems described above.
> [PATCH] simple-xml binding does not work with non file sources
> --------------------------------------------------------------
>
> Key: COCOON-1906
> URL: http://issues.apache.org/jira/browse/COCOON-1906
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms, * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Lars Trieloff
> Attachments: cocoon-formsbinding-sample.patch
>
>
> The cocoon forms flowscript API comes with a helper method form.loadXML, that retrieves data from an xml document. The current implementation however does not work with documents that are referenced not as files, but as SitemapSources, e.g. via the cocoon:/ or xmldb:// pseudo-protocol. In this case the Rhino engine is unable to resolve the ambiguity between two method signatures:
> org.mozilla.javascript.EvaluatorException: "resource://org/apache/cocoon/forms/flow/javascript/Form.js", line 287: The choice of Java constructor toSAX matching JavaScript argument types (org.apache.cocoon.components.source.impl.SitemapSource,org.apache.cocoon.forms.util.XMLAdapter) is ambiguous; candidate constructors are:
> void toSAX(org.apache.excalibur.xml.sax.XMLizable,org.xml.sax.ContentHandler)
> void toSAX(org.apache.excalibur.source.Source,org.xml.sax.ContentHandler)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (COCOON-1906) [PATCH] simple-xml binding does not
work with non file sources
Posted by "Vadim Gritsenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1906?page=all ]
Vadim Gritsenko closed COCOON-1906.
-----------------------------------
Fix Version/s: 2.2-dev (Current SVN)
2.1.10-dev (current SVN)
Resolution: Fixed
Assignee: Vadim Gritsenko
Patch applied.
> [PATCH] simple-xml binding does not work with non file sources
> --------------------------------------------------------------
>
> Key: COCOON-1906
> URL: http://issues.apache.org/jira/browse/COCOON-1906
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms, * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Lars Trieloff
> Assigned To: Vadim Gritsenko
> Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
> Attachments: cocoon-forms-javascript-disambiguation.patch, cocoon-formsbinding-sample.patch, cocoon-formsbinding-sourceutil.patch
>
>
> The cocoon forms flowscript API comes with a helper method form.loadXML, that retrieves data from an xml document. The current implementation however does not work with documents that are referenced not as files, but as SitemapSources, e.g. via the cocoon:/ or xmldb:// pseudo-protocol. In this case the Rhino engine is unable to resolve the ambiguity between two method signatures:
> org.mozilla.javascript.EvaluatorException: "resource://org/apache/cocoon/forms/flow/javascript/Form.js", line 287: The choice of Java constructor toSAX matching JavaScript argument types (org.apache.cocoon.components.source.impl.SitemapSource,org.apache.cocoon.forms.util.XMLAdapter) is ambiguous; candidate constructors are:
> void toSAX(org.apache.excalibur.xml.sax.XMLizable,org.xml.sax.ContentHandler)
> void toSAX(org.apache.excalibur.source.Source,org.xml.sax.ContentHandler)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-1906) [PATCH] simple-xml binding does not
work with non file sources
Posted by "Lars Trieloff (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1906?page=all ]
Lars Trieloff updated COCOON-1906:
----------------------------------
Attachment: cocoon-formsbinding-sourceutil.patch
This patch adds another method to the SourceUtil class that helps Rhino in resolving the ambiguity between toSAX(Source,ContentHandler) and toSAX(XMLizable,ContentHandler) when dealing with a SitemapSource.
The example above runs perfectly when this patch is applied.
> [PATCH] simple-xml binding does not work with non file sources
> --------------------------------------------------------------
>
> Key: COCOON-1906
> URL: http://issues.apache.org/jira/browse/COCOON-1906
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms, * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Lars Trieloff
> Attachments: cocoon-formsbinding-sample.patch, cocoon-formsbinding-sourceutil.patch
>
>
> The cocoon forms flowscript API comes with a helper method form.loadXML, that retrieves data from an xml document. The current implementation however does not work with documents that are referenced not as files, but as SitemapSources, e.g. via the cocoon:/ or xmldb:// pseudo-protocol. In this case the Rhino engine is unable to resolve the ambiguity between two method signatures:
> org.mozilla.javascript.EvaluatorException: "resource://org/apache/cocoon/forms/flow/javascript/Form.js", line 287: The choice of Java constructor toSAX matching JavaScript argument types (org.apache.cocoon.components.source.impl.SitemapSource,org.apache.cocoon.forms.util.XMLAdapter) is ambiguous; candidate constructors are:
> void toSAX(org.apache.excalibur.xml.sax.XMLizable,org.xml.sax.ContentHandler)
> void toSAX(org.apache.excalibur.source.Source,org.xml.sax.ContentHandler)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1906) [PATCH] simple-xml binding does not
work with non file sources
Posted by "Vadim Gritsenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1906?page=comments#action_12437932 ]
Vadim Gritsenko commented on COCOON-1906:
-----------------------------------------
See: http://www.mozilla.org/js/liveconnect/lc3_method_overloading.html (chapter 4).
Form.js can be modified to pick the right method. I think this is the same issue:
http://marc.theaimsgroup.com/?l=xml-cocoon-dev&m=112777115419222
> [PATCH] simple-xml binding does not work with non file sources
> --------------------------------------------------------------
>
> Key: COCOON-1906
> URL: http://issues.apache.org/jira/browse/COCOON-1906
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms, * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Lars Trieloff
> Attachments: cocoon-formsbinding-sample.patch, cocoon-formsbinding-sourceutil.patch
>
>
> The cocoon forms flowscript API comes with a helper method form.loadXML, that retrieves data from an xml document. The current implementation however does not work with documents that are referenced not as files, but as SitemapSources, e.g. via the cocoon:/ or xmldb:// pseudo-protocol. In this case the Rhino engine is unable to resolve the ambiguity between two method signatures:
> org.mozilla.javascript.EvaluatorException: "resource://org/apache/cocoon/forms/flow/javascript/Form.js", line 287: The choice of Java constructor toSAX matching JavaScript argument types (org.apache.cocoon.components.source.impl.SitemapSource,org.apache.cocoon.forms.util.XMLAdapter) is ambiguous; candidate constructors are:
> void toSAX(org.apache.excalibur.xml.sax.XMLizable,org.xml.sax.ContentHandler)
> void toSAX(org.apache.excalibur.source.Source,org.xml.sax.ContentHandler)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (COCOON-1906) [PATCH] simple-xml binding does
not work with non file sources
Posted by Vadim Gritsenko <va...@reverycodes.com>.
Lars Trieloff (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/COCOON-1906?page=comments#action_12437870 ]
>
> Lars Trieloff commented on COCOON-1906:
> ---------------------------------------
>
> Jean Baptiste,
>
> the main problem is that there is no casting in Javascript and for any class that implements both XMLlizable and Source, the Rhino interpreter cannot decide because the distance is equal. So I see following solutions:
Actually you can pick the right method. I'll have to dig to find the syntax...
Vadim
[jira] Commented: (COCOON-1906) [PATCH] simple-xml binding does not
work with non file sources
Posted by "Lars Trieloff (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1906?page=comments#action_12437870 ]
Lars Trieloff commented on COCOON-1906:
---------------------------------------
Jean Baptiste,
the main problem is that there is no casting in Javascript and for any class that implements both XMLlizable and Source, the Rhino interpreter cannot decide because the distance is equal. So I see following solutions:
- adding a method for every xmllizable source (the approach of my patch)
- making xmlizable extend source (impossible, as it is in excalibur)
- adding an interface xmlizablesource and changing every cocoon source that implements xmlizable (inconvenient)
- adding methods with different names sourceToSAX() and xmlizableToSAX() (this is not the best Java style, but would be the choice for Javascript development)
As the goal is to make it easier to use this class from Javascript, I would prefer the last option. It does not break the api, requires no changes to existing code and is easy to implement?
What do you think?
> [PATCH] simple-xml binding does not work with non file sources
> --------------------------------------------------------------
>
> Key: COCOON-1906
> URL: http://issues.apache.org/jira/browse/COCOON-1906
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms, * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Lars Trieloff
> Attachments: cocoon-formsbinding-sample.patch, cocoon-formsbinding-sourceutil.patch
>
>
> The cocoon forms flowscript API comes with a helper method form.loadXML, that retrieves data from an xml document. The current implementation however does not work with documents that are referenced not as files, but as SitemapSources, e.g. via the cocoon:/ or xmldb:// pseudo-protocol. In this case the Rhino engine is unable to resolve the ambiguity between two method signatures:
> org.mozilla.javascript.EvaluatorException: "resource://org/apache/cocoon/forms/flow/javascript/Form.js", line 287: The choice of Java constructor toSAX matching JavaScript argument types (org.apache.cocoon.components.source.impl.SitemapSource,org.apache.cocoon.forms.util.XMLAdapter) is ambiguous; candidate constructors are:
> void toSAX(org.apache.excalibur.xml.sax.XMLizable,org.xml.sax.ContentHandler)
> void toSAX(org.apache.excalibur.source.Source,org.xml.sax.ContentHandler)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1906) [PATCH] simple-xml binding does not
work with non file sources
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1906?page=comments#action_12437881 ]
Jean-Baptiste Quenot commented on COCOON-1906:
----------------------------------------------
Can you give an example of a class that implements both XMLlizable and Source? If it is the case, then I prefer the last solution: to add a sourceToSax() method.
> [PATCH] simple-xml binding does not work with non file sources
> --------------------------------------------------------------
>
> Key: COCOON-1906
> URL: http://issues.apache.org/jira/browse/COCOON-1906
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms, * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Lars Trieloff
> Attachments: cocoon-formsbinding-sample.patch, cocoon-formsbinding-sourceutil.patch
>
>
> The cocoon forms flowscript API comes with a helper method form.loadXML, that retrieves data from an xml document. The current implementation however does not work with documents that are referenced not as files, but as SitemapSources, e.g. via the cocoon:/ or xmldb:// pseudo-protocol. In this case the Rhino engine is unable to resolve the ambiguity between two method signatures:
> org.mozilla.javascript.EvaluatorException: "resource://org/apache/cocoon/forms/flow/javascript/Form.js", line 287: The choice of Java constructor toSAX matching JavaScript argument types (org.apache.cocoon.components.source.impl.SitemapSource,org.apache.cocoon.forms.util.XMLAdapter) is ambiguous; candidate constructors are:
> void toSAX(org.apache.excalibur.xml.sax.XMLizable,org.xml.sax.ContentHandler)
> void toSAX(org.apache.excalibur.source.Source,org.xml.sax.ContentHandler)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1906) [PATCH] simple-xml binding does not
work with non file sources
Posted by "Lars Trieloff (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1906?page=comments#action_12437883 ]
Lars Trieloff commented on COCOON-1906:
---------------------------------------
org.apache.cocoon.components.source.SitemapSource implements Poolable, Recyclable, LogEnabled, ModifiableSource, *Source*, XMLConsumer, *XMLizable*, ContentHandler, LexicalHandler
org.apache.cocoon.components.source.impl.XMLDBSource implements LogEnabled, ModifiableSource, ModifiableTraversableSource, *Source*, TraversableSource, *XMLizable*
and some other sources we are using internally.
> [PATCH] simple-xml binding does not work with non file sources
> --------------------------------------------------------------
>
> Key: COCOON-1906
> URL: http://issues.apache.org/jira/browse/COCOON-1906
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms, * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Lars Trieloff
> Attachments: cocoon-formsbinding-sample.patch, cocoon-formsbinding-sourceutil.patch
>
>
> The cocoon forms flowscript API comes with a helper method form.loadXML, that retrieves data from an xml document. The current implementation however does not work with documents that are referenced not as files, but as SitemapSources, e.g. via the cocoon:/ or xmldb:// pseudo-protocol. In this case the Rhino engine is unable to resolve the ambiguity between two method signatures:
> org.mozilla.javascript.EvaluatorException: "resource://org/apache/cocoon/forms/flow/javascript/Form.js", line 287: The choice of Java constructor toSAX matching JavaScript argument types (org.apache.cocoon.components.source.impl.SitemapSource,org.apache.cocoon.forms.util.XMLAdapter) is ambiguous; candidate constructors are:
> void toSAX(org.apache.excalibur.xml.sax.XMLizable,org.xml.sax.ContentHandler)
> void toSAX(org.apache.excalibur.source.Source,org.xml.sax.ContentHandler)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-1906) [PATCH] simple-xml binding does not
work with non file sources
Posted by "Lars Trieloff (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1906?page=all ]
Lars Trieloff updated COCOON-1906:
----------------------------------
Attachment: cocoon-forms-javascript-disambiguation.patch
Hi Vadim,
thank you for the hint. Using the attached patch, which will disambigue the method using the methodology described at http://www.mozilla.org/js/liveconnect/lc3_method_overloading.html I am able to run the modified samples in the way intended.
So the other patches are obsolete.
> [PATCH] simple-xml binding does not work with non file sources
> --------------------------------------------------------------
>
> Key: COCOON-1906
> URL: http://issues.apache.org/jira/browse/COCOON-1906
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms, * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Lars Trieloff
> Attachments: cocoon-forms-javascript-disambiguation.patch, cocoon-formsbinding-sample.patch, cocoon-formsbinding-sourceutil.patch
>
>
> The cocoon forms flowscript API comes with a helper method form.loadXML, that retrieves data from an xml document. The current implementation however does not work with documents that are referenced not as files, but as SitemapSources, e.g. via the cocoon:/ or xmldb:// pseudo-protocol. In this case the Rhino engine is unable to resolve the ambiguity between two method signatures:
> org.mozilla.javascript.EvaluatorException: "resource://org/apache/cocoon/forms/flow/javascript/Form.js", line 287: The choice of Java constructor toSAX matching JavaScript argument types (org.apache.cocoon.components.source.impl.SitemapSource,org.apache.cocoon.forms.util.XMLAdapter) is ambiguous; candidate constructors are:
> void toSAX(org.apache.excalibur.xml.sax.XMLizable,org.xml.sax.ContentHandler)
> void toSAX(org.apache.excalibur.source.Source,org.xml.sax.ContentHandler)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira