[GitHub] [incubator-heron] nicknezis commented on a change in pull request #3550: Updates to Kubernetes scheduler to fix edge cases

[GitBox <gi...@apache.org>]

nicknezis commented on a change in pull request #3550:
URL: https://github.com/apache/incubator-heron/pull/3550#discussion_r448016862



##########
File path: third_party/java/BUILD
##########
@@ -227,10 +227,10 @@ java_library(
     name = "apache-pulsar-client",
     srcs = ["Empty.java"],
     exports = [
-        "@maven//:org_apache_pulsar_pulsar_client_shaded",
+        "@maven//:org_apache_pulsar_pulsar_client",
     ],
     deps = [
-        "@maven//:org_apache_pulsar_pulsar_client_shaded",
+        "@maven//:org_apache_pulsar_pulsar_client",
     ],

Review comment:
       We might want to put it back to the shaded jar. I think I made this change because of a compilation error. I just checked, and I think we changed the dependency in the WORKSPACE file. Here is the PR: https://github.com/apache/incubator-heron/pull/3536/files




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org