You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ShunKang Lin <li...@gmail.com> on 2023/05/07 07:24:25 UTC
[VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Hi everyone,
I'd like to open the vote for KIP-872, which proposes to add
Serializer#serializeToByteBuffer() to reduce memory copying.
The proposal is here:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
The pull request is here:
https://github.com/apache/kafka/pull/12685
Thanks to all who reviewed the proposal, and thanks in advance for taking
the time to vote!
Best,
ShunKang
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by ShunKang Lin <li...@gmail.com>.
Hi all,
Thanks for voting!
Bump this thread again and see if we could get a few more votes. Currently
we have +3 non-binding (from Divij Vaidya, Kirk True and Kamal
Chandraprakash) and +2 binding (from Luke Chen and ziming deng).
Hoping we can get this approved, reviewed, and merged in time for 3.6.0.
Best,
ShunKang
ShunKang Lin <li...@gmail.com> 于2023年5月7日周日 15:24写道：
> Hi everyone,
>
> I'd like to open the vote for KIP-872, which proposes to add
> Serializer#serializeToByteBuffer() to reduce memory copying.
>
> The proposal is here:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
>
> The pull request is here:
> https://github.com/apache/kafka/pull/12685
>
> Thanks to all who reviewed the proposal, and thanks in advance for taking
> the time to vote!
>
> Best,
> ShunKang
>
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by ShunKang Lin <li...@gmail.com>.
Hi all,
Thanks for voting!
Just wanted to bump this thread and see if we could get a few more votes.
Currently we have +2 non-binding and +1 binding.
Hoping we can get this approved, reviewed, and merged in time for 3.6.0.
Best,
ShunKang
Kirk True <ki...@kirktrue.pro> 于2023年5月11日周四 22:54写道：
> +1 (non-binding)
>
> Thanks ShunKang!
>
> On Wed, May 10, 2023, at 7:26 PM, Luke Chen wrote:
> > +1(binding) from me.
> > Thanks for the improvement!
> >
> > Luke
> >
> > On Sun, May 7, 2023 at 6:34 PM Divij Vaidya <di...@gmail.com>
> wrote:
> >
> > > Vote +1 (non binding)
> > >
> > > I think that this is a nice improvement as it prevents an unnecessary
> data
> > > copy for users who are using ByteBuffer serialization on the producer.
> > >
> > > --
> > > Divij Vaidya
> > >
> > >
> > >
> > > On Sun, May 7, 2023 at 9:24 AM ShunKang Lin <linshunkang.chn@gmail.com
> >
> > > wrote:
> > >
> > > > Hi everyone,
> > > >
> > > > I'd like to open the vote for KIP-872, which proposes to add
> > > > Serializer#serializeToByteBuffer() to reduce memory copying.
> > > >
> > > > The proposal is here:
> > > >
> > >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
> > > >
> > > > The pull request is here:
> > > > https://github.com/apache/kafka/pull/12685
> > > >
> > > > Thanks to all who reviewed the proposal, and thanks in advance for
> taking
> > > > the time to vote!
> > > >
> > > > Best,
> > > > ShunKang
> > > >
> > >
> >
>
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by Kirk True <ki...@kirktrue.pro>.
+1 (non-binding)
Thanks ShunKang!
On Wed, May 10, 2023, at 7:26 PM, Luke Chen wrote:
> +1(binding) from me.
> Thanks for the improvement!
>
> Luke
>
> On Sun, May 7, 2023 at 6:34 PM Divij Vaidya <di...@gmail.com> wrote:
>
> > Vote +1 (non binding)
> >
> > I think that this is a nice improvement as it prevents an unnecessary data
> > copy for users who are using ByteBuffer serialization on the producer.
> >
> > --
> > Divij Vaidya
> >
> >
> >
> > On Sun, May 7, 2023 at 9:24 AM ShunKang Lin <li...@gmail.com>
> > wrote:
> >
> > > Hi everyone,
> > >
> > > I'd like to open the vote for KIP-872, which proposes to add
> > > Serializer#serializeToByteBuffer() to reduce memory copying.
> > >
> > > The proposal is here:
> > >
> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
> > >
> > > The pull request is here:
> > > https://github.com/apache/kafka/pull/12685
> > >
> > > Thanks to all who reviewed the proposal, and thanks in advance for taking
> > > the time to vote!
> > >
> > > Best,
> > > ShunKang
> > >
> >
>
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by Luke Chen <sh...@gmail.com>.
+1(binding) from me.
Thanks for the improvement!
Luke
On Sun, May 7, 2023 at 6:34 PM Divij Vaidya <di...@gmail.com> wrote:
> Vote +1 (non binding)
>
> I think that this is a nice improvement as it prevents an unnecessary data
> copy for users who are using ByteBuffer serialization on the producer.
>
> --
> Divij Vaidya
>
>
>
> On Sun, May 7, 2023 at 9:24 AM ShunKang Lin <li...@gmail.com>
> wrote:
>
> > Hi everyone,
> >
> > I'd like to open the vote for KIP-872, which proposes to add
> > Serializer#serializeToByteBuffer() to reduce memory copying.
> >
> > The proposal is here:
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
> >
> > The pull request is here:
> > https://github.com/apache/kafka/pull/12685
> >
> > Thanks to all who reviewed the proposal, and thanks in advance for taking
> > the time to vote!
> >
> > Best,
> > ShunKang
> >
>
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by Divij Vaidya <di...@gmail.com>.
Vote +1 (non binding)
I think that this is a nice improvement as it prevents an unnecessary data
copy for users who are using ByteBuffer serialization on the producer.
--
Divij Vaidya
On Sun, May 7, 2023 at 9:24 AM ShunKang Lin <li...@gmail.com>
wrote:
> Hi everyone,
>
> I'd like to open the vote for KIP-872, which proposes to add
> Serializer#serializeToByteBuffer() to reduce memory copying.
>
> The proposal is here:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
>
> The pull request is here:
> https://github.com/apache/kafka/pull/12685
>
> Thanks to all who reviewed the proposal, and thanks in advance for taking
> the time to vote!
>
> Best,
> ShunKang
>
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by Kamal Chandraprakash <ka...@gmail.com>.
+1 (non-binding). Thanks for the improvement!
Thanks,
Kamal
On Wed, May 31, 2023 at 8:23 AM ziming deng <de...@gmail.com>
wrote:
> Hello ShunKang,
>
> +1(binding) from me
>
> --
> Thanks,
> Ziming
>
> > On May 30, 2023, at 20:07, ShunKang Lin <li...@gmail.com>
> wrote:
> >
> > Hi all,
> >
> > Bump this thread again and see if we could get a few more votes.
> Currently
> > we have +2 non-binding and +1 binding.
> > Hoping we can get this approved, reviewed, and merged in time for 3.6.0.
> >
> > Best,
> > ShunKang
> >
> > ShunKang Lin <li...@gmail.com> 于2023年5月7日周日 15:24写道：
> >
> >> Hi everyone,
> >>
> >> I'd like to open the vote for KIP-872, which proposes to add
> >> Serializer#serializeToByteBuffer() to reduce memory copying.
> >>
> >> The proposal is here:
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
> >>
> >> The pull request is here:
> >> https://github.com/apache/kafka/pull/12685
> >>
> >> Thanks to all who reviewed the proposal, and thanks in advance for
> taking
> >> the time to vote!
> >>
> >> Best,
> >> ShunKang
> >>
>
>
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by ziming deng <de...@gmail.com>.
Hello ShunKang,
+1(binding) from me
--
Thanks,
Ziming
> On May 30, 2023, at 20:07, ShunKang Lin <li...@gmail.com> wrote:
>
> Hi all,
>
> Bump this thread again and see if we could get a few more votes. Currently
> we have +2 non-binding and +1 binding.
> Hoping we can get this approved, reviewed, and merged in time for 3.6.0.
>
> Best,
> ShunKang
>
> ShunKang Lin <li...@gmail.com> 于2023年5月7日周日 15:24写道：
>
>> Hi everyone,
>>
>> I'd like to open the vote for KIP-872, which proposes to add
>> Serializer#serializeToByteBuffer() to reduce memory copying.
>>
>> The proposal is here:
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
>>
>> The pull request is here:
>> https://github.com/apache/kafka/pull/12685
>>
>> Thanks to all who reviewed the proposal, and thanks in advance for taking
>> the time to vote!
>>
>> Best,
>> ShunKang
>>
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by ShunKang Lin <li...@gmail.com>.
Hi all,
Bump this thread again and see if we could get a few more votes. Currently
we have +2 non-binding and +1 binding.
Hoping we can get this approved, reviewed, and merged in time for 3.6.0.
Best,
ShunKang
ShunKang Lin <li...@gmail.com> 于2023年5月7日周日 15:24写道：
> Hi everyone,
>
> I'd like to open the vote for KIP-872, which proposes to add
> Serializer#serializeToByteBuffer() to reduce memory copying.
>
> The proposal is here:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
>
> The pull request is here:
> https://github.com/apache/kafka/pull/12685
>
> Thanks to all who reviewed the proposal, and thanks in advance for taking
> the time to vote!
>
> Best,
> ShunKang
>
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by ShunKang Lin <li...@gmail.com>.
Hi all,
Thanks all for voting!
Currently we have +3 binding (from Divij Vaidya, Luke Chen and ziming deng)
and +2 non-binding(from Kirk True and Kamal Chandraprakash).
This vote thread has been open over 72 hours and has sufficient votes, so
I’ll close the voting at this time.
KIP-872 has PASSED.
Best,
ShunKang
在 2023年6月21日星期三，Divij Vaidya <di...@gmail.com> 写道：
> +1 (again) - binding :)
>
> Please update the PR ShunKang and tag me for review when you are ready.
>
> --
> Divij Vaidya
>
>
>
> On Tue, Jun 20, 2023 at 4:11 PM John Roesler <vv...@apache.org> wrote:
>
> > Hi Divij and ShunKang,
> >
> > I pulled open this thread to see if you needed my vote, but FYI, Divij is
> > a committer now, so he can re-cast his vote as binding.
> >
> > Thanks,
> > -John
> >
> > On 2023/06/20 13:37:04 ShunKang Lin wrote:
> > > Hi all,
> > >
> > > Bump this thread again and see if we could get a few more votes.
> > > Currently we have +3 non-binding (from Divij Vaidya, Kirk True and
> Kamal
> > > Chandraprakash) and +2 binding (from Luke Chen and ziming deng).
> > > Hoping we can get this approved, reviewed, and merged in time for
> 3.6.0.
> > >
> > > Best,
> > > ShunKang
> > >
> > > ShunKang Lin <li...@gmail.com> 于2023年5月7日周日 15:24写道：
> > >
> > > > Hi everyone,
> > > >
> > > > I'd like to open the vote for KIP-872, which proposes to add
> > > > Serializer#serializeToByteBuffer() to reduce memory copying.
> > > >
> > > > The proposal is here:
> > > >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
> > > >
> > > > The pull request is here:
> > > > https://github.com/apache/kafka/pull/12685
> > > >
> > > > Thanks to all who reviewed the proposal, and thanks in advance for
> > taking
> > > > the time to vote!
> > > >
> > > > Best,
> > > > ShunKang
> > > >
> > >
> >
>
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by Divij Vaidya <di...@gmail.com>.
+1 (again) - binding :)
Please update the PR ShunKang and tag me for review when you are ready.
--
Divij Vaidya
On Tue, Jun 20, 2023 at 4:11 PM John Roesler <vv...@apache.org> wrote:
> Hi Divij and ShunKang,
>
> I pulled open this thread to see if you needed my vote, but FYI, Divij is
> a committer now, so he can re-cast his vote as binding.
>
> Thanks,
> -John
>
> On 2023/06/20 13:37:04 ShunKang Lin wrote:
> > Hi all,
> >
> > Bump this thread again and see if we could get a few more votes.
> > Currently we have +3 non-binding (from Divij Vaidya, Kirk True and Kamal
> > Chandraprakash) and +2 binding (from Luke Chen and ziming deng).
> > Hoping we can get this approved, reviewed, and merged in time for 3.6.0.
> >
> > Best,
> > ShunKang
> >
> > ShunKang Lin <li...@gmail.com> 于2023年5月7日周日 15:24写道：
> >
> > > Hi everyone,
> > >
> > > I'd like to open the vote for KIP-872, which proposes to add
> > > Serializer#serializeToByteBuffer() to reduce memory copying.
> > >
> > > The proposal is here:
> > >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
> > >
> > > The pull request is here:
> > > https://github.com/apache/kafka/pull/12685
> > >
> > > Thanks to all who reviewed the proposal, and thanks in advance for
> taking
> > > the time to vote!
> > >
> > > Best,
> > > ShunKang
> > >
> >
>
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by ShunKang Lin <li...@gmail.com>.
Hi John,
Thank you for your reminder!
Best,
ShunKang
John Roesler <vv...@apache.org>于2023年6月20日 周二22:11写道：
> Hi Divij and ShunKang,
>
> I pulled open this thread to see if you needed my vote, but FYI, Divij is
> a committer now, so he can re-cast his vote as binding.
>
> Thanks,
> -John
>
> On 2023/06/20 13:37:04 ShunKang Lin wrote:
> > Hi all,
> >
> > Bump this thread again and see if we could get a few more votes.
> > Currently we have +3 non-binding (from Divij Vaidya, Kirk True and Kamal
> > Chandraprakash) and +2 binding (from Luke Chen and ziming deng).
> > Hoping we can get this approved, reviewed, and merged in time for 3.6.0.
> >
> > Best,
> > ShunKang
> >
> > ShunKang Lin <li...@gmail.com> 于2023年5月7日周日 15:24写道：
> >
> > > Hi everyone,
> > >
> > > I'd like to open the vote for KIP-872, which proposes to add
> > > Serializer#serializeToByteBuffer() to reduce memory copying.
> > >
> > > The proposal is here:
> > >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
> > >
> > > The pull request is here:
> > > https://github.com/apache/kafka/pull/12685
> > >
> > > Thanks to all who reviewed the proposal, and thanks in advance for
> taking
> > > the time to vote!
> > >
> > > Best,
> > > ShunKang
> > >
> >
>
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by John Roesler <vv...@apache.org>.
Hi Divij and ShunKang,
I pulled open this thread to see if you needed my vote, but FYI, Divij is a committer now, so he can re-cast his vote as binding.
Thanks,
-John
On 2023/06/20 13:37:04 ShunKang Lin wrote:
> Hi all,
>
> Bump this thread again and see if we could get a few more votes.
> Currently we have +3 non-binding (from Divij Vaidya, Kirk True and Kamal
> Chandraprakash) and +2 binding (from Luke Chen and ziming deng).
> Hoping we can get this approved, reviewed, and merged in time for 3.6.0.
>
> Best,
> ShunKang
>
> ShunKang Lin <li...@gmail.com> 于2023年5月7日周日 15:24写道：
>
> > Hi everyone,
> >
> > I'd like to open the vote for KIP-872, which proposes to add
> > Serializer#serializeToByteBuffer() to reduce memory copying.
> >
> > The proposal is here:
> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
> >
> > The pull request is here:
> > https://github.com/apache/kafka/pull/12685
> >
> > Thanks to all who reviewed the proposal, and thanks in advance for taking
> > the time to vote!
> >
> > Best,
> > ShunKang
> >
>
Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying
Posted by ShunKang Lin <li...@gmail.com>.
Hi all,
Bump this thread again and see if we could get a few more votes.
Currently we have +3 non-binding (from Divij Vaidya, Kirk True and Kamal
Chandraprakash) and +2 binding (from Luke Chen and ziming deng).
Hoping we can get this approved, reviewed, and merged in time for 3.6.0.
Best,
ShunKang
ShunKang Lin <li...@gmail.com> 于2023年5月7日周日 15:24写道：
> Hi everyone,
>
> I'd like to open the vote for KIP-872, which proposes to add
> Serializer#serializeToByteBuffer() to reduce memory copying.
>
> The proposal is here:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828
>
> The pull request is here:
> https://github.com/apache/kafka/pull/12685
>
> Thanks to all who reviewed the proposal, and thanks in advance for taking
> the time to vote!
>
> Best,
> ShunKang
>