You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:18:01 UTC
[GitHub] [spark] pingsutw opened a new pull request #32874: [SPARK-35699][Kubernetes] Improve error message when creating k8s pod failed.
pingsutw opened a new pull request #32874:
URL: https://github.com/apache/spark/pull/32874
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Improve error message when clients use wrong master URL to submit a job to k8s.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Current error messages are not clear for users.
```
(base) ➜ spark git:(master) ./bin/spark-submit \
--master k8s://https://192.168.49.3:8443 \
--name spark-pi \
--class org.apache.spark.examples.SparkPi \
--conf spark.executor.instances=3 \
--conf spark.kubernetes.authenticate.driver.serviceAccountName=spark \
--conf spark.kubernetes.container.image=pingsutw/spark:testing \
local:///opt/spark/examples/jars/spark-examples_2.12-3.2.0-SNAPSHOT.jar
21/06/09 20:50:37 WARN Utils: Your hostname, kobe-pc resolves to a loopback address: 127.0.1.1; using 192.168.103.20 instead (on interface ens160)
21/06/09 20:50:37 WARN Utils: Set SPARK_LOCAL_IP if you need to bind to another address
21/06/09 20:50:38 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Using Spark's default log4j profile: org/apache/spark/log4j-defaults.properties
21/06/09 20:50:38 INFO SparkKubernetesClientFactory: Auto-configuring K8S client using current context from users K8S config file
21/06/09 20:50:39 INFO KerberosConfDriverFeatureStep: You have not specified a krb5.conf file locally or via a ConfigMap. Make sure that you have the krb5.conf locally on the driver image.
Exception in thread "main" io.fabric8.kubernetes.client.KubernetesClientException: Operation: [create] for kind: [Pod] with name: [null] in namespace: [default] failed.
at io.fabric8.kubernetes.client.KubernetesClientException.launderThrowable(KubernetesClientException.java:64) at io.fabric8.kubernetes.client.KubernetesClientException.launderThrowable(KubernetesClientException.java:64)
at io.fabric8.kubernetes.client.KubernetesClientException.launderThrowable(KubernetesClientException.java:72) at io.fabric8.kubernetes.client.KubernetesClientException.launderThrowable(KubernetesClientException.java:72)
at io.fabric8.kubernetes.client.dsl.base.BaseOperation.create(BaseOperation.java:380) at io.fabric8.kubernetes.client.dsl.base.BaseOperation.create(BaseOperation.java:380)
at io.fabric8.kubernetes.client.dsl.base.BaseOperation.create(BaseOperation.java:86) at io.fabric8.kubernetes.client.dsl.base.BaseOperation.create(BaseOperation.java:86)
```
Below command to reproduce;
```
./bin/spark-submit \
--master k8s://https://192.168.49.2:8443 \
--deploy-mode cluster \
--name spark-pi \
--class org.apache.spark.examples.SparkPi \
--conf spark.executor.instances=3 \
--conf spark.kubernetes.authenticate.driver.serviceAccountName=spark \
--conf spark.kubernetes.container.image=pingsutw/spark:testing \
local:///opt/spark/examples/jars/spark-examples_2.12-3.2.0-SNAPSHOT.jar
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, users will see more clear error messages.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32874: [SPARK-35699][Kubernetes] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32874:
URL: https://github.com/apache/spark/pull/32874#issuecomment-859238036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32874: [SPARK-35699][Kubernetes] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32874:
URL: https://github.com/apache/spark/pull/32874#issuecomment-859237186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32874: [SPARK-35699][K8S] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32874:
URL: https://github.com/apache/spark/pull/32874#issuecomment-863927807
**[Test build #139986 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139986/testReport)** for PR 32874 at commit [`c681379`](https://github.com/apache/spark/commit/c6813797156353eab001cf291257d41bbe773797).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32874: [SPARK-35699][K8S] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32874:
URL: https://github.com/apache/spark/pull/32874#issuecomment-863937474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32874: [SPARK-35699][K8S] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32874:
URL: https://github.com/apache/spark/pull/32874#issuecomment-859239174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32874: [SPARK-35699][Kubernetes] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32874:
URL: https://github.com/apache/spark/pull/32874#issuecomment-859237186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32874: [SPARK-35699][K8S] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32874:
URL: https://github.com/apache/spark/pull/32874#discussion_r651316233
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -136,7 +136,15 @@ private[spark] class Client(
val driverPodName = resolvedDriverPod.getMetadata.getName
var watch: Watch = null
- val createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
+ var createdDriverPod: Pod = null
+ try {
+ createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
+ } catch {
+ case NonFatal(e) =>
+ logError("Fail to create driver pod, you may use wrong master URL or permission denied." +
+ "please check the network connection and permission.")
Review comment:
Since we have enough information about the error itself, can we improve the directional information more? For example, we can ask the users to check `kubectl auth can-i create pod` first. It should be `yes`.
```
Exception in thread "main" io.fabric8.kubernetes.client.KubernetesClientException: Operation: [create] for kind: [Pod] with name: [null] in namespace: [default] failed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pingsutw commented on a change in pull request #32874: [SPARK-35699][K8S] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #32874:
URL: https://github.com/apache/spark/pull/32874#discussion_r654291077
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -136,7 +136,15 @@ private[spark] class Client(
val driverPodName = resolvedDriverPod.getMetadata.getName
var watch: Watch = null
- val createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
+ var createdDriverPod: Pod = null
+ try {
+ createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
+ } catch {
+ case NonFatal(e) =>
+ logError("Fail to create driver pod, you may use wrong master URL or permission denied." +
+ "please check the network connection and permission.")
Review comment:
@dongjoon-hyun Thanks for the suggestion. Updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #32874: [SPARK-35699][K8S] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #32874:
URL: https://github.com/apache/spark/pull/32874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pingsutw commented on a change in pull request #32874: [SPARK-35699][K8S] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #32874:
URL: https://github.com/apache/spark/pull/32874#discussion_r649836300
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -100,45 +97,56 @@ private[spark] class Client(
conf: KubernetesDriverConf,
builder: KubernetesDriverBuilder,
kubernetesClient: KubernetesClient,
- watcher: LoggingPodStatusWatcher) extends Logging {
+ watcher: LoggingPodStatusWatcher)
+ extends Logging {
def run(): Unit = {
val resolvedDriverSpec = builder.buildFromFeatures(conf, kubernetesClient)
val configMapName = KubernetesClientUtils.configMapNameDriver
- val confFilesMap = KubernetesClientUtils.buildSparkConfDirFilesMap(configMapName,
- conf.sparkConf, resolvedDriverSpec.systemProperties)
+ val confFilesMap = KubernetesClientUtils.buildSparkConfDirFilesMap(
+ configMapName,
+ conf.sparkConf,
+ resolvedDriverSpec.systemProperties)
val configMap = KubernetesClientUtils.buildConfigMap(configMapName, confFilesMap)
// The include of the ENV_VAR for "SPARK_CONF_DIR" is to allow for the
// Spark command builder to pickup on the Java Options present in the ConfigMap
val resolvedDriverContainer = new ContainerBuilder(resolvedDriverSpec.pod.container)
.addNewEnv()
- .withName(ENV_SPARK_CONF_DIR)
- .withValue(SPARK_CONF_DIR_INTERNAL)
- .endEnv()
+ .withName(ENV_SPARK_CONF_DIR)
+ .withValue(SPARK_CONF_DIR_INTERNAL)
+ .endEnv()
.addNewVolumeMount()
- .withName(SPARK_CONF_VOLUME_DRIVER)
- .withMountPath(SPARK_CONF_DIR_INTERNAL)
- .endVolumeMount()
+ .withName(SPARK_CONF_VOLUME_DRIVER)
+ .withMountPath(SPARK_CONF_DIR_INTERNAL)
+ .endVolumeMount()
Review comment:
okay, got it
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -136,9 +136,17 @@ private[spark] class Client(
val driverPodName = resolvedDriverPod.getMetadata.getName
var watch: Watch = null
- val createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
+ var createdDriverPod: Pod = null
try {
- val otherKubernetesResources = resolvedDriverSpec.driverKubernetesResources ++ Seq(configMap)
+ createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
+ } catch {
+ case NonFatal(e) =>
+ logError("Fail to create driver pod, you may use wrong master URL.")
Review comment:
yeah, make sense.
How about changing to this? Any suggestion?
```scala
logError("Fail to create driver pod, you may use wrong master URL or permission denied.
Please check the network connection and permission")
```
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -136,9 +136,17 @@ private[spark] class Client(
val driverPodName = resolvedDriverPod.getMetadata.getName
var watch: Watch = null
- val createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
+ var createdDriverPod: Pod = null
try {
- val otherKubernetesResources = resolvedDriverSpec.driverKubernetesResources ++ Seq(configMap)
+ createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
+ } catch {
+ case NonFatal(e) =>
+ logError("Fail to create driver pod, you may use wrong master URL.")
+ throw e
+ }
+ try {
+ val otherKubernetesResources =
+ resolvedDriverSpec.driverKubernetesResources ++ Seq(configMap)
Review comment:
okay, got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pingsutw commented on pull request #32874: [SPARK-35699][K8S] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #32874:
URL: https://github.com/apache/spark/pull/32874#issuecomment-859453460
@dongjoon-hyun Thanks for your review.
Sorry for some irrelevant changes.
I use `dev/scalafmt` to format the code. Maybe there is something wrong in that script.
Anyway, I will revert the other unrelated change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32874: [SPARK-35699][K8S] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32874:
URL: https://github.com/apache/spark/pull/32874#issuecomment-859239174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #32874: [SPARK-35699][K8S] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #32874:
URL: https://github.com/apache/spark/pull/32874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32874: [SPARK-35699][K8S] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32874:
URL: https://github.com/apache/spark/pull/32874#issuecomment-863927807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32874: [SPARK-35699][Kubernetes] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32874:
URL: https://github.com/apache/spark/pull/32874#discussion_r649665934
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -100,45 +97,56 @@ private[spark] class Client(
conf: KubernetesDriverConf,
builder: KubernetesDriverBuilder,
kubernetesClient: KubernetesClient,
- watcher: LoggingPodStatusWatcher) extends Logging {
+ watcher: LoggingPodStatusWatcher)
+ extends Logging {
def run(): Unit = {
val resolvedDriverSpec = builder.buildFromFeatures(conf, kubernetesClient)
val configMapName = KubernetesClientUtils.configMapNameDriver
- val confFilesMap = KubernetesClientUtils.buildSparkConfDirFilesMap(configMapName,
- conf.sparkConf, resolvedDriverSpec.systemProperties)
+ val confFilesMap = KubernetesClientUtils.buildSparkConfDirFilesMap(
+ configMapName,
+ conf.sparkConf,
+ resolvedDriverSpec.systemProperties)
val configMap = KubernetesClientUtils.buildConfigMap(configMapName, confFilesMap)
// The include of the ENV_VAR for "SPARK_CONF_DIR" is to allow for the
// Spark command builder to pickup on the Java Options present in the ConfigMap
val resolvedDriverContainer = new ContainerBuilder(resolvedDriverSpec.pod.container)
.addNewEnv()
- .withName(ENV_SPARK_CONF_DIR)
- .withValue(SPARK_CONF_DIR_INTERNAL)
- .endEnv()
+ .withName(ENV_SPARK_CONF_DIR)
+ .withValue(SPARK_CONF_DIR_INTERNAL)
+ .endEnv()
.addNewVolumeMount()
- .withName(SPARK_CONF_VOLUME_DRIVER)
- .withMountPath(SPARK_CONF_DIR_INTERNAL)
- .endVolumeMount()
+ .withName(SPARK_CONF_VOLUME_DRIVER)
+ .withMountPath(SPARK_CONF_DIR_INTERNAL)
+ .endVolumeMount()
Review comment:
Could you revert all whitespace changes? We usually don't mix a style-only change and a new feature in a single PR.
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -100,45 +97,56 @@ private[spark] class Client(
conf: KubernetesDriverConf,
builder: KubernetesDriverBuilder,
kubernetesClient: KubernetesClient,
- watcher: LoggingPodStatusWatcher) extends Logging {
+ watcher: LoggingPodStatusWatcher)
+ extends Logging {
def run(): Unit = {
val resolvedDriverSpec = builder.buildFromFeatures(conf, kubernetesClient)
val configMapName = KubernetesClientUtils.configMapNameDriver
- val confFilesMap = KubernetesClientUtils.buildSparkConfDirFilesMap(configMapName,
- conf.sparkConf, resolvedDriverSpec.systemProperties)
+ val confFilesMap = KubernetesClientUtils.buildSparkConfDirFilesMap(
+ configMapName,
+ conf.sparkConf,
+ resolvedDriverSpec.systemProperties)
val configMap = KubernetesClientUtils.buildConfigMap(configMapName, confFilesMap)
// The include of the ENV_VAR for "SPARK_CONF_DIR" is to allow for the
// Spark command builder to pickup on the Java Options present in the ConfigMap
val resolvedDriverContainer = new ContainerBuilder(resolvedDriverSpec.pod.container)
.addNewEnv()
- .withName(ENV_SPARK_CONF_DIR)
- .withValue(SPARK_CONF_DIR_INTERNAL)
- .endEnv()
+ .withName(ENV_SPARK_CONF_DIR)
+ .withValue(SPARK_CONF_DIR_INTERNAL)
+ .endEnv()
.addNewVolumeMount()
- .withName(SPARK_CONF_VOLUME_DRIVER)
- .withMountPath(SPARK_CONF_DIR_INTERNAL)
- .endVolumeMount()
+ .withName(SPARK_CONF_VOLUME_DRIVER)
+ .withMountPath(SPARK_CONF_DIR_INTERNAL)
+ .endVolumeMount()
.build()
val resolvedDriverPod = new PodBuilder(resolvedDriverSpec.pod.pod)
.editSpec()
- .addToContainers(resolvedDriverContainer)
- .addNewVolume()
- .withName(SPARK_CONF_VOLUME_DRIVER)
- .withNewConfigMap()
- .withItems(KubernetesClientUtils.buildKeyToPathObjects(confFilesMap).asJava)
- .withName(configMapName)
- .endConfigMap()
- .endVolume()
- .endSpec()
+ .addToContainers(resolvedDriverContainer)
+ .addNewVolume()
+ .withName(SPARK_CONF_VOLUME_DRIVER)
+ .withNewConfigMap()
+ .withItems(KubernetesClientUtils.buildKeyToPathObjects(confFilesMap).asJava)
+ .withName(configMapName)
+ .endConfigMap()
+ .endVolume()
+ .endSpec()
Review comment:
Also, this new style doesn't looks better.
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -77,12 +77,9 @@ private[spark] object ClientArguments {
require(mainClass.isDefined, "Main class must be specified via --main-class")
- ClientArguments(
- mainAppResource,
- mainClass.get,
- driverArgs.toArray,
- proxyUser)
+ ClientArguments(mainAppResource, mainClass.get, driverArgs.toArray, proxyUser)
Review comment:
Why do you change this, @pingsutw ?
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -77,12 +77,9 @@ private[spark] object ClientArguments {
require(mainClass.isDefined, "Main class must be specified via --main-class")
- ClientArguments(
- mainAppResource,
- mainClass.get,
- driverArgs.toArray,
- proxyUser)
+ ClientArguments(mainAppResource, mainClass.get, driverArgs.toArray, proxyUser)
Review comment:
Why do you change this, @pingsutw ? This is irrelevant from changing an error message.
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -77,12 +77,9 @@ private[spark] object ClientArguments {
require(mainClass.isDefined, "Main class must be specified via --main-class")
- ClientArguments(
- mainAppResource,
- mainClass.get,
- driverArgs.toArray,
- proxyUser)
+ ClientArguments(mainAppResource, mainClass.get, driverArgs.toArray, proxyUser)
}
+
Review comment:
ditto.
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -100,45 +97,56 @@ private[spark] class Client(
conf: KubernetesDriverConf,
builder: KubernetesDriverBuilder,
kubernetesClient: KubernetesClient,
- watcher: LoggingPodStatusWatcher) extends Logging {
+ watcher: LoggingPodStatusWatcher)
+ extends Logging {
Review comment:
The new indentation is wrong. We use 2 space for `extends`.
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -100,45 +97,56 @@ private[spark] class Client(
conf: KubernetesDriverConf,
builder: KubernetesDriverBuilder,
kubernetesClient: KubernetesClient,
- watcher: LoggingPodStatusWatcher) extends Logging {
+ watcher: LoggingPodStatusWatcher)
+ extends Logging {
def run(): Unit = {
val resolvedDriverSpec = builder.buildFromFeatures(conf, kubernetesClient)
val configMapName = KubernetesClientUtils.configMapNameDriver
- val confFilesMap = KubernetesClientUtils.buildSparkConfDirFilesMap(configMapName,
- conf.sparkConf, resolvedDriverSpec.systemProperties)
+ val confFilesMap = KubernetesClientUtils.buildSparkConfDirFilesMap(
+ configMapName,
+ conf.sparkConf,
+ resolvedDriverSpec.systemProperties)
Review comment:
Please revert this irrelevant change.
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -136,9 +136,17 @@ private[spark] class Client(
val driverPodName = resolvedDriverPod.getMetadata.getName
var watch: Watch = null
- val createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
+ var createdDriverPod: Pod = null
try {
- val otherKubernetesResources = resolvedDriverSpec.driverKubernetesResources ++ Seq(configMap)
+ createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
+ } catch {
+ case NonFatal(e) =>
+ logError("Fail to create driver pod, you may use wrong master URL.")
+ throw e
+ }
+ try {
+ val otherKubernetesResources =
+ resolvedDriverSpec.driverKubernetesResources ++ Seq(configMap)
Review comment:
Could you keep the original one line here?
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -136,9 +136,17 @@ private[spark] class Client(
val driverPodName = resolvedDriverPod.getMetadata.getName
var watch: Watch = null
- val createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
+ var createdDriverPod: Pod = null
try {
- val otherKubernetesResources = resolvedDriverSpec.driverKubernetesResources ++ Seq(configMap)
+ createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
+ } catch {
+ case NonFatal(e) =>
+ logError("Fail to create driver pod, you may use wrong master URL.")
Review comment:
BTW, the error message looks misleading. The following can fail in many reasons. And, many user failures are due to the permissions of namespace instead of a wrong master URL.
```
kubernetesClient.pods().create(resolvedDriverPod)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32874: [SPARK-35699][K8S] Improve error message when creating k8s pod failed.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32874:
URL: https://github.com/apache/spark/pull/32874#issuecomment-863937474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org