[GitHub] [geode] kirklund commented on a diff in pull request #7737: GEODE-10301: support LocalDate and JodaTime

[GitBox <gi...@apache.org>]

kirklund commented on code in PR #7737:
URL: https://github.com/apache/geode/pull/7737#discussion_r887029999


##########
geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/rest/StandaloneClientManagementAPIAcceptanceTest.java:
##########
@@ -115,14 +115,19 @@ locatorPort, httpPort, jmxPort, getSslParameters()),
             .withName("startCluster").execute(gfsh);
 
 
+    int expectedReturnCode = 0;
     assertThat(startCluster.getProcess().exitValue())
-        .as("Cluster did not start correctly").isEqualTo(0);
+        .as("Cluster did not start correctly").isEqualTo(expectedReturnCode);
 
     Process process = launchClientProcess(outputJar, httpPort);
 
-    boolean exited = process.waitFor(30, TimeUnit.SECONDS);
-    assertThat(exited).as("Process did not exit within 10 seconds").isTrue();
-    assertThat(process.exitValue()).as("Process did not exit with 0 return code").isEqualTo(0);
+    int processTimeout = 30;

Review Comment:
   All test timeouts should use GeodeAwaitility.getTimeout() which is 5 minutes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org