You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/06/21 18:29:49 UTC

[Impala-ASF-CR] IMPALA-10545: Higher data cache write concurrency for SSDs

Hello Joe McDonnell, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18616

to look at the new patch set (#2).

Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs
......................................................................

IMPALA-10545: Higher data_cache_write_concurrency for SSDs

Provide device-specific defaults for `data_cache_write_concurrency`
based on device type. Rotational disks continue to use a default of 1,
while non-rotational disks use a default of 8. Option default of 0 is
used to select this mode.

Started cluster with
    start-impala-cluster.py --data_cache_dir=/home/michael/cache
      --data_cache_size=1G --impalad_args=--always_use_data_cache=true

and observed
> Default data_cache_write_concurrency=8 for non-rotational disk nvme0n1

Change-Id: I60761faa2710f4795f1f3eaf66da866b5553f609
---
M be/src/runtime/io/data-cache-test.cc
M be/src/runtime/io/data-cache.cc
M be/src/runtime/io/data-cache.h
3 files changed, 49 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/18616/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I60761faa2710f4795f1f3eaf66da866b5553f609
Gerrit-Change-Number: 18616
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>