You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "james strachan (JIRA)" <ji...@apache.org> on 2008/07/23 19:00:31 UTC

[jira] Created: (ZOOKEEPER-86) intermittent test failure of org.apache.zookeeper.test.AsyncTest

intermittent test failure of org.apache.zookeeper.test.AsyncTest
----------------------------------------------------------------

                 Key: ZOOKEEPER-86
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-86
             Project: Zookeeper
          Issue Type: Bug
          Components: tests
         Environment: OS X and linux. It sometimes passes; but mostly seems to fail on OS X each time
            Reporter: james strachan


Will attach the test output in an attachment...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-86) intermittent test failure of org.apache.zookeeper.test.AsyncTest

Posted by "james strachan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616365#action_12616365 ] 

james strachan commented on ZOOKEEPER-86:
-----------------------------------------

BTW I have sometimes still seen the AsyncHammerTest fail on OS X still; the basic issue is the restart of the quorum servers - its often the 3rd one - the server socket has not yet been released by the OS which tends to cause the failure. While things seem to work much better now, we might wanna add a bigger sleep in between restarts if it starts getting more common again

> intermittent test failure of org.apache.zookeeper.test.AsyncTest
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-86
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-86
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>         Environment: OS X and linux. It sometimes passes; but mostly seems to fail on OS X each time
>            Reporter: james strachan
>         Attachments: patch_for_ZOOKEEPER-86.patch, TEST-org.apache.zookeeper.test.AsyncTest.txt
>
>
> Will attach the test output in an attachment...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-86) intermittent test failure of org.apache.zookeeper.test.AsyncTest

Posted by "james strachan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

james strachan updated ZOOKEEPER-86:
------------------------------------

    Attachment: patch_for_ZOOKEEPER-86.patch

this patch seems to fix the test case on OS X at least; I've split the test case into 2 parts (so they are forked separately) and added more delays before trying to rebind to the server socket which seems to fix the error

> intermittent test failure of org.apache.zookeeper.test.AsyncTest
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-86
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-86
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>         Environment: OS X and linux. It sometimes passes; but mostly seems to fail on OS X each time
>            Reporter: james strachan
>         Attachments: patch_for_ZOOKEEPER-86.patch, TEST-org.apache.zookeeper.test.AsyncTest.txt
>
>
> Will attach the test output in an attachment...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ZOOKEEPER-86) intermittent test failure of org.apache.zookeeper.test.AsyncTest

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar resolved ZOOKEEPER-86.
------------------------------------

    Resolution: Fixed

closing this issue. this does not happen any longer.

> intermittent test failure of org.apache.zookeeper.test.AsyncTest
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-86
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-86
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>         Environment: OS X and linux. It sometimes passes; but mostly seems to fail on OS X each time
>            Reporter: james strachan
>            Assignee: james strachan
>             Fix For: 3.3.0
>
>         Attachments: patch_for_ZOOKEEPER-86.patch, TEST-org.apache.zookeeper.test.AsyncTest.txt
>
>
> Will attach the test output in an attachment...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-86) intermittent test failure of org.apache.zookeeper.test.AsyncTest

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-86:
----------------------------------

    Status: Open  (was: Patch Available)

The exceptions in the log like this:

2008-07-23 17:57:15,449 - WARN  [SendThread:ClientCnxn$SendThread@726] - Closing: 
java.io.IOException: Read error rc = -1 java.nio.DirectByteBuffer[pos=0 lim=4 cap=4]
	at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:491)
	at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:712)

are the same issue as ZOOKEEPER-63 - the client has asked the server to close the connection but hasn't noted this fact (read returns -1), then when the server closes the client complains.

I don't like adding delays since it results in the unit tests taking forever (they already take a lot more time than they should , almost all the time is due to doing sleeps). IMO tests should run very quickly so that we're more likely to run them. ;-) 

We really need a better way of handling this - see ZOOKEEPER-61 which already captures this issue with excessive/unnecessary sleep.

-1 on this patch until the two issues 61/63, are addressed and we can be certain of successful fix

It would be great if you could tackle this test "harness" issue. There are at least 3 jira (86/61/63) related to this. Hudson has intermittent failures as well. Feel free to collapse these 3 bugs into 1 jira if it makes sense to have a single patch for all of them. (or "link" them together and submit a patch against one)



> intermittent test failure of org.apache.zookeeper.test.AsyncTest
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-86
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-86
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>         Environment: OS X and linux. It sometimes passes; but mostly seems to fail on OS X each time
>            Reporter: james strachan
>            Assignee: james strachan
>         Attachments: patch_for_ZOOKEEPER-86.patch, TEST-org.apache.zookeeper.test.AsyncTest.txt
>
>
> Will attach the test output in an attachment...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-86) intermittent test failure of org.apache.zookeeper.test.AsyncTest

Posted by "james strachan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

james strachan updated ZOOKEEPER-86:
------------------------------------

    Attachment: TEST-org.apache.zookeeper.test.AsyncTest.txt

here's the output when ran on OS X (using Leopard)

> intermittent test failure of org.apache.zookeeper.test.AsyncTest
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-86
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-86
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>         Environment: OS X and linux. It sometimes passes; but mostly seems to fail on OS X each time
>            Reporter: james strachan
>         Attachments: TEST-org.apache.zookeeper.test.AsyncTest.txt
>
>
> Will attach the test output in an attachment...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-86) intermittent test failure of org.apache.zookeeper.test.AsyncTest

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-86:
-----------------------------------

    Fix Version/s: 3.3.0

> intermittent test failure of org.apache.zookeeper.test.AsyncTest
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-86
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-86
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>         Environment: OS X and linux. It sometimes passes; but mostly seems to fail on OS X each time
>            Reporter: james strachan
>            Assignee: james strachan
>             Fix For: 3.3.0
>
>         Attachments: patch_for_ZOOKEEPER-86.patch, TEST-org.apache.zookeeper.test.AsyncTest.txt
>
>
> Will attach the test output in an attachment...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ZOOKEEPER-86) intermittent test failure of org.apache.zookeeper.test.AsyncTest

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt reassigned ZOOKEEPER-86:
-------------------------------------

    Assignee: james strachan

> intermittent test failure of org.apache.zookeeper.test.AsyncTest
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-86
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-86
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>         Environment: OS X and linux. It sometimes passes; but mostly seems to fail on OS X each time
>            Reporter: james strachan
>            Assignee: james strachan
>         Attachments: patch_for_ZOOKEEPER-86.patch, TEST-org.apache.zookeeper.test.AsyncTest.txt
>
>
> Will attach the test output in an attachment...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-86) intermittent test failure of org.apache.zookeeper.test.AsyncTest

Posted by "james strachan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

james strachan updated ZOOKEEPER-86:
------------------------------------

    Status: Patch Available  (was: Open)

about to attach

> intermittent test failure of org.apache.zookeeper.test.AsyncTest
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-86
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-86
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>         Environment: OS X and linux. It sometimes passes; but mostly seems to fail on OS X each time
>            Reporter: james strachan
>         Attachments: TEST-org.apache.zookeeper.test.AsyncTest.txt
>
>
> Will attach the test output in an attachment...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.