You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/02/05 23:23:55 UTC

[GitHub] [commons-vfs] efge commented on a change in pull request #154: Rework SoftRefFilesCache locking

efge commented on a change in pull request #154:
URL: https://github.com/apache/commons-vfs/pull/154#discussion_r571304065



##########
File path: commons-vfs2/src/main/java/org/apache/commons/vfs2/cache/SoftRefFilesCache.java
##########
@@ -290,6 +286,9 @@ private boolean removeFile(final FileSystemAndNameKey key) {
         return files.isEmpty();
     }
 
+    /**
+     * Called while the lock is held
+     */
     protected Map<FileName, Reference<FileObject>> getOrCreateFilesystemCache(final FileSystem fileSystem) {

Review comment:
       Could you make this `private` so that it's consistent with all the other methods that are "called while the lock is held"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org