You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/03/31 04:35:51 UTC
[kudu-CR](gh-pages) [site] add Zhang Yifan to the committers page
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15611
to review the following change.
Change subject: [site] add Zhang Yifan to the committers page
......................................................................
[site] add Zhang Yifan to the committers page
Change-Id: Ia3f34c9659b82632e060aa2b9c655b9e1ab04b27
---
M committers.md
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/15611/1
--
To view, visit http://gerrit.cloudera.org:8080/15611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3f34c9659b82632e060aa2b9c655b9e1ab04b27
Gerrit-Change-Number: 15611
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR](gh-pages) [site] add Yifan Zhang to the committers page
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15611 )
Change subject: [site] add Yifan Zhang to the committers page
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f34c9659b82632e060aa2b9c655b9e1ab04b27
Gerrit-Change-Number: 15611
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 04:45:39 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] add Yifan Zhang to the committers page
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15611 )
Change subject: [site] add Yifan Zhang to the committers page
......................................................................
[site] add Yifan Zhang to the committers page
Change-Id: Ia3f34c9659b82632e060aa2b9c655b9e1ab04b27
Reviewed-on: http://gerrit.cloudera.org:8080/15611
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Yingchun Lai <40...@qq.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M committers.md
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Yingchun Lai: Looks good to me, but someone else must approve
Andrew Wong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3f34c9659b82632e060aa2b9c655b9e1ab04b27
Gerrit-Change-Number: 15611
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR](gh-pages) [site] add Yifan Zhang to the committers page
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15611
to look at the new patch set (#2).
Change subject: [site] add Yifan Zhang to the committers page
......................................................................
[site] add Yifan Zhang to the committers page
Change-Id: Ia3f34c9659b82632e060aa2b9c655b9e1ab04b27
---
M committers.md
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/15611/2
--
To view, visit http://gerrit.cloudera.org:8080/15611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3f34c9659b82632e060aa2b9c655b9e1ab04b27
Gerrit-Change-Number: 15611
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR](gh-pages) [site] add Yifan Zhang to the committers page
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/15611 )
Change subject: [site] add Yifan Zhang to the committers page
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f34c9659b82632e060aa2b9c655b9e1ab04b27
Gerrit-Change-Number: 15611
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 05:09:07 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] add Yifan Zhang to the committers page
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15611 )
Change subject: [site] add Yifan Zhang to the committers page
......................................................................
Patch Set 2:
Thank you for updating the page. Indeed, I took a look at the page and didn't find Yifan Zhang there, and then my mail search failed somehow :)
--
To view, visit http://gerrit.cloudera.org:8080/15611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f34c9659b82632e060aa2b9c655b9e1ab04b27
Gerrit-Change-Number: 15611
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 04:46:57 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] add Yifan Zhang to the committers page
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15611 )
Change subject: [site] add Yifan Zhang to the committers page
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f34c9659b82632e060aa2b9c655b9e1ab04b27
Gerrit-Change-Number: 15611
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 05:10:21 +0000
Gerrit-HasComments: No