You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/01/18 15:30:44 UTC

[GitHub] flink pull request #3158: [backport] [FLINK-5508] [FLINK-5496] [FLINK-5495] ...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/3158

    [backport] [FLINK-5508] [FLINK-5496] [FLINK-5495] Fix Mesos HA problems

    This PR is a backport of #3155, #3156 and #3157 onto the `release-1.2` branch.
    
    `da3358a` fixes: 
    The ZooKeeperMesosWorkerStore instantiates a ZooKeeperStateHandleStore which requires an
    Executor instance. This executor is now given to the ZooKeeperMesosWorkerStore.
    
    `e14fb2d` fixes:
    Only relocate Mesos Protobuf dependency in flink-mesos. This avoids problems with Mesos
    because Flink pulls in Protobuf 2.5.0 via Flakka.
    
    `b34a95c` fixes:
    This commit adds utility classes to abstract the CuratorFramework dependency from ZooKeeper
    utility classes away. That way it is possible for modules outside of flink-runtime to use
    these utility classes without facing the problem of a relocated curator dependency.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink backportCuratorShading

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3158
    
----
commit da3358ac5addac540910a9c492aece6435797b52
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-01-16T13:14:18Z

    [FLINK-5495] [mesos] Provide executor to ZooKeeperMesosWorkerStore
    
    The ZooKeeperMesosWorkerStore instantiates a ZooKeeperStateHandleStore which requires an
    Executor instance. This executor is now given to the ZooKeeperMesosWorkerStore.

commit e14fb2de0414378fb32aa21e88cd2ac0ba956da5
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-01-16T13:01:10Z

    [FLINK-5496] [mesos] Relocate Mesos Protobuf dependency to avoid version conflicts
    
    Only relocate Mesos Protobuf dependency in flink-mesos. This avoids problems with Mesos
    because Flink pulls in Protobuf 2.5.0 via Flakka.

commit b34a95c661aca2b301f3fef6df6adca2eb6a5e3c
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-01-18T14:06:12Z

    [FLINK-5508] [mesos] Introduce ZooKeeperUtilityFactory to create ZooKeeper utility classes
    
    This commit adds utility classes to abstract the CuratorFramework dependency from ZooKeeper
    utility classes away. That way it is possible for modules outside of flink-runtime to use
    these utility classes without facing the problem of a relocated curator dependency.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3158: [backport] [FLINK-5508] [FLINK-5496] [FLINK-5495] Fix Mes...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3158
  
    Merged to the `release-1.2` branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3158: [backport] [FLINK-5508] [FLINK-5496] [FLINK-5495] ...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann closed the pull request at:

    https://github.com/apache/flink/pull/3158


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3158: [backport] [FLINK-5508] [FLINK-5496] [FLINK-5495] Fix Mes...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3158
  
    Thanks for the review @tzulitai. I will address your comments and then merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3158: [backport] [FLINK-5508] [FLINK-5496] [FLINK-5495] Fix Mes...

Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/3158
  
    This is an identical backport / forwardport of the other 3 Mesos fixes, correct?
    If so, since #3155 and #3156 all have +1s, and #3157 is also a +1 once the minor code style comments are addressed, this is also a +1 from my side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---