You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/08/23 04:11:58 UTC
[GitHub] [servicecomb-service-center] codecov-io commented on issue #577:
Clear no-instance services automatically
codecov-io commented on issue #577: Clear no-instance services automatically
URL: https://github.com/apache/servicecomb-service-center/pull/577#issuecomment-524165372
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/servicecomb-service-center/pull/577?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/dad8f29c07a8a848469a986124236f0fcac0ac6a?src=pr&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `38.09%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/577/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #577 +/- ##
=========================================
- Coverage 58.32% 58.2% -0.12%
=========================================
Files 201 202 +1
Lines 15455 15539 +84
=========================================
+ Hits 9014 9045 +31
- Misses 5802 5852 +50
- Partials 639 642 +3
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/core/proto/types.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/577/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vdHlwZXMuZ28=) | `0% <ø> (ø)` | :arrow_up: |
| [server/core/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/577/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvY29uZmlnLmdv) | `0% <0%> (ø)` | :arrow_up: |
| [server/service/util/microservice\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/577/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==) | `62.5% <0%> (-9.83%)` | :arrow_down: |
| [server/task/clear\_service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/577/diff?src=pr&el=tree#diff-c2VydmVyL3Rhc2svY2xlYXJfc2VydmljZS5nbw==) | `64% <64%> (ø)` | |
| [syncer/pkg/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/577/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy90aWNrZXIvdGlja2VyLmdv) | `80.95% <0%> (-19.05%)` | :arrow_down: |
| [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/577/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-10%)` | :arrow_down: |
| [syncer/pkg/syssig/signal.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/577/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy9zeXNzaWcvc2lnbmFsLmdv) | `64.51% <0%> (-3.23%)` | :arrow_down: |
| [syncer/servicecenter/sync.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/577/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc3luYy5nbw==) | `71.42% <0%> (-2.39%)` | :arrow_down: |
| [server/service/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/577/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `70.57% <0%> (-0.16%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/577/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/577?src=pr&el=footer). Last update [dad8f29...1a652a7](https://codecov.io/gh/apache/servicecomb-service-center/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services