You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/04 11:32:00 UTC

[jira] [Work logged] (CRYPTO-156) Common Class Padding, Transform and AlgorithmMode

     [ https://issues.apache.org/jira/browse/CRYPTO-156?focusedWorklogId=530615&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530615 ]

ASF GitHub Bot logged work on CRYPTO-156:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jan/21 11:31
            Start Date: 04/Jan/21 11:31
    Worklog Time Spent: 10m 
      Work Description: coveralls edited a comment on pull request #126:
URL: https://github.com/apache/commons-crypto/pull/126#issuecomment-753595409


   
   [![Coverage Status](https://coveralls.io/builds/36061156/badge)](https://coveralls.io/builds/36061156)
   
   Coverage increased (+0.2%) to 82.834% when pulling **fdd44f082c00d14a98b0ee013ef86dcda7172025 on arturobernalg:featurer/CRYPTO-156** into **9c76b2c2499ca30c4e3ed84c86afed0bd82e4a1e on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 530615)
    Time Spent: 2h  (was: 1h 50m)

> Common Class Padding, Transform and AlgorithmMode
> -------------------------------------------------
>
>                 Key: CRYPTO-156
>                 URL: https://issues.apache.org/jira/browse/CRYPTO-156
>             Project: Commons Crypto
>          Issue Type: Improvement
>          Components: Cipher
>    Affects Versions: 1.1.0
>            Reporter: Arturo Bernal
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.1.1
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> In order to avoid duplicate code and try to unify the transformation of the token i think it's necessary create the next class/enum:
>  * {{OpenSslTransform}} --> Utility code for dealing with different algorithm types
>  * {{OpenSslPadding}} --> Containg the enumeration of Cipher Algorithm Padding
>  * {{OpenSslAlgorithmMode}} --> Enumeration of Algorithm Mode.
> [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java#L208]
>  [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java#L422]
>  [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java#L47]
>  [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java#L399]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)