You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Joscorbe (via GitHub)" <gi...@apache.org> on 2024/04/08 16:17:56 UTC
[PR] OAK-10758: Proposal: Add system property to control noCursorTimeout [jackrabbit-oak]
Joscorbe opened a new pull request, #1409:
URL: https://github.com/apache/jackrabbit-oak/pull/1409
This is just a proposal to solve https://issues.apache.org/jira/browse/OAK-10758
Another proposal PR is coming, that improves exception handling to avoid crashing when this exception is thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10758: Proposal: Add system property to control noCursorTimeout in Mongo iterator [jackrabbit-oak]
Posted by "Joscorbe (via GitHub)" <gi...@apache.org>.
Joscorbe closed pull request #1409: OAK-10758: Proposal: Add system property to control noCursorTimeout in Mongo iterator
URL: https://github.com/apache/jackrabbit-oak/pull/1409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10758: Proposal: Add system property to control noCursorTimeout in Mongo iterator [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on code in PR #1409:
URL: https://github.com/apache/jackrabbit-oak/pull/1409#discussion_r1565623561
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##########
@@ -867,6 +880,8 @@ && canUseModifiedTimeIdx(startValue)) {
result.maxTime(maxQueryTime, TimeUnit.MILLISECONDS);
}
+ result.noCursorTimeout(noCursorTimeout);
Review Comment:
```suggestion
if (noCursorTimeout) {
result.noCursorTimeout(noCursorTimeout);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10758: Proposal: Add system property to control noCursorTimeout in Mongo iterator [jackrabbit-oak]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1409:
URL: https://github.com/apache/jackrabbit-oak/pull/1409#issuecomment-4264795680
This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org