[jira] [Work logged] (IO-784) Add support for Appendable to HexDump util

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IO-784?focusedWorklogId=837750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837750 ]

ASF GitHub Bot logged work on IO-784:
-------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Jan/23 16:38
            Start Date: 08/Jan/23 16:38
    Worklog Time Spent: 10m 
      Work Description: garydgregory commented on code in PR #418:
URL: https://github.com/apache/commons-io/pull/418#discussion_r1064170937


##########
src/test/java/org/apache/commons/io/HexDumpTest.java:
##########
@@ -253,6 +253,16 @@ public void testDumpOutputStream() throws IOException {
 
         // verify proper behavior with null stream
         assertThrows(NullPointerException.class, () -> HexDump.dump(testArray, 0x10000000, null, 0));
+

Review Comment:
   How about reusing `ThrowOnCloseInputStream`?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 837750)
    Time Spent: 1.5h  (was: 1h 20m)

> Add support for Appendable to HexDump util
> ------------------------------------------
>
>                 Key: IO-784
>                 URL: https://issues.apache.org/jira/browse/IO-784
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 2.11.0
>            Reporter: Fredrik Kjellberg
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The HexDump utility currently only supports to send the output of the hex dump to an OutputStream. This makes it cumbersome if you want to e.g. output the dump to System.out.
> The HexDump utility should support to send the output to an `Appendable` making it possible to use e.g. `System.out` or `StringBuilder` as output targets.
> Created PR with a proposed fix: [https://github.com/apache/commons-io/pull/418]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)