You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/03/22 15:58:56 UTC
[GitHub] [ignite] ololo3000 opened a new pull request #8916: IGNITE-14376 Adds constraint on the name of metric in registry.
ololo3000 opened a new pull request #8916:
URL: https://github.com/apache/ignite/pull/8916
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ololo3000 closed pull request #8916: IGNITE-14376 Fixes exporting of discovery metrics via JMX.
Posted by GitBox <gi...@apache.org>.
ololo3000 closed pull request #8916:
URL: https://github.com/apache/ignite/pull/8916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov edited a comment on pull request #8916: IGNITE-14376 Fixes exporting of discovery metrics via JMX.
Posted by GitBox <gi...@apache.org>.
nizhikov edited a comment on pull request #8916:
URL: https://github.com/apache/ignite/pull/8916#issuecomment-808084030
@NSAmelchev
> What do you think about formalizing the name of metrics?
+1 for it.
> such change will change metric names in other exporters and can break user's monitoring systems
specific metric names are not a part of public API.
I think we can fix it and mention that in release notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ololo3000 commented on pull request #8916: IGNITE-14376 Fixes exporting of discovery metrics via JMX.
Posted by GitBox <gi...@apache.org>.
ololo3000 commented on pull request #8916:
URL: https://github.com/apache/ignite/pull/8916#issuecomment-870777426
@dspavlov You are right. The issue related to this PR has been fixed by https://issues.apache.org/jira/browse/IGNITE-14428.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on pull request #8916: IGNITE-14376 Fixes exporting of discovery metrics via JMX.
Posted by GitBox <gi...@apache.org>.
nizhikov commented on pull request #8916:
URL: https://github.com/apache/ignite/pull/8916#issuecomment-808084030
@NSAmelchev
> What do you think about formalizing the name of metrics?
+1 for it.
> such change will change metric names in other exporters and can break user's monitoring systems
specific metric names are not a part of public API.
I think we can fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] dspavlov commented on pull request #8916: IGNITE-14376 Fixes exporting of discovery metrics via JMX.
Posted by GitBox <gi...@apache.org>.
dspavlov commented on pull request #8916:
URL: https://github.com/apache/ignite/pull/8916#issuecomment-870772946
@ololo3000 was this change refused and PR #8937 applied instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on pull request #8916: IGNITE-14376 Fixes exporting of discovery metrics via JMX.
Posted by GitBox <gi...@apache.org>.
nizhikov commented on pull request #8916:
URL: https://github.com/apache/ignite/pull/8916#issuecomment-808084984
> I think the JMX exporter should be fixed
+1 for that also.
It seems we should fix both - metric names and builtin exporter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org