You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by justinleet <gi...@git.apache.org> on 2018/02/01 15:13:48 UTC
[GitHub] metron pull request #919: METRON-1439: Turn off git pager in platform-info s...
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/919
METRON-1439: Turn off git pager in platform-info script
## Contributor Comments
Just added a couple --no-pager args. Before you'd have to progress past the couple git pages, now they should just be part of the output.
Output should look something like this when run:
```
{10:08}~/Documents/workspace/metron:METRON-1439 ✗ ➭ metron-deployment/scripts/platform-info.sh
Metron 0.4.3
--
* METRON-1439
--
commit a285b83ee0153cecf24132b4aed70250040a83b0 (HEAD -> METRON-1439, upstream/master, origin/master, origin/HEAD, apache/feature/METRON-1416-upgrade-solr, master, feature/METRON-1416-upgrade-solr)
Author: nickwallen <ni...@nickallen.org>
Date: Tue Jan 30 09:31:53 2018 -0500
METRON-1432 JDK Install Fails on Ubuntu Development Environment (nickwallen) closes apache/metron#913
--
metron-deployment/scripts/platform-info.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
ansible 2.2.2.0
config file =
configured module search path = Default w/o overrides
--
Vagrant 1.8.1
--
Python 2.7.10
--
```
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinleet/metron METRON-1439
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/919.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #919
----
commit 0448218d4ef5e1321fac42350e89edd5d8131dc8
Author: justinjleet <ju...@...>
Date: 2018-02-01T15:09:10Z
Adding --no-pager args
----
---
[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/919
+1 works great for me. Thanks
---
[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/919
Sidenote, do we want to move this script to the dev-utilities dir?
---
[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/919
> Sidenote, do we want to move this script to the dev-utilities dir?
I do think it would be good to move that script. Not sure where under dev-utilities though. And we can tackle as separate PR, if you like.
---
[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/919
@ottobackwards Any objections to having the discussion outside of this and merging this in as-is?
---
[GitHub] metron pull request #919: METRON-1439: Turn off git pager in platform-info s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/919
---
[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/919
so, I'm +1 on this and we probably want a discussion outside of this about where to move `platform-info.sh`
---
[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/919
No, I am sorry, I thought that was understood. I have not reviewed, but I would go ahead based on @cestella
---
[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/919
this is a user utility though, not a dev one. I would create a new support-scripts folder
---