[GitHub] jaydoane commented on issue #476: Couchdb 3376 fix mem3 shards

[gi...@git.apache.org]

jaydoane commented on issue #476: Couchdb 3376 fix mem3 shards
URL: https://github.com/apache/couchdb/pull/476#issuecomment-294952810
 
 
   I agree with @nickva that the "writer process" pattern is very cool, and probably worthy of a blog post.
   
   FWIW, the code looks great, and the tests all pass for me:
   ```
   ======================== EUnit ========================
   module 'mem3_shards'
     mem3_shards:557: t_maybe_spawn_shard_writer_already_exists...[0.001 s] ok
     mem3_shards:566: t_maybe_spawn_shard_writer_new...ok
     mem3_shards:579: t_flush_writer_exists_normal...ok
     mem3_shards:588: t_flush_writer_times_out...[0.106 s] ok
     mem3_shards:597: t_flush_writer_crashes...ok
     mem3_shards:605: t_writer_deletes_itself_when_done...ok
     mem3_shards:618: t_writer_does_not_delete_other_writers_for_same_shard...ok
     mem3_shards:633: t_spawn_writer_in_load_shards_from_db...[0.807 s] ok
     mem3_shards:654: t_cache_insert_takes_new_update...ok
     mem3_shards:666: t_cache_insert_ignores_stale_update_and_kills_worker...ok
     [done in 2.302 s]
   =======================================================
     All 10 tests passed.
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services