You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jinmeiliao (GitHub)" <gi...@apache.org> on 2018/10/05 21:54:16 UTC
[GitHub] [geode] jinmeiliao opened pull request #2576: GEODE-5821:
exclude geode 1.4 when testing with java 9+
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2576 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #2576:
GEODE-5821: exclude geode 1.4 when testing with java 9+
Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
The fact that we can't run this test means the product also could not be run this way, which is a known and accepted limitation (users MUST upgrade geode BEFORE upgrading java). So skipping this test is the right thing to do.
[ Full content available at: https://github.com/apache/geode/pull/2576 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #2576:
GEODE-5821: exclude geode 1.4 when testing with java 9+
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
Let me ask the question in dev list.
[ Full content available at: https://github.com/apache/geode/pull/2576 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao closed pull request #2576: GEODE-5821:
exclude geode 1.4 when testing with java 9+
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2576 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2576:
GEODE-5821: exclude geode 1.4 when testing with java 9+
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Is this worth some discussion on the `dev` list? I would think that any pre `1.8` or `1.9` version of Geode shouldn't be expected to support Java 9+. Even if this is all it takes to pass the tests as they currently stand, it feels like a suckerpunch waiting to happen to run tests that aren't validly configured.
[ Full content available at: https://github.com/apache/geode/pull/2576 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #2576:
GEODE-5821: exclude geode 1.4 when testing with java 9+
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
since not much discussion about this on the dev list, looks like people don't care much if we go either way. Can we do this for now? We can always reevaluate if further upgrade tests fail on 9+ and get rid of all old versions.
[ Full content available at: https://github.com/apache/geode/pull/2576 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org