You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Ray Camden <ra...@adobe.com> on 2014/06/20 20:07:24 UTC
Contacts API, iOS
(I struggled with whether or not this should go here or the Google Group. Settled on here but if folks think it should be moved, just let me know.)
I was building a small test of the pickContact API when I noticed it didn't work in iOS. I opened up a remote debug session with Safari and noticed it had chooseContact.
Thinking it was just a doc bug, I corrected it with a pull request and returned to my code. But then my app crashed after selecting a contact.
>From what I can see, the chooseContact iOS API is:
chooseContact : function(successCallback, options) {
not
chooseContact : function(successCallback, errorCallback) {
So something is seriously weird here compared to the original docs. Anyone know what is going on with the plugin?
Re: Contacts API, iOS
Posted by Andrew Grieve <ag...@chromium.org>.
Just committed a patch to update the URLs in the docs.
http://cordova.apache.org/docs/en/edge/cordova_plugins_pluginapis.md.html#Plugin%20APIs
On Tue, Jun 24, 2014 at 10:14 PM, Ian Clelland <ic...@chromium.org>
wrote:
> On Tue, Jun 24, 2014 at 4:45 PM, Carlos Santana <cs...@gmail.com>
> wrote:
>
> > I don't have a problem having a new signature. But I think the old
> > signature should still work.
> >
> > If you decide to support both signatures, I would like to see first unit
> > test running in mobile spec it should test that both ways work.
> >
>
> This is definitely important. Not doing this is a major breaking change,
> meaning we'd need to increment the major version, and inconvenience every
> app developer who has already implemented this API, just so that we can
> break compatibility with a spec.
>
>
> >
> > I don't mind to have a new signature added since the w3c contacts spec
> api
> > is dead from what I can tell here [1]
> >
>
>
> The contacts spec *is* really out of date, and the whole thing should
> probably be overhauled. If we're going to go as far as bumping the major
> version, and pushing something like "Contacts2", then we might as well look
> at implementing a better API completely. I wouldn't do it just to switch
> arguments around.
>
> Ian
>
>
> > I guess it was implemented this way following the w3c spec api [2] had
> the
> > signature having filter first [3]
> >
> > [1]:http://www.w3.org/TR/contacts-api
> >
> > [2]: http://www.w3.org/TR/2011/WD-contacts-api-20110616/#methods-1
> >
> > [3]:caller void find
> > <
> >
> http://www.w3.org/TR/2011/WD-contacts-api-20110616/#widl-Contacts-find-caller-void-DOMStringArray-fields-ContactFindCB-successCB-ContactErrorCB-errorCB-ContactFindOptions-options
> > >
> > (DOMString[] fields, ContactFindCB
> > <
> http://www.w3.org/TR/2011/WD-contacts-api-20110616/#idl-def-ContactFindCB
> > >
> > successCB, optional ContactErrorCB
> > <
> >
> http://www.w3.org/TR/2011/WD-contacts-api-20110616/#idl-def-ContactErrorCB
> > >
> > errorCB, optional ContactFindOptions
> > <
> >
> http://www.w3.org/TR/2011/WD-contacts-api-20110616/#idl-def-ContactFindOptions
> > >
> > options);
> >
> >
> > On Tue, Jun 24, 2014 at 4:15 PM, Sergey Grebnov (Akvelon) <
> > v-segreb@microsoft.com> wrote:
> >
> > > The signature change was made by me to be compliant with the rest of
> > > cordova core plugins where we always have callbacks first and then call
> > > parameters.
> > >
> > > The important note is that I used special check for the args type to
> work
> > > correctly in case old method signature is used. I will see when it was
> > > missed.
> > >
> > > Do you like the idea of changing method signature and making it work
> for
> > > old version or it is better just to revert it back? - Thoughts?
> > >
> > > Thx!
> > > Sergey
> > > -----Original Message-----
> > > From: Carlos Santana [mailto:csantana23@gmail.com]
> > > Sent: Tuesday, June 24, 2014 11:55 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: Contacts API, iOS
> > >
> > > I took a few minutes to look deeper on what's going on with Contacts
> > > Plugin.
> > > Here are my findings:
> > >
> > > Back in April [1] when navigator.contacts.pickContact() was added the
> > > signature for navigator.contacts.find() was changed
> > > From:
> > > navigator.contacts.find:function(fields, successCB, errorCB, options) {
> > > To:
> > > navigator.contacts.find:function(successCB, errorCB, fields, options) {
> > >
> > > I think this is a braking change and the reason why mobilespec is
> > failing.
> > >
> > > If there are no objections I think the find method should be put back
> as
> > > it was before publishing a new version with a different api signature.
> I
> > > created an issue [2] to track
> > >
> > > Or if the consensus is for find function to have a new signature, then
> > the
> > > version of the plugin needs to be increase to reflect the api break,
> and
> > > maybe a note in the doc.
> > >
> > > I also created another issue [3] to create tests for pickContact in
> > > mobilespec
> > >
> > > [1]:
> > >
> > >
> >
> https://github.com/apache/cordova-plugin-contacts/commit/d656191c4072cbef0bf5b3b5f5eb4dfe4817d25b#diff-6a72b46d7f0c34e1070ce85b959f30fcR46
> > >
> > > [2]: https://issues.apache.org/jira/browse/CB-7020
> > >
> > > [3]: https://issues.apache.org/jira/browse/CB-7021
> > >
> > > --Carlos
> > >
> > >
> > >
> > > On Mon, Jun 23, 2014 at 4:21 PM, Sergey Grebnov (Akvelon) <
> > > v-segreb@microsoft.com> wrote:
> > >
> > > > As a note - pickContact functionality exists in repo/master only and
> > > > has not been released to plugins registry yet.
> > > >
> > > > Thx!
> > > > Sergey
> > > > -----Original Message-----
> > > > From: agrieve@google.com [mailto:agrieve@google.com] On Behalf Of
> > > > Andrew Grieve
> > > > Sent: Monday, June 23, 2014 9:42 PM
> > > > To: dev
> > > > Subject: Re: Contacts API, iOS
> > > >
> > > > Yes - meant plugins registry.
> > > >
> > > > right now the plugin links point to github, so you always see master
> > > >
> > > > I don't think we should concern ourselves with correcting docs for
> old
> > > > versions of plugins. It's a similar argument to fix bugs in old
> > > > versions of plugins (any changes create a new version).
> > > >
> > > >
> > > > On Mon, Jun 23, 2014 at 11:37 AM, Ray Camden <ra...@adobe.com>
> > wrote:
> > > >
> > > > > So I just want to double check to make sure I'm groking it right
> > > > > myself - this was simply a mistake in terms of the doc for version
> > > > > X+1 going live before plugin version X+1 was ready, right? When/how
> > > > > will it
> > > > be corrected?
> > > > > (Not trying to be pushy, just want to make sure I explain it well
> to
> > > > > others if asked. :)
> > > > >
> > > > >
> > > > > ________________________________________
> > > > > From: Carlos Santana <cs...@gmail.com>
> > > > > Sent: Saturday, June 21, 2014 12:09 PM
> > > > > To: dev@cordova.apache.org
> > > > > Subject: Re: Contacts API, iOS
> > > > >
> > > > > Andrew plugins are not in npm, did you meant the plugin registry.
> > > > >
> > > > > Then yes I agree that way user can read the docs that go along with
> > > > > the version of the plugin. If they have an older version of the
> > > > > plugin the can use the drop down to switch the version to an older
> > > > > version and read the corresponding docs for that version.
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Carlos Santana
> > > <cs...@gmail.com>
> > >
> >
> >
> >
> > --
> > Carlos Santana
> > <cs...@gmail.com>
> >
>
Re: Contacts API, iOS
Posted by Ian Clelland <ic...@chromium.org>.
On Tue, Jun 24, 2014 at 4:45 PM, Carlos Santana <cs...@gmail.com>
wrote:
> I don't have a problem having a new signature. But I think the old
> signature should still work.
>
> If you decide to support both signatures, I would like to see first unit
> test running in mobile spec it should test that both ways work.
>
This is definitely important. Not doing this is a major breaking change,
meaning we'd need to increment the major version, and inconvenience every
app developer who has already implemented this API, just so that we can
break compatibility with a spec.
>
> I don't mind to have a new signature added since the w3c contacts spec api
> is dead from what I can tell here [1]
>
The contacts spec *is* really out of date, and the whole thing should
probably be overhauled. If we're going to go as far as bumping the major
version, and pushing something like "Contacts2", then we might as well look
at implementing a better API completely. I wouldn't do it just to switch
arguments around.
Ian
> I guess it was implemented this way following the w3c spec api [2] had the
> signature having filter first [3]
>
> [1]:http://www.w3.org/TR/contacts-api
>
> [2]: http://www.w3.org/TR/2011/WD-contacts-api-20110616/#methods-1
>
> [3]:caller void find
> <
> http://www.w3.org/TR/2011/WD-contacts-api-20110616/#widl-Contacts-find-caller-void-DOMStringArray-fields-ContactFindCB-successCB-ContactErrorCB-errorCB-ContactFindOptions-options
> >
> (DOMString[] fields, ContactFindCB
> <http://www.w3.org/TR/2011/WD-contacts-api-20110616/#idl-def-ContactFindCB
> >
> successCB, optional ContactErrorCB
> <
> http://www.w3.org/TR/2011/WD-contacts-api-20110616/#idl-def-ContactErrorCB
> >
> errorCB, optional ContactFindOptions
> <
> http://www.w3.org/TR/2011/WD-contacts-api-20110616/#idl-def-ContactFindOptions
> >
> options);
>
>
> On Tue, Jun 24, 2014 at 4:15 PM, Sergey Grebnov (Akvelon) <
> v-segreb@microsoft.com> wrote:
>
> > The signature change was made by me to be compliant with the rest of
> > cordova core plugins where we always have callbacks first and then call
> > parameters.
> >
> > The important note is that I used special check for the args type to work
> > correctly in case old method signature is used. I will see when it was
> > missed.
> >
> > Do you like the idea of changing method signature and making it work for
> > old version or it is better just to revert it back? - Thoughts?
> >
> > Thx!
> > Sergey
> > -----Original Message-----
> > From: Carlos Santana [mailto:csantana23@gmail.com]
> > Sent: Tuesday, June 24, 2014 11:55 PM
> > To: dev@cordova.apache.org
> > Subject: Re: Contacts API, iOS
> >
> > I took a few minutes to look deeper on what's going on with Contacts
> > Plugin.
> > Here are my findings:
> >
> > Back in April [1] when navigator.contacts.pickContact() was added the
> > signature for navigator.contacts.find() was changed
> > From:
> > navigator.contacts.find:function(fields, successCB, errorCB, options) {
> > To:
> > navigator.contacts.find:function(successCB, errorCB, fields, options) {
> >
> > I think this is a braking change and the reason why mobilespec is
> failing.
> >
> > If there are no objections I think the find method should be put back as
> > it was before publishing a new version with a different api signature. I
> > created an issue [2] to track
> >
> > Or if the consensus is for find function to have a new signature, then
> the
> > version of the plugin needs to be increase to reflect the api break, and
> > maybe a note in the doc.
> >
> > I also created another issue [3] to create tests for pickContact in
> > mobilespec
> >
> > [1]:
> >
> >
> https://github.com/apache/cordova-plugin-contacts/commit/d656191c4072cbef0bf5b3b5f5eb4dfe4817d25b#diff-6a72b46d7f0c34e1070ce85b959f30fcR46
> >
> > [2]: https://issues.apache.org/jira/browse/CB-7020
> >
> > [3]: https://issues.apache.org/jira/browse/CB-7021
> >
> > --Carlos
> >
> >
> >
> > On Mon, Jun 23, 2014 at 4:21 PM, Sergey Grebnov (Akvelon) <
> > v-segreb@microsoft.com> wrote:
> >
> > > As a note - pickContact functionality exists in repo/master only and
> > > has not been released to plugins registry yet.
> > >
> > > Thx!
> > > Sergey
> > > -----Original Message-----
> > > From: agrieve@google.com [mailto:agrieve@google.com] On Behalf Of
> > > Andrew Grieve
> > > Sent: Monday, June 23, 2014 9:42 PM
> > > To: dev
> > > Subject: Re: Contacts API, iOS
> > >
> > > Yes - meant plugins registry.
> > >
> > > right now the plugin links point to github, so you always see master
> > >
> > > I don't think we should concern ourselves with correcting docs for old
> > > versions of plugins. It's a similar argument to fix bugs in old
> > > versions of plugins (any changes create a new version).
> > >
> > >
> > > On Mon, Jun 23, 2014 at 11:37 AM, Ray Camden <ra...@adobe.com>
> wrote:
> > >
> > > > So I just want to double check to make sure I'm groking it right
> > > > myself - this was simply a mistake in terms of the doc for version
> > > > X+1 going live before plugin version X+1 was ready, right? When/how
> > > > will it
> > > be corrected?
> > > > (Not trying to be pushy, just want to make sure I explain it well to
> > > > others if asked. :)
> > > >
> > > >
> > > > ________________________________________
> > > > From: Carlos Santana <cs...@gmail.com>
> > > > Sent: Saturday, June 21, 2014 12:09 PM
> > > > To: dev@cordova.apache.org
> > > > Subject: Re: Contacts API, iOS
> > > >
> > > > Andrew plugins are not in npm, did you meant the plugin registry.
> > > >
> > > > Then yes I agree that way user can read the docs that go along with
> > > > the version of the plugin. If they have an older version of the
> > > > plugin the can use the drop down to switch the version to an older
> > > > version and read the corresponding docs for that version.
> > > >
> > >
> >
> >
> >
> > --
> > Carlos Santana
> > <cs...@gmail.com>
> >
>
>
>
> --
> Carlos Santana
> <cs...@gmail.com>
>
Re: Contacts API, iOS
Posted by Carlos Santana <cs...@gmail.com>.
I don't have a problem having a new signature. But I think the old
signature should still work.
If you decide to support both signatures, I would like to see first unit
test running in mobile spec it should test that both ways work.
I don't mind to have a new signature added since the w3c contacts spec api
is dead from what I can tell here [1]
I guess it was implemented this way following the w3c spec api [2] had the
signature having filter first [3]
[1]:http://www.w3.org/TR/contacts-api
[2]: http://www.w3.org/TR/2011/WD-contacts-api-20110616/#methods-1
[3]:caller void find
<http://www.w3.org/TR/2011/WD-contacts-api-20110616/#widl-Contacts-find-caller-void-DOMStringArray-fields-ContactFindCB-successCB-ContactErrorCB-errorCB-ContactFindOptions-options>
(DOMString[] fields, ContactFindCB
<http://www.w3.org/TR/2011/WD-contacts-api-20110616/#idl-def-ContactFindCB>
successCB, optional ContactErrorCB
<http://www.w3.org/TR/2011/WD-contacts-api-20110616/#idl-def-ContactErrorCB>
errorCB, optional ContactFindOptions
<http://www.w3.org/TR/2011/WD-contacts-api-20110616/#idl-def-ContactFindOptions>
options);
On Tue, Jun 24, 2014 at 4:15 PM, Sergey Grebnov (Akvelon) <
v-segreb@microsoft.com> wrote:
> The signature change was made by me to be compliant with the rest of
> cordova core plugins where we always have callbacks first and then call
> parameters.
>
> The important note is that I used special check for the args type to work
> correctly in case old method signature is used. I will see when it was
> missed.
>
> Do you like the idea of changing method signature and making it work for
> old version or it is better just to revert it back? - Thoughts?
>
> Thx!
> Sergey
> -----Original Message-----
> From: Carlos Santana [mailto:csantana23@gmail.com]
> Sent: Tuesday, June 24, 2014 11:55 PM
> To: dev@cordova.apache.org
> Subject: Re: Contacts API, iOS
>
> I took a few minutes to look deeper on what's going on with Contacts
> Plugin.
> Here are my findings:
>
> Back in April [1] when navigator.contacts.pickContact() was added the
> signature for navigator.contacts.find() was changed
> From:
> navigator.contacts.find:function(fields, successCB, errorCB, options) {
> To:
> navigator.contacts.find:function(successCB, errorCB, fields, options) {
>
> I think this is a braking change and the reason why mobilespec is failing.
>
> If there are no objections I think the find method should be put back as
> it was before publishing a new version with a different api signature. I
> created an issue [2] to track
>
> Or if the consensus is for find function to have a new signature, then the
> version of the plugin needs to be increase to reflect the api break, and
> maybe a note in the doc.
>
> I also created another issue [3] to create tests for pickContact in
> mobilespec
>
> [1]:
>
> https://github.com/apache/cordova-plugin-contacts/commit/d656191c4072cbef0bf5b3b5f5eb4dfe4817d25b#diff-6a72b46d7f0c34e1070ce85b959f30fcR46
>
> [2]: https://issues.apache.org/jira/browse/CB-7020
>
> [3]: https://issues.apache.org/jira/browse/CB-7021
>
> --Carlos
>
>
>
> On Mon, Jun 23, 2014 at 4:21 PM, Sergey Grebnov (Akvelon) <
> v-segreb@microsoft.com> wrote:
>
> > As a note - pickContact functionality exists in repo/master only and
> > has not been released to plugins registry yet.
> >
> > Thx!
> > Sergey
> > -----Original Message-----
> > From: agrieve@google.com [mailto:agrieve@google.com] On Behalf Of
> > Andrew Grieve
> > Sent: Monday, June 23, 2014 9:42 PM
> > To: dev
> > Subject: Re: Contacts API, iOS
> >
> > Yes - meant plugins registry.
> >
> > right now the plugin links point to github, so you always see master
> >
> > I don't think we should concern ourselves with correcting docs for old
> > versions of plugins. It's a similar argument to fix bugs in old
> > versions of plugins (any changes create a new version).
> >
> >
> > On Mon, Jun 23, 2014 at 11:37 AM, Ray Camden <ra...@adobe.com> wrote:
> >
> > > So I just want to double check to make sure I'm groking it right
> > > myself - this was simply a mistake in terms of the doc for version
> > > X+1 going live before plugin version X+1 was ready, right? When/how
> > > will it
> > be corrected?
> > > (Not trying to be pushy, just want to make sure I explain it well to
> > > others if asked. :)
> > >
> > >
> > > ________________________________________
> > > From: Carlos Santana <cs...@gmail.com>
> > > Sent: Saturday, June 21, 2014 12:09 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: Contacts API, iOS
> > >
> > > Andrew plugins are not in npm, did you meant the plugin registry.
> > >
> > > Then yes I agree that way user can read the docs that go along with
> > > the version of the plugin. If they have an older version of the
> > > plugin the can use the drop down to switch the version to an older
> > > version and read the corresponding docs for that version.
> > >
> >
>
>
>
> --
> Carlos Santana
> <cs...@gmail.com>
>
--
Carlos Santana
<cs...@gmail.com>
RE: Contacts API, iOS
Posted by "Sergey Grebnov (Akvelon)" <v-...@microsoft.com>.
The signature change was made by me to be compliant with the rest of cordova core plugins where we always have callbacks first and then call parameters.
The important note is that I used special check for the args type to work correctly in case old method signature is used. I will see when it was missed.
Do you like the idea of changing method signature and making it work for old version or it is better just to revert it back? - Thoughts?
Thx!
Sergey
-----Original Message-----
From: Carlos Santana [mailto:csantana23@gmail.com]
Sent: Tuesday, June 24, 2014 11:55 PM
To: dev@cordova.apache.org
Subject: Re: Contacts API, iOS
I took a few minutes to look deeper on what's going on with Contacts Plugin.
Here are my findings:
Back in April [1] when navigator.contacts.pickContact() was added the signature for navigator.contacts.find() was changed
From:
navigator.contacts.find:function(fields, successCB, errorCB, options) {
To:
navigator.contacts.find:function(successCB, errorCB, fields, options) {
I think this is a braking change and the reason why mobilespec is failing.
If there are no objections I think the find method should be put back as it was before publishing a new version with a different api signature. I created an issue [2] to track
Or if the consensus is for find function to have a new signature, then the version of the plugin needs to be increase to reflect the api break, and maybe a note in the doc.
I also created another issue [3] to create tests for pickContact in mobilespec
[1]:
https://github.com/apache/cordova-plugin-contacts/commit/d656191c4072cbef0bf5b3b5f5eb4dfe4817d25b#diff-6a72b46d7f0c34e1070ce85b959f30fcR46
[2]: https://issues.apache.org/jira/browse/CB-7020
[3]: https://issues.apache.org/jira/browse/CB-7021
--Carlos
On Mon, Jun 23, 2014 at 4:21 PM, Sergey Grebnov (Akvelon) < v-segreb@microsoft.com> wrote:
> As a note - pickContact functionality exists in repo/master only and
> has not been released to plugins registry yet.
>
> Thx!
> Sergey
> -----Original Message-----
> From: agrieve@google.com [mailto:agrieve@google.com] On Behalf Of
> Andrew Grieve
> Sent: Monday, June 23, 2014 9:42 PM
> To: dev
> Subject: Re: Contacts API, iOS
>
> Yes - meant plugins registry.
>
> right now the plugin links point to github, so you always see master
>
> I don't think we should concern ourselves with correcting docs for old
> versions of plugins. It's a similar argument to fix bugs in old
> versions of plugins (any changes create a new version).
>
>
> On Mon, Jun 23, 2014 at 11:37 AM, Ray Camden <ra...@adobe.com> wrote:
>
> > So I just want to double check to make sure I'm groking it right
> > myself - this was simply a mistake in terms of the doc for version
> > X+1 going live before plugin version X+1 was ready, right? When/how
> > will it
> be corrected?
> > (Not trying to be pushy, just want to make sure I explain it well to
> > others if asked. :)
> >
> >
> > ________________________________________
> > From: Carlos Santana <cs...@gmail.com>
> > Sent: Saturday, June 21, 2014 12:09 PM
> > To: dev@cordova.apache.org
> > Subject: Re: Contacts API, iOS
> >
> > Andrew plugins are not in npm, did you meant the plugin registry.
> >
> > Then yes I agree that way user can read the docs that go along with
> > the version of the plugin. If they have an older version of the
> > plugin the can use the drop down to switch the version to an older
> > version and read the corresponding docs for that version.
> >
>
--
Carlos Santana
<cs...@gmail.com>
Re: Contacts API, iOS
Posted by Carlos Santana <cs...@gmail.com>.
I took a few minutes to look deeper on what's going on with Contacts Plugin.
Here are my findings:
Back in April [1] when navigator.contacts.pickContact() was added the
signature for navigator.contacts.find() was changed
From:
navigator.contacts.find:function(fields, successCB, errorCB, options) {
To:
navigator.contacts.find:function(successCB, errorCB, fields, options) {
I think this is a braking change and the reason why mobilespec is failing.
If there are no objections I think the find method should be put back as it
was before publishing a new version with a different api signature. I
created an issue [2] to track
Or if the consensus is for find function to have a new signature, then the
version of the plugin needs to be increase to reflect the api break, and
maybe a note in the doc.
I also created another issue [3] to create tests for pickContact in
mobilespec
[1]:
https://github.com/apache/cordova-plugin-contacts/commit/d656191c4072cbef0bf5b3b5f5eb4dfe4817d25b#diff-6a72b46d7f0c34e1070ce85b959f30fcR46
[2]: https://issues.apache.org/jira/browse/CB-7020
[3]: https://issues.apache.org/jira/browse/CB-7021
--Carlos
On Mon, Jun 23, 2014 at 4:21 PM, Sergey Grebnov (Akvelon) <
v-segreb@microsoft.com> wrote:
> As a note - pickContact functionality exists in repo/master only and has
> not been released to plugins registry yet.
>
> Thx!
> Sergey
> -----Original Message-----
> From: agrieve@google.com [mailto:agrieve@google.com] On Behalf Of Andrew
> Grieve
> Sent: Monday, June 23, 2014 9:42 PM
> To: dev
> Subject: Re: Contacts API, iOS
>
> Yes - meant plugins registry.
>
> right now the plugin links point to github, so you always see master
>
> I don't think we should concern ourselves with correcting docs for old
> versions of plugins. It's a similar argument to fix bugs in old versions of
> plugins (any changes create a new version).
>
>
> On Mon, Jun 23, 2014 at 11:37 AM, Ray Camden <ra...@adobe.com> wrote:
>
> > So I just want to double check to make sure I'm groking it right
> > myself - this was simply a mistake in terms of the doc for version X+1
> > going live before plugin version X+1 was ready, right? When/how will it
> be corrected?
> > (Not trying to be pushy, just want to make sure I explain it well to
> > others if asked. :)
> >
> >
> > ________________________________________
> > From: Carlos Santana <cs...@gmail.com>
> > Sent: Saturday, June 21, 2014 12:09 PM
> > To: dev@cordova.apache.org
> > Subject: Re: Contacts API, iOS
> >
> > Andrew plugins are not in npm, did you meant the plugin registry.
> >
> > Then yes I agree that way user can read the docs that go along with
> > the version of the plugin. If they have an older version of the plugin
> > the can use the drop down to switch the version to an older version
> > and read the corresponding docs for that version.
> >
>
--
Carlos Santana
<cs...@gmail.com>
RE: Contacts API, iOS
Posted by "Sergey Grebnov (Akvelon)" <v-...@microsoft.com>.
As a note - pickContact functionality exists in repo/master only and has not been released to plugins registry yet.
Thx!
Sergey
-----Original Message-----
From: agrieve@google.com [mailto:agrieve@google.com] On Behalf Of Andrew Grieve
Sent: Monday, June 23, 2014 9:42 PM
To: dev
Subject: Re: Contacts API, iOS
Yes - meant plugins registry.
right now the plugin links point to github, so you always see master
I don't think we should concern ourselves with correcting docs for old versions of plugins. It's a similar argument to fix bugs in old versions of plugins (any changes create a new version).
On Mon, Jun 23, 2014 at 11:37 AM, Ray Camden <ra...@adobe.com> wrote:
> So I just want to double check to make sure I'm groking it right
> myself - this was simply a mistake in terms of the doc for version X+1
> going live before plugin version X+1 was ready, right? When/how will it be corrected?
> (Not trying to be pushy, just want to make sure I explain it well to
> others if asked. :)
>
>
> ________________________________________
> From: Carlos Santana <cs...@gmail.com>
> Sent: Saturday, June 21, 2014 12:09 PM
> To: dev@cordova.apache.org
> Subject: Re: Contacts API, iOS
>
> Andrew plugins are not in npm, did you meant the plugin registry.
>
> Then yes I agree that way user can read the docs that go along with
> the version of the plugin. If they have an older version of the plugin
> the can use the drop down to switch the version to an older version
> and read the corresponding docs for that version.
>
Re: Contacts API, iOS
Posted by Andrew Grieve <ag...@chromium.org>.
Yes - meant plugins registry.
right now the plugin links point to github, so you always see master
I don't think we should concern ourselves with correcting docs for old
versions of plugins. It's a similar argument to fix bugs in old versions of
plugins (any changes create a new version).
On Mon, Jun 23, 2014 at 11:37 AM, Ray Camden <ra...@adobe.com> wrote:
> So I just want to double check to make sure I'm groking it right myself -
> this was simply a mistake in terms of the doc for version X+1 going live
> before plugin version X+1 was ready, right? When/how will it be corrected?
> (Not trying to be pushy, just want to make sure I explain it well to others
> if asked. :)
>
>
> ________________________________________
> From: Carlos Santana <cs...@gmail.com>
> Sent: Saturday, June 21, 2014 12:09 PM
> To: dev@cordova.apache.org
> Subject: Re: Contacts API, iOS
>
> Andrew plugins are not in npm, did you meant the plugin registry.
>
> Then yes I agree that way user can read the docs that go along with the
> version of the plugin. If they have an older version of the plugin the can
> use the drop down to switch the version to an older version and read the
> corresponding docs for that version.
>
RE: Contacts API, iOS
Posted by Ray Camden <ra...@adobe.com>.
So I just want to double check to make sure I'm groking it right myself - this was simply a mistake in terms of the doc for version X+1 going live before plugin version X+1 was ready, right? When/how will it be corrected? (Not trying to be pushy, just want to make sure I explain it well to others if asked. :)
________________________________________
From: Carlos Santana <cs...@gmail.com>
Sent: Saturday, June 21, 2014 12:09 PM
To: dev@cordova.apache.org
Subject: Re: Contacts API, iOS
Andrew plugins are not in npm, did you meant the plugin registry.
Then yes I agree that way user can read the docs that go along with the
version of the plugin. If they have an older version of the plugin the can
use the drop down to switch the version to an older version and read the
corresponding docs for that version.
Re: Contacts API, iOS
Posted by Carlos Santana <cs...@gmail.com>.
Andrew plugins are not in npm, did you meant the plugin registry.
Then yes I agree that way user can read the docs that go along with the
version of the plugin. If they have an older version of the plugin the can
use the drop down to switch the version to an older version and read the
corresponding docs for that version.
Assuming that's how is implemented the rendering of the docs on the
registry.
Ray brings an interesting point how do we handle corrections to the docs of
a plugin already released since now they are married withy the release tag
and published in the registry?
On Saturday, June 21, 2014, Andrew Grieve <ag...@chromium.org> wrote:
> One clear task: We need to update our
>
> http://cordova.apache.org/docs/en/3.5.0/cordova_plugins_pluginapis.md.html#Plugin%20APIs
> to point to the npm registry instead of github.
>
>
> On Sat, Jun 21, 2014 at 9:54 AM, Ray Camden <raycamde@adobe.com
> <javascript:;>> wrote:
>
> > My test was very simple -trying to use pickContact, so I would not have
> > seen if there were *other* problems.
> >
> > I ended up testing with the unreleased version of the plugin and it
> worked
> > great.
> >
> > Did we figure out what really happened though? Maybe a PR with the
> updated
> > doc, but not the plugin, accidentally got accepted?
> >
> > ________________________________________
> > From: Mike Billau <mike.billau@gmail.com <javascript:;>>
> > Sent: Friday, June 20, 2014 2:06 PM
> > To: dev@cordova.apache.org <javascript:;>
> > Subject: Re: Contacts API, iOS
> >
> > Just noticed this an hour ago as well. On Android, pickContact just
> doesn't
> > do anything, but some other people are reporting that the JavaScript
> itself
> > is hosed and the app won't load any .js - Ray, you didn't observe this on
> > iOS, right? It seems strange to me that an old version of the contact .js
> > would keep _any_ .js from loading.
> >
> > In the mean time I am just going to direct people to get the plugin from
> > the git URL.
> >
> >
> > On Fri, Jun 20, 2014 at 2:43 PM, Ray Camden <raycamde@adobe.com
> <javascript:;>> wrote:
> >
> > > If I had to guess, I'd say the docs lead to from docs.cordova.io are
> > > going to an unreleased version. If you go to the docs via
> > > plugins.cordova.io, you see the right docs.
> > >
> > > I *was* able to test by explicitly getting the plugin from the Git URL
> > and
> > > it works cool - can't wait for this to "officially" land.
> > >
> > > ________________________________________
> > > From: mmocny@google.com <javascript:;> <mmocny@google.com
> <javascript:;>> on behalf of Michal Mocny <
> > > mmocny@chromium.org <javascript:;>>
> > > Sent: Friday, June 20, 2014 1:36 PM
> > > To: Michal Mocny
> > > Cc: dev
> > > Subject: Re: Contacts API, iOS
> > >
> > > As far as the API documentation, and why iOS has a different
> interface..
> > I
> > > don't know the history, but this seems mighty confusing. I think
> > contacts
> > > plugin has been in need of some love for quite a while, but its been
> hard
> > > to get anyone excited about it.
> > >
> > > -Michal
> > >
> > >
> > > On Fri, Jun 20, 2014 at 2:30 PM, Michal Mocny <mmocny@chromium.org
> <javascript:;>>
> > wrote:
> > >
> > > > Alright, sorry I got confused reading the history because of some
> > > > fast-forward merges.
> > > >
> > > > Seems all is well in the repo -- but the last plugins release Steven
> > held
> > > > back contacts due to failing tests, hence whats up on
> > plugins.cordova.io
> > > > being so stale.
> > > >
> > > > -Michal
> > > >
> > > >
> > > > On Fri, Jun 20, 2014 at 2:23 PM, Michal Mocny <mmocny@chromium.org
> <javascript:;>>
> > > wrote:
> > > >
> > > >> That may not be right at all. Something seems fishy at first
> glance,
> > > but
> > > >> its hard to track the history. Ian and I are looking at it.
> > > >>
> > > >>
> > > >> On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny <mmocny@chromium.org
> <javascript:;>>
> > > >> wrote:
> > > >>
> > > >>> Looks like the last release was based on dev branch (
> > > >>>
> > >
> >
> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js
> > > ),
> > > >>> which was closed, but maybe wasn't merged in to master?
> > > >>>
> > > >>> -Michal
> > > >>>
> > > >>>
> > > >>> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden <raycamde@adobe.com
> <javascript:;>>
> > > wrote:
> > > >>>
> > > >>>> Ok, so.... doing
> > > >>>>
> > > >>>> cordova plugin add org.apache.cordova.contacts
> > > >>>>
> > > >>>> brings in org.apache.cordova.contacts/www/contacts.js that does
> NOT
> > > >>>> match what I'm seeing in
> > > >>>>
> > >
> >
> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js
> > > ,
> > > >>>> which was last updated *2* months ago.
> > > >>>>
> > > >>>> Any ideas?
> > > >>>>
> > > >>>> ________________________________________
> > > >>>> From: Ray Camden <raycamde@adobe.com <javascript:;>>
> > > >>>> Sent: Friday, June 20, 2014 1:07 PM
> > > >>>> To: dev@cordova.apache.org <javascript:;>
> > > >>>> Subject: Contacts API, iOS
> > > >>>>
> > > >>>> (I struggled with whether or not this should go here or the Google
> > > >>>> Group. Settled on here but if folks think it should be moved, just
> > > let me
> > > >>>> know.)
> > > >>>>
> > > >>>> I was building a small test of the pickContact API when I noticed
> it
> > > >>>> didn't work in iOS. I opened up a remote debug session with Safari
> > and
> > > >>>> noticed it had chooseContact.
> > > >>>>
> > > >>>> Thinking it was just a doc bug, I corrected it with a pull request
> > and
> > > >>>> returned to my code. But then my app crashed after selecting a
> > > contact.
> > > >>>>
> > > >>>> From what I can see, the chooseContact iOS API is:
> > > >>>>
> > > >>>> chooseContact : function(successCallback, options) {
> > > >>>>
> > > >>>> not
> > > >>>>
> > > >>>> chooseContact : function(successCallback, errorCallback) {
> > > >>>>
> > > >>>> So something is seriously weird here compared to the original
> docs.
> > > >>>> Anyone know what is going on with the plugin?
> > > >>>>
> > > >>>
> > > >>>
> > > >>
> > > >
> > >
> >
>
--
Carlos Santana
<cs...@gmail.com>
Re: Contacts API, iOS
Posted by Andrew Grieve <ag...@chromium.org>.
One clear task: We need to update our
http://cordova.apache.org/docs/en/3.5.0/cordova_plugins_pluginapis.md.html#Plugin%20APIs
to point to the npm registry instead of github.
On Sat, Jun 21, 2014 at 9:54 AM, Ray Camden <ra...@adobe.com> wrote:
> My test was very simple -trying to use pickContact, so I would not have
> seen if there were *other* problems.
>
> I ended up testing with the unreleased version of the plugin and it worked
> great.
>
> Did we figure out what really happened though? Maybe a PR with the updated
> doc, but not the plugin, accidentally got accepted?
>
> ________________________________________
> From: Mike Billau <mi...@gmail.com>
> Sent: Friday, June 20, 2014 2:06 PM
> To: dev@cordova.apache.org
> Subject: Re: Contacts API, iOS
>
> Just noticed this an hour ago as well. On Android, pickContact just doesn't
> do anything, but some other people are reporting that the JavaScript itself
> is hosed and the app won't load any .js - Ray, you didn't observe this on
> iOS, right? It seems strange to me that an old version of the contact .js
> would keep _any_ .js from loading.
>
> In the mean time I am just going to direct people to get the plugin from
> the git URL.
>
>
> On Fri, Jun 20, 2014 at 2:43 PM, Ray Camden <ra...@adobe.com> wrote:
>
> > If I had to guess, I'd say the docs lead to from docs.cordova.io are
> > going to an unreleased version. If you go to the docs via
> > plugins.cordova.io, you see the right docs.
> >
> > I *was* able to test by explicitly getting the plugin from the Git URL
> and
> > it works cool - can't wait for this to "officially" land.
> >
> > ________________________________________
> > From: mmocny@google.com <mm...@google.com> on behalf of Michal Mocny <
> > mmocny@chromium.org>
> > Sent: Friday, June 20, 2014 1:36 PM
> > To: Michal Mocny
> > Cc: dev
> > Subject: Re: Contacts API, iOS
> >
> > As far as the API documentation, and why iOS has a different interface..
> I
> > don't know the history, but this seems mighty confusing. I think
> contacts
> > plugin has been in need of some love for quite a while, but its been hard
> > to get anyone excited about it.
> >
> > -Michal
> >
> >
> > On Fri, Jun 20, 2014 at 2:30 PM, Michal Mocny <mm...@chromium.org>
> wrote:
> >
> > > Alright, sorry I got confused reading the history because of some
> > > fast-forward merges.
> > >
> > > Seems all is well in the repo -- but the last plugins release Steven
> held
> > > back contacts due to failing tests, hence whats up on
> plugins.cordova.io
> > > being so stale.
> > >
> > > -Michal
> > >
> > >
> > > On Fri, Jun 20, 2014 at 2:23 PM, Michal Mocny <mm...@chromium.org>
> > wrote:
> > >
> > >> That may not be right at all. Something seems fishy at first glance,
> > but
> > >> its hard to track the history. Ian and I are looking at it.
> > >>
> > >>
> > >> On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny <mm...@chromium.org>
> > >> wrote:
> > >>
> > >>> Looks like the last release was based on dev branch (
> > >>>
> >
> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js
> > ),
> > >>> which was closed, but maybe wasn't merged in to master?
> > >>>
> > >>> -Michal
> > >>>
> > >>>
> > >>> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden <ra...@adobe.com>
> > wrote:
> > >>>
> > >>>> Ok, so.... doing
> > >>>>
> > >>>> cordova plugin add org.apache.cordova.contacts
> > >>>>
> > >>>> brings in org.apache.cordova.contacts/www/contacts.js that does NOT
> > >>>> match what I'm seeing in
> > >>>>
> >
> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js
> > ,
> > >>>> which was last updated *2* months ago.
> > >>>>
> > >>>> Any ideas?
> > >>>>
> > >>>> ________________________________________
> > >>>> From: Ray Camden <ra...@adobe.com>
> > >>>> Sent: Friday, June 20, 2014 1:07 PM
> > >>>> To: dev@cordova.apache.org
> > >>>> Subject: Contacts API, iOS
> > >>>>
> > >>>> (I struggled with whether or not this should go here or the Google
> > >>>> Group. Settled on here but if folks think it should be moved, just
> > let me
> > >>>> know.)
> > >>>>
> > >>>> I was building a small test of the pickContact API when I noticed it
> > >>>> didn't work in iOS. I opened up a remote debug session with Safari
> and
> > >>>> noticed it had chooseContact.
> > >>>>
> > >>>> Thinking it was just a doc bug, I corrected it with a pull request
> and
> > >>>> returned to my code. But then my app crashed after selecting a
> > contact.
> > >>>>
> > >>>> From what I can see, the chooseContact iOS API is:
> > >>>>
> > >>>> chooseContact : function(successCallback, options) {
> > >>>>
> > >>>> not
> > >>>>
> > >>>> chooseContact : function(successCallback, errorCallback) {
> > >>>>
> > >>>> So something is seriously weird here compared to the original docs.
> > >>>> Anyone know what is going on with the plugin?
> > >>>>
> > >>>
> > >>>
> > >>
> > >
> >
>
RE: Contacts API, iOS
Posted by Ray Camden <ra...@adobe.com>.
My test was very simple -trying to use pickContact, so I would not have seen if there were *other* problems.
I ended up testing with the unreleased version of the plugin and it worked great.
Did we figure out what really happened though? Maybe a PR with the updated doc, but not the plugin, accidentally got accepted?
________________________________________
From: Mike Billau <mi...@gmail.com>
Sent: Friday, June 20, 2014 2:06 PM
To: dev@cordova.apache.org
Subject: Re: Contacts API, iOS
Just noticed this an hour ago as well. On Android, pickContact just doesn't
do anything, but some other people are reporting that the JavaScript itself
is hosed and the app won't load any .js - Ray, you didn't observe this on
iOS, right? It seems strange to me that an old version of the contact .js
would keep _any_ .js from loading.
In the mean time I am just going to direct people to get the plugin from
the git URL.
On Fri, Jun 20, 2014 at 2:43 PM, Ray Camden <ra...@adobe.com> wrote:
> If I had to guess, I'd say the docs lead to from docs.cordova.io are
> going to an unreleased version. If you go to the docs via
> plugins.cordova.io, you see the right docs.
>
> I *was* able to test by explicitly getting the plugin from the Git URL and
> it works cool - can't wait for this to "officially" land.
>
> ________________________________________
> From: mmocny@google.com <mm...@google.com> on behalf of Michal Mocny <
> mmocny@chromium.org>
> Sent: Friday, June 20, 2014 1:36 PM
> To: Michal Mocny
> Cc: dev
> Subject: Re: Contacts API, iOS
>
> As far as the API documentation, and why iOS has a different interface.. I
> don't know the history, but this seems mighty confusing. I think contacts
> plugin has been in need of some love for quite a while, but its been hard
> to get anyone excited about it.
>
> -Michal
>
>
> On Fri, Jun 20, 2014 at 2:30 PM, Michal Mocny <mm...@chromium.org> wrote:
>
> > Alright, sorry I got confused reading the history because of some
> > fast-forward merges.
> >
> > Seems all is well in the repo -- but the last plugins release Steven held
> > back contacts due to failing tests, hence whats up on plugins.cordova.io
> > being so stale.
> >
> > -Michal
> >
> >
> > On Fri, Jun 20, 2014 at 2:23 PM, Michal Mocny <mm...@chromium.org>
> wrote:
> >
> >> That may not be right at all. Something seems fishy at first glance,
> but
> >> its hard to track the history. Ian and I are looking at it.
> >>
> >>
> >> On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny <mm...@chromium.org>
> >> wrote:
> >>
> >>> Looks like the last release was based on dev branch (
> >>>
> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js
> ),
> >>> which was closed, but maybe wasn't merged in to master?
> >>>
> >>> -Michal
> >>>
> >>>
> >>> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden <ra...@adobe.com>
> wrote:
> >>>
> >>>> Ok, so.... doing
> >>>>
> >>>> cordova plugin add org.apache.cordova.contacts
> >>>>
> >>>> brings in org.apache.cordova.contacts/www/contacts.js that does NOT
> >>>> match what I'm seeing in
> >>>>
> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js
> ,
> >>>> which was last updated *2* months ago.
> >>>>
> >>>> Any ideas?
> >>>>
> >>>> ________________________________________
> >>>> From: Ray Camden <ra...@adobe.com>
> >>>> Sent: Friday, June 20, 2014 1:07 PM
> >>>> To: dev@cordova.apache.org
> >>>> Subject: Contacts API, iOS
> >>>>
> >>>> (I struggled with whether or not this should go here or the Google
> >>>> Group. Settled on here but if folks think it should be moved, just
> let me
> >>>> know.)
> >>>>
> >>>> I was building a small test of the pickContact API when I noticed it
> >>>> didn't work in iOS. I opened up a remote debug session with Safari and
> >>>> noticed it had chooseContact.
> >>>>
> >>>> Thinking it was just a doc bug, I corrected it with a pull request and
> >>>> returned to my code. But then my app crashed after selecting a
> contact.
> >>>>
> >>>> From what I can see, the chooseContact iOS API is:
> >>>>
> >>>> chooseContact : function(successCallback, options) {
> >>>>
> >>>> not
> >>>>
> >>>> chooseContact : function(successCallback, errorCallback) {
> >>>>
> >>>> So something is seriously weird here compared to the original docs.
> >>>> Anyone know what is going on with the plugin?
> >>>>
> >>>
> >>>
> >>
> >
>
Re: Contacts API, iOS
Posted by Mike Billau <mi...@gmail.com>.
Just noticed this an hour ago as well. On Android, pickContact just doesn't
do anything, but some other people are reporting that the JavaScript itself
is hosed and the app won't load any .js - Ray, you didn't observe this on
iOS, right? It seems strange to me that an old version of the contact .js
would keep _any_ .js from loading.
In the mean time I am just going to direct people to get the plugin from
the git URL.
On Fri, Jun 20, 2014 at 2:43 PM, Ray Camden <ra...@adobe.com> wrote:
> If I had to guess, I'd say the docs lead to from docs.cordova.io are
> going to an unreleased version. If you go to the docs via
> plugins.cordova.io, you see the right docs.
>
> I *was* able to test by explicitly getting the plugin from the Git URL and
> it works cool - can't wait for this to "officially" land.
>
> ________________________________________
> From: mmocny@google.com <mm...@google.com> on behalf of Michal Mocny <
> mmocny@chromium.org>
> Sent: Friday, June 20, 2014 1:36 PM
> To: Michal Mocny
> Cc: dev
> Subject: Re: Contacts API, iOS
>
> As far as the API documentation, and why iOS has a different interface.. I
> don't know the history, but this seems mighty confusing. I think contacts
> plugin has been in need of some love for quite a while, but its been hard
> to get anyone excited about it.
>
> -Michal
>
>
> On Fri, Jun 20, 2014 at 2:30 PM, Michal Mocny <mm...@chromium.org> wrote:
>
> > Alright, sorry I got confused reading the history because of some
> > fast-forward merges.
> >
> > Seems all is well in the repo -- but the last plugins release Steven held
> > back contacts due to failing tests, hence whats up on plugins.cordova.io
> > being so stale.
> >
> > -Michal
> >
> >
> > On Fri, Jun 20, 2014 at 2:23 PM, Michal Mocny <mm...@chromium.org>
> wrote:
> >
> >> That may not be right at all. Something seems fishy at first glance,
> but
> >> its hard to track the history. Ian and I are looking at it.
> >>
> >>
> >> On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny <mm...@chromium.org>
> >> wrote:
> >>
> >>> Looks like the last release was based on dev branch (
> >>>
> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js
> ),
> >>> which was closed, but maybe wasn't merged in to master?
> >>>
> >>> -Michal
> >>>
> >>>
> >>> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden <ra...@adobe.com>
> wrote:
> >>>
> >>>> Ok, so.... doing
> >>>>
> >>>> cordova plugin add org.apache.cordova.contacts
> >>>>
> >>>> brings in org.apache.cordova.contacts/www/contacts.js that does NOT
> >>>> match what I'm seeing in
> >>>>
> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js
> ,
> >>>> which was last updated *2* months ago.
> >>>>
> >>>> Any ideas?
> >>>>
> >>>> ________________________________________
> >>>> From: Ray Camden <ra...@adobe.com>
> >>>> Sent: Friday, June 20, 2014 1:07 PM
> >>>> To: dev@cordova.apache.org
> >>>> Subject: Contacts API, iOS
> >>>>
> >>>> (I struggled with whether or not this should go here or the Google
> >>>> Group. Settled on here but if folks think it should be moved, just
> let me
> >>>> know.)
> >>>>
> >>>> I was building a small test of the pickContact API when I noticed it
> >>>> didn't work in iOS. I opened up a remote debug session with Safari and
> >>>> noticed it had chooseContact.
> >>>>
> >>>> Thinking it was just a doc bug, I corrected it with a pull request and
> >>>> returned to my code. But then my app crashed after selecting a
> contact.
> >>>>
> >>>> From what I can see, the chooseContact iOS API is:
> >>>>
> >>>> chooseContact : function(successCallback, options) {
> >>>>
> >>>> not
> >>>>
> >>>> chooseContact : function(successCallback, errorCallback) {
> >>>>
> >>>> So something is seriously weird here compared to the original docs.
> >>>> Anyone know what is going on with the plugin?
> >>>>
> >>>
> >>>
> >>
> >
>
RE: Contacts API, iOS
Posted by Ray Camden <ra...@adobe.com>.
If I had to guess, I'd say the docs lead to from docs.cordova.io are going to an unreleased version. If you go to the docs via plugins.cordova.io, you see the right docs.
I *was* able to test by explicitly getting the plugin from the Git URL and it works cool - can't wait for this to "officially" land.
________________________________________
From: mmocny@google.com <mm...@google.com> on behalf of Michal Mocny <mm...@chromium.org>
Sent: Friday, June 20, 2014 1:36 PM
To: Michal Mocny
Cc: dev
Subject: Re: Contacts API, iOS
As far as the API documentation, and why iOS has a different interface.. I
don't know the history, but this seems mighty confusing. I think contacts
plugin has been in need of some love for quite a while, but its been hard
to get anyone excited about it.
-Michal
On Fri, Jun 20, 2014 at 2:30 PM, Michal Mocny <mm...@chromium.org> wrote:
> Alright, sorry I got confused reading the history because of some
> fast-forward merges.
>
> Seems all is well in the repo -- but the last plugins release Steven held
> back contacts due to failing tests, hence whats up on plugins.cordova.io
> being so stale.
>
> -Michal
>
>
> On Fri, Jun 20, 2014 at 2:23 PM, Michal Mocny <mm...@chromium.org> wrote:
>
>> That may not be right at all. Something seems fishy at first glance, but
>> its hard to track the history. Ian and I are looking at it.
>>
>>
>> On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny <mm...@chromium.org>
>> wrote:
>>
>>> Looks like the last release was based on dev branch (
>>> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js),
>>> which was closed, but maybe wasn't merged in to master?
>>>
>>> -Michal
>>>
>>>
>>> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden <ra...@adobe.com> wrote:
>>>
>>>> Ok, so.... doing
>>>>
>>>> cordova plugin add org.apache.cordova.contacts
>>>>
>>>> brings in org.apache.cordova.contacts/www/contacts.js that does NOT
>>>> match what I'm seeing in
>>>> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js,
>>>> which was last updated *2* months ago.
>>>>
>>>> Any ideas?
>>>>
>>>> ________________________________________
>>>> From: Ray Camden <ra...@adobe.com>
>>>> Sent: Friday, June 20, 2014 1:07 PM
>>>> To: dev@cordova.apache.org
>>>> Subject: Contacts API, iOS
>>>>
>>>> (I struggled with whether or not this should go here or the Google
>>>> Group. Settled on here but if folks think it should be moved, just let me
>>>> know.)
>>>>
>>>> I was building a small test of the pickContact API when I noticed it
>>>> didn't work in iOS. I opened up a remote debug session with Safari and
>>>> noticed it had chooseContact.
>>>>
>>>> Thinking it was just a doc bug, I corrected it with a pull request and
>>>> returned to my code. But then my app crashed after selecting a contact.
>>>>
>>>> From what I can see, the chooseContact iOS API is:
>>>>
>>>> chooseContact : function(successCallback, options) {
>>>>
>>>> not
>>>>
>>>> chooseContact : function(successCallback, errorCallback) {
>>>>
>>>> So something is seriously weird here compared to the original docs.
>>>> Anyone know what is going on with the plugin?
>>>>
>>>
>>>
>>
>
Re: Contacts API, iOS
Posted by Michal Mocny <mm...@chromium.org>.
As far as the API documentation, and why iOS has a different interface.. I
don't know the history, but this seems mighty confusing. I think contacts
plugin has been in need of some love for quite a while, but its been hard
to get anyone excited about it.
-Michal
On Fri, Jun 20, 2014 at 2:30 PM, Michal Mocny <mm...@chromium.org> wrote:
> Alright, sorry I got confused reading the history because of some
> fast-forward merges.
>
> Seems all is well in the repo -- but the last plugins release Steven held
> back contacts due to failing tests, hence whats up on plugins.cordova.io
> being so stale.
>
> -Michal
>
>
> On Fri, Jun 20, 2014 at 2:23 PM, Michal Mocny <mm...@chromium.org> wrote:
>
>> That may not be right at all. Something seems fishy at first glance, but
>> its hard to track the history. Ian and I are looking at it.
>>
>>
>> On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny <mm...@chromium.org>
>> wrote:
>>
>>> Looks like the last release was based on dev branch (
>>> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js),
>>> which was closed, but maybe wasn't merged in to master?
>>>
>>> -Michal
>>>
>>>
>>> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden <ra...@adobe.com> wrote:
>>>
>>>> Ok, so.... doing
>>>>
>>>> cordova plugin add org.apache.cordova.contacts
>>>>
>>>> brings in org.apache.cordova.contacts/www/contacts.js that does NOT
>>>> match what I'm seeing in
>>>> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js,
>>>> which was last updated *2* months ago.
>>>>
>>>> Any ideas?
>>>>
>>>> ________________________________________
>>>> From: Ray Camden <ra...@adobe.com>
>>>> Sent: Friday, June 20, 2014 1:07 PM
>>>> To: dev@cordova.apache.org
>>>> Subject: Contacts API, iOS
>>>>
>>>> (I struggled with whether or not this should go here or the Google
>>>> Group. Settled on here but if folks think it should be moved, just let me
>>>> know.)
>>>>
>>>> I was building a small test of the pickContact API when I noticed it
>>>> didn't work in iOS. I opened up a remote debug session with Safari and
>>>> noticed it had chooseContact.
>>>>
>>>> Thinking it was just a doc bug, I corrected it with a pull request and
>>>> returned to my code. But then my app crashed after selecting a contact.
>>>>
>>>> From what I can see, the chooseContact iOS API is:
>>>>
>>>> chooseContact : function(successCallback, options) {
>>>>
>>>> not
>>>>
>>>> chooseContact : function(successCallback, errorCallback) {
>>>>
>>>> So something is seriously weird here compared to the original docs.
>>>> Anyone know what is going on with the plugin?
>>>>
>>>
>>>
>>
>
Re: Contacts API, iOS
Posted by Michal Mocny <mm...@chromium.org>.
Alright, sorry I got confused reading the history because of some
fast-forward merges.
Seems all is well in the repo -- but the last plugins release Steven held
back contacts due to failing tests, hence whats up on plugins.cordova.io
being so stale.
-Michal
On Fri, Jun 20, 2014 at 2:23 PM, Michal Mocny <mm...@chromium.org> wrote:
> That may not be right at all. Something seems fishy at first glance, but
> its hard to track the history. Ian and I are looking at it.
>
>
> On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny <mm...@chromium.org> wrote:
>
>> Looks like the last release was based on dev branch (
>> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js),
>> which was closed, but maybe wasn't merged in to master?
>>
>> -Michal
>>
>>
>> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden <ra...@adobe.com> wrote:
>>
>>> Ok, so.... doing
>>>
>>> cordova plugin add org.apache.cordova.contacts
>>>
>>> brings in org.apache.cordova.contacts/www/contacts.js that does NOT
>>> match what I'm seeing in
>>> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js,
>>> which was last updated *2* months ago.
>>>
>>> Any ideas?
>>>
>>> ________________________________________
>>> From: Ray Camden <ra...@adobe.com>
>>> Sent: Friday, June 20, 2014 1:07 PM
>>> To: dev@cordova.apache.org
>>> Subject: Contacts API, iOS
>>>
>>> (I struggled with whether or not this should go here or the Google
>>> Group. Settled on here but if folks think it should be moved, just let me
>>> know.)
>>>
>>> I was building a small test of the pickContact API when I noticed it
>>> didn't work in iOS. I opened up a remote debug session with Safari and
>>> noticed it had chooseContact.
>>>
>>> Thinking it was just a doc bug, I corrected it with a pull request and
>>> returned to my code. But then my app crashed after selecting a contact.
>>>
>>> From what I can see, the chooseContact iOS API is:
>>>
>>> chooseContact : function(successCallback, options) {
>>>
>>> not
>>>
>>> chooseContact : function(successCallback, errorCallback) {
>>>
>>> So something is seriously weird here compared to the original docs.
>>> Anyone know what is going on with the plugin?
>>>
>>
>>
>
Re: Contacts API, iOS
Posted by Michal Mocny <mm...@chromium.org>.
That may not be right at all. Something seems fishy at first glance, but
its hard to track the history. Ian and I are looking at it.
On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny <mm...@chromium.org> wrote:
> Looks like the last release was based on dev branch (
> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js),
> which was closed, but maybe wasn't merged in to master?
>
> -Michal
>
>
> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden <ra...@adobe.com> wrote:
>
>> Ok, so.... doing
>>
>> cordova plugin add org.apache.cordova.contacts
>>
>> brings in org.apache.cordova.contacts/www/contacts.js that does NOT match
>> what I'm seeing in
>> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js,
>> which was last updated *2* months ago.
>>
>> Any ideas?
>>
>> ________________________________________
>> From: Ray Camden <ra...@adobe.com>
>> Sent: Friday, June 20, 2014 1:07 PM
>> To: dev@cordova.apache.org
>> Subject: Contacts API, iOS
>>
>> (I struggled with whether or not this should go here or the Google Group.
>> Settled on here but if folks think it should be moved, just let me know.)
>>
>> I was building a small test of the pickContact API when I noticed it
>> didn't work in iOS. I opened up a remote debug session with Safari and
>> noticed it had chooseContact.
>>
>> Thinking it was just a doc bug, I corrected it with a pull request and
>> returned to my code. But then my app crashed after selecting a contact.
>>
>> From what I can see, the chooseContact iOS API is:
>>
>> chooseContact : function(successCallback, options) {
>>
>> not
>>
>> chooseContact : function(successCallback, errorCallback) {
>>
>> So something is seriously weird here compared to the original docs.
>> Anyone know what is going on with the plugin?
>>
>
>
Re: Contacts API, iOS
Posted by Michal Mocny <mm...@chromium.org>.
Looks like the last release was based on dev branch (
https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js),
which was closed, but maybe wasn't merged in to master?
-Michal
On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden <ra...@adobe.com> wrote:
> Ok, so.... doing
>
> cordova plugin add org.apache.cordova.contacts
>
> brings in org.apache.cordova.contacts/www/contacts.js that does NOT match
> what I'm seeing in
> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js,
> which was last updated *2* months ago.
>
> Any ideas?
>
> ________________________________________
> From: Ray Camden <ra...@adobe.com>
> Sent: Friday, June 20, 2014 1:07 PM
> To: dev@cordova.apache.org
> Subject: Contacts API, iOS
>
> (I struggled with whether or not this should go here or the Google Group.
> Settled on here but if folks think it should be moved, just let me know.)
>
> I was building a small test of the pickContact API when I noticed it
> didn't work in iOS. I opened up a remote debug session with Safari and
> noticed it had chooseContact.
>
> Thinking it was just a doc bug, I corrected it with a pull request and
> returned to my code. But then my app crashed after selecting a contact.
>
> From what I can see, the chooseContact iOS API is:
>
> chooseContact : function(successCallback, options) {
>
> not
>
> chooseContact : function(successCallback, errorCallback) {
>
> So something is seriously weird here compared to the original docs. Anyone
> know what is going on with the plugin?
>
RE: Contacts API, iOS
Posted by Ray Camden <ra...@adobe.com>.
Ok, so.... doing
cordova plugin add org.apache.cordova.contacts
brings in org.apache.cordova.contacts/www/contacts.js that does NOT match what I'm seeing in https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js, which was last updated *2* months ago.
Any ideas?
________________________________________
From: Ray Camden <ra...@adobe.com>
Sent: Friday, June 20, 2014 1:07 PM
To: dev@cordova.apache.org
Subject: Contacts API, iOS
(I struggled with whether or not this should go here or the Google Group. Settled on here but if folks think it should be moved, just let me know.)
I was building a small test of the pickContact API when I noticed it didn't work in iOS. I opened up a remote debug session with Safari and noticed it had chooseContact.
Thinking it was just a doc bug, I corrected it with a pull request and returned to my code. But then my app crashed after selecting a contact.
>From what I can see, the chooseContact iOS API is:
chooseContact : function(successCallback, options) {
not
chooseContact : function(successCallback, errorCallback) {
So something is seriously weird here compared to the original docs. Anyone know what is going on with the plugin?