[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1034: [CELEBORN-76][FOLLOWUP] fix inFlightCommitRequest counting problem

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on PR #1034:
URL: https://github.com/apache/incubator-celeborn/pull/1034#issuecomment-1333318744

   > > > I don't quite get the point this pr fixes, could you explain more? IMO the inFlightCommitRequest stores the number of commitFiles requests, each request can commit files to multiple workers.
   > > 
   > > 
   > > because it may only be partially success, as stageEnd process waits on shuffleCommittedInfo.inFlightCommitRequest, CommitThreads in batchHandleCommitPartitionExecutors may not even execute, but inFlightCommitRequest may be equal to 0.
   > 
   > Previously we increment by 1 before requestCommitFilesWithRetry and decrements by 1 after returns, I think it's consistent.
   
   We are calculating the completion of this batch. In the previous code, we can only guarantee that the request of a certain worker in this batch is completed, but it is possible that the request of other workers has not started yet, so it enters the calculation datalost


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org