You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2009/07/06 22:48:54 UTC
Re: svn commit: r38357 - trunk/build/generator/templates
Why?!
On Tue, Jul 7, 2009 at 00:05, Arfrever Frehtes Taifersar
Arahesis<Ar...@gmail.com> wrote:
> Author: arfrever
> Date: Mon Jul 6 15:05:04 2009
> New Revision: 38357
>
> Log:
> Support per-target LDFLAGS.
>
> * build/generator/templates/makefile.ezt: Support per-target LDFLAGS.
>
> Modified:
> trunk/build/generator/templates/makefile.ezt
>
> Modified: trunk/build/generator/templates/makefile.ezt
> URL: http://svn.collab.net/viewvc/svn/trunk/build/generator/templates/makefile.ezt?pathrev=38357&r1=38356&r2=38357
> ==============================================================================
> --- trunk/build/generator/templates/makefile.ezt Mon Jul 6 13:58:30 2009 (r38356)
> +++ trunk/build/generator/templates/makefile.ezt Mon Jul 6 15:05:04 2009 (r38357)
> @@ -80,7 +80,7 @@ $([target.varname]_OBJECTS): $([target.v
> [else][target.varname]_DEPS = [target.add_deps][for target.objects] [target.objects][end][for target.deps] [target.deps][end]
> [target.varname]_OBJECTS =[for target.objnames] [target.objnames][end]
> [target.filename]: $([target.varname]_DEPS)
> - cd [target.path] && [target.link_cmd] -o [target.basename] [target.undefined_flag] $([target.varname]_OBJECTS)[for target.libs] [target.libs][end] $(LIBS)
> + cd [target.path] && [target.link_cmd] $([target.varname]_LDFLAGS) -o [target.basename] [target.undefined_flag] $([target.varname]_OBJECTS)[for target.libs] [target.libs][end] $(LIBS)
> [end][end][end]
>
> ########################################
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2368560
>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2368572
Re: svn commit: r38357 - trunk/build/generator/templates
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Julian Foad wrote on Tue, 7 Jul 2009 at 10:40 +0100:
> The point is that the log messages should enable every one of us to
> understand, at a high level, WHY things are being changed as well as
> WHAT was changed.
>
> Whenever somebody asks you, "Why?" in response to your commit, it means
> the log message should have contained the answer but it didn't, so
> please put the answer into the log message.
+1.
(was about to suggest to append it to hacking.html#log-messages, but
the latter is getting rather long...)
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2368958
Re: svn commit: r38357 - trunk/build/generator/templates
Posted by Julian Foad <ju...@btopenworld.com>.
Arfrever Frehtes Taifersar Arahesis wrote:
> 2009-07-07 00:48:54 Greg Stein napisał(a):
> > On Tue, Jul 7, 2009 at 00:05, Arfrever Frehtes Taifersar Arahesis<Ar...@gmail.com> wrote:
> > > Log:
> > > Support per-target LDFLAGS.
> > >
> > > * build/generator/templates/makefile.ezt: Support per-target LDFLAGS.
> >
> > Why?!
>
> It was required for changes committed in r38359.
Arfrever,
Please edit the log message to say this, at least.
To me, unfamiliar as I am with this set of changes, that isn't
descriptive enough for me to understand by itself, so if you can add a
bit more explanation that would be great.
The point is that the log messages should enable every one of us to
understand, at a high level, WHY things are being changed as well as
WHAT was changed.
Whenever somebody asks you, "Why?" in response to your commit, it means
the log message should have contained the answer but it didn't, so
please put the answer into the log message.
Thanks.
- Julian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2368705
Re: svn commit: r38357 - trunk/build/generator/templates
Posted by Arfrever Frehtes Taifersar Arahesis <Ar...@GMail.Com>.
2009-07-07 00:48:54 Greg Stein napisał(a):
> On Tue, Jul 7, 2009 at 00:05, Arfrever Frehtes Taifersar Arahesis<Ar...@gmail.com> wrote:
> > Author: arfrever
> > Date: Mon Jul 6 15:05:04 2009
> > New Revision: 38357
> >
> > Log:
> > Support per-target LDFLAGS.
> >
> > * build/generator/templates/makefile.ezt: Support per-target LDFLAGS.
> >
> > Modified:
> > trunk/build/generator/templates/makefile.ezt
> >
> > Modified: trunk/build/generator/templates/makefile.ezt
> > URL: http://svn.collab.net/viewvc/svn/trunk/build/generator/templates/makefile.ezt?pathrev=38357&r1=38356&r2=38357
> > ==============================================================================
> > --- trunk/build/generator/templates/makefile.ezt Mon Jul 6 13:58:30 2009 (r38356)
> > +++ trunk/build/generator/templates/makefile.ezt Mon Jul 6 15:05:04 2009 (r38357)
> > @@ -80,7 +80,7 @@ $([target.varname]_OBJECTS): $([target.v
> > [else][target.varname]_DEPS = [target.add_deps][for target.objects] [target.objects][end][for target.deps] [target.deps][end]
> > [target.varname]_OBJECTS =[for target.objnames] [target.objnames][end]
> > [target.filename]: $([target.varname]_DEPS)
> > - cd [target.path] && [target.link_cmd] -o [target.basename] [target.undefined_flag] $([target.varname]_OBJECTS)[for target.libs] [target.libs][end] $(LIBS)
> > + cd [target.path] && [target.link_cmd] $([target.varname]_LDFLAGS) -o [target.basename] [target.undefined_flag] $([target.varname]_OBJECTS)[for target.libs] [target.libs][end] $(LIBS)
> > [end][end][end]
> >
> > ########################################
>
> Why?!
It was required for changes committed in r38359.
--
Arfrever Frehtes Taifersar Arahesis