[jira] Commented: (MECLIPSE-151) Incorrect name for test sources jars

["Brian Fox (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MECLIPSE-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101205 ] 

Brian Fox commented on MECLIPSE-151:
------------------------------------

I'm ready to release 2.4 so I took a look at this and MECLIPSE-287. Something doesn't seem right with the tests in this patch. It is expecting the sources to be downloaded, but I don't see this set in any of the tests. I tried updating the test pom and still have issues. This is the .classpath I get:

{noformat}
<classpath>
  <classpathentry kind="output" path="target/classes"/>
  <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
  <classpathentry kind="var" path="M2_REPO/maven/maven-core/98.0/maven-core-98.0-tests.jar"/>
</classpath>
{noformat}

Also note, the patch contains project27, but this is now taken. I needed to update everything to project35.

> Incorrect name for test sources jars
> ------------------------------------
>
>                 Key: MECLIPSE-151
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-151
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Richard van der Hoff
>            Assignee: fabrizio giustina
>             Fix For: 2.4
>
>         Attachments: maven-eclipse-plugin.patch
>
>
> The eclipse plugin currently sets the source attachment of dependencies on test-jars (as created by the test-jar goal of the jar plugin) to the same as that of the main jar. 
> To fix, we need to check the classifier of dependencies when finding sources, and if it is "tests", use "test-sources" rather than "sources" for the classifier on the sources jar.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira