You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/18 13:51:58 UTC
[GitHub] [iotdb] wangchao316 opened a new pull request #5284: [IOTDB-2730] Config node server
wangchao316 opened a new pull request #5284:
URL: https://github.com/apache/iotdb/pull/5284
1.Extract the thrift service to the commons module.
2.Adding a config node server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a change in pull request #5284: [IOTDB-2730] Config node server
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #5284:
URL: https://github.com/apache/iotdb/pull/5284#discussion_r830431786
##########
File path: confignode/src/assembly/resources/conf/iotdb-confignode.properties
##########
@@ -20,6 +20,22 @@
####################
### DeviceGroup Configuration
####################
+# could set ip or hostname
+# Datatype: String
+config_node_rpc_address=host0
+
+# used for communication between data node and config node
+# Datatype: int
+config_node_rpc_port=22277
+
+# used for communication between data node and data node
+# Datatype: int
+config_node_internal_port=22278
+
Review comment:
sorry, comments error. I alter it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 merged pull request #5284: [IOTDB-2730] Config node server
Posted by GitBox <gi...@apache.org>.
wangchao316 merged pull request #5284:
URL: https://github.com/apache/iotdb/pull/5284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a change in pull request #5284: [IOTDB-2730] Config node server
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #5284:
URL: https://github.com/apache/iotdb/pull/5284#discussion_r830432110
##########
File path: confignode/src/assembly/resources/conf/iotdb-confignode.properties
##########
@@ -20,6 +20,22 @@
####################
### DeviceGroup Configuration
####################
+# could set ip or hostname
+# Datatype: String
+config_node_rpc_address=host0
+
+# used for communication between data node and config node
+# Datatype: int
+config_node_rpc_port=22277
+
+# used for communication between data node and data node
+# Datatype: int
+config_node_internal_port=22278
+
+# all config node address
+# every node should have the same config_node_address_lists
+# Datatype: String
+config_node_address_lists=host0,host1,host2
Review comment:
yes, need add port
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan commented on a change in pull request #5284: [IOTDB-2730] Config node server
Posted by GitBox <gi...@apache.org>.
neuyilan commented on a change in pull request #5284:
URL: https://github.com/apache/iotdb/pull/5284#discussion_r830427088
##########
File path: confignode/src/assembly/resources/conf/iotdb-confignode.properties
##########
@@ -20,6 +20,22 @@
####################
### DeviceGroup Configuration
####################
+# could set ip or hostname
+# Datatype: String
+config_node_rpc_address=host0
+
+# used for communication between data node and config node
+# Datatype: int
+config_node_rpc_port=22277
+
+# used for communication between data node and data node
+# Datatype: int
+config_node_internal_port=22278
+
Review comment:
Why does the port of datanode communication appear in the confignode configuration? maybe the comments is error?
```suggestion
# used for communication between config node and config node
# Datatype: int
config_node_internal_port=22278
```
##########
File path: confignode/src/assembly/resources/conf/iotdb-confignode.properties
##########
@@ -20,6 +20,22 @@
####################
### DeviceGroup Configuration
####################
+# could set ip or hostname
+# Datatype: String
+config_node_rpc_address=host0
+
+# used for communication between data node and config node
+# Datatype: int
+config_node_rpc_port=22277
+
+# used for communication between data node and data node
+# Datatype: int
+config_node_internal_port=22278
+
+# all config node address
+# every node should have the same config_node_address_lists
+# Datatype: String
+config_node_address_lists=host0,host1,host2
Review comment:
host0 do not know the `config_node_internal_port` of host1? How do they communicate with each other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org