You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2014/07/03 15:33:47 UTC

[GitHub] incubator-flink pull request: [FLINK-933] Add primitive input form...

Github user uce commented on the pull request:

    https://github.com/apache/incubator-flink/pull/47#issuecomment-47929777
  
    This is almost good to merge. Just a last note regarding the name of the read method `readPrimitiveSequence(String filePath, char delimiter, Class<X> typeClass)`.
    
    I think this should definitely have a `*File` suffix like the other file based read methods
    
    The question is now whether we should have
    1. `readIntegerFile`, `readDoubleFile`, which blows up the ExecutionEnvironment code -or-
    2. stick to something like `readPrimitiveFile`?
    
    I vote for 1.
    
    I will merge it after some further feedback regarding the name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---