[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38670: [SPARK-41157][CONNECT][PYTHON][TEST] Show detailed differences in dataframe comparison

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #38670:
URL: https://github.com/apache/spark/pull/38670#discussion_r1040504948


##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -36,11 +36,12 @@
     from pyspark.sql.connect.functions import lit
 from pyspark.sql.dataframe import DataFrame
 from pyspark.testing.connectutils import should_test_connect, connect_requirement_message
+from pyspark.testing.pandasutils import PandasOnSparkTestCase

Review Comment:
   Hi, @zhengruifeng . Unfortunately, this seems to introduce a pandas dependency accidentally.
   Previously, this file is guarded by `if have_pandas` at line 33.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org