You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/01/25 12:44:46 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8235: board: Pass the assertion expression to board_crashdump too
xiaoxiang781216 opened a new pull request, #8235:
URL: https://github.com/apache/nuttx/pull/8235
## Summary
continue the follow work:
```
commit 43e7b13697195c37166de09e508b71fe6cbb424a
Author: Xiang Xiao <xi...@xiaomi.com>
Date: Sun Jan 22 19:31:32 2023 +0800
assert: Log the assertion expression in case of fail
```
## Impact
board_crashdump
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8235: board: Pass the assertion expression to board_crashdump too
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8235:
URL: https://github.com/apache/nuttx/pull/8235#discussion_r1086937755
##########
boards/arm/cxd56xx/common/src/cxd56_crashdump.c:
##########
@@ -98,15 +98,14 @@ static void copy_reverse(stack_word_t *dest, stack_word_t *src, int size)
* Name: board_crashdump
****************************************************************************/
-void board_crashdump(uintptr_t currentsp, void *tcb,
- const char *filename, int lineno)
+void board_crashdump(uintptr_t sp, struct tcb_s *tcb,
+ const char *filename, int lineno,
+ const char *msg)
Review Comment:
Since the compiler didn't generate the warning, I prefer to remove the unnecessary but ugly UNUSED(xxx).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #8235: board: Pass the assertion expression to board_crashdump too
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #8235:
URL: https://github.com/apache/nuttx/pull/8235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8235: board: Pass the assertion expression to board_crashdump too
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #8235:
URL: https://github.com/apache/nuttx/pull/8235#discussion_r1086823510
##########
boards/arm/cxd56xx/common/src/cxd56_crashdump.c:
##########
@@ -98,15 +98,14 @@ static void copy_reverse(stack_word_t *dest, stack_word_t *src, int size)
* Name: board_crashdump
****************************************************************************/
-void board_crashdump(uintptr_t currentsp, void *tcb,
- const char *filename, int lineno)
+void board_crashdump(uintptr_t sp, struct tcb_s *tcb,
+ const char *filename, int lineno,
+ const char *msg)
Review Comment:
Do we need to add something like `UNUSED(msg);`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org