You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by hakanmemisoglu <gi...@git.apache.org> on 2016/06/17 02:38:28 UTC
[GitHub] incubator-quickstep pull request #37: QUICKSTEP-6: Decimal type
GitHub user hakanmemisoglu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/37
QUICKSTEP-6: Decimal type
This request adds the simple Decimal type. The type does not accept any precision and scale argument for now. It takes default values 18 for precision and 2 for scale.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep decimal-type
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit 5aa559310b017f03e9ef648980f47198ba2e6e9c
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-05-31T18:14:42Z
New type for fixed precision number: Decimal.
commit d71599fd124d9ddaf97150b52c7e701e4bcd121b
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-14T15:09:25Z
New changes.
commit 400d268b9d28e331707cc58094b9f0decc415d5c
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-15T18:16:18Z
Make scale fixed to 10^2.
commit 4358b6eddd63016f665f0774833ce1d0b81cbee5
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-15T21:23:24Z
Introduced comparator functors for Decimal type.
commit 6b11fe0c214fc3d3d849f0916ba67f40fb37ffdd
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-16T17:03:13Z
Fixed bug where the wrong operator is used.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #37: DO NOT MERGE: QUICKSTEP-6: Decimal type
Posted by pateljm <gi...@git.apache.org>.
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/37
@hakanmemisoglu Sorry that I haven't gotten to fixing the copyright notices (too many open PRs right now). Yyou can simply use this in the files that you have added.
```
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
* limitations under the License.
**/
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #37: DO NOT MERGE: QUICKSTEP-6: Decimal type
Posted by hakanmemisoglu <gi...@git.apache.org>.
Github user hakanmemisoglu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/37
Thanks, @pateljm.
I will update the files with new copyright.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #37: DO NOT MERGE: QUICKSTEP-6: Decimal typ...
Posted by hakanmemisoglu <gi...@git.apache.org>.
Github user hakanmemisoglu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #37: DO NOT MERGE: QUICKSTEP-6: Decimal typ...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/37#discussion_r67539412
--- Diff: types/DecimalLit.hpp ---
@@ -0,0 +1,131 @@
+/**
+ * Copyright 2016, Quickstep Research Group, Computer Sciences Department,
+ * University of Wisconsin\u2014Madison.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ **/
+
+#ifndef QUICKSTEP_TYPES_DECIMAL_LIT_HPP_
+#define QUICKSTEP_TYPES_DECIMAL_LIT_HPP_
+
+#include <cstdint>
+#include <cmath>
+
+namespace quickstep {
+
+/** \addtogroup Type
+ * @{
+ */
+
+/**
+ * @brief A literal representing fixed-precision decimal.
+ **/
+struct DecimalLit {
+ typedef std::int64_t data_type;
+
+ static DecimalLit fromDouble(double value) {
+ return DecimalLit{static_cast<data_type>(value * kMaxFractionInt)};
+ }
+
+ static DecimalLit fromInt(int64_t value) {
--- End diff --
Please mark arguments in above two constructors `const`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #37: DO NOT MERGE: QUICKSTEP-6: Decimal typ...
Posted by hakanmemisoglu <gi...@git.apache.org>.
Github user hakanmemisoglu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #37: DO NOT MERGE: QUICKSTEP-6: Decimal typ...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/37#discussion_r67539660
--- Diff: types/DecimalLit.hpp ---
@@ -0,0 +1,131 @@
+/**
+ * Copyright 2016, Quickstep Research Group, Computer Sciences Department,
+ * University of Wisconsin\u2014Madison.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ **/
+
+#ifndef QUICKSTEP_TYPES_DECIMAL_LIT_HPP_
+#define QUICKSTEP_TYPES_DECIMAL_LIT_HPP_
+
+#include <cstdint>
+#include <cmath>
+
+namespace quickstep {
+
+/** \addtogroup Type
+ * @{
+ */
+
+/**
+ * @brief A literal representing fixed-precision decimal.
+ **/
+struct DecimalLit {
+ typedef std::int64_t data_type;
+
+ static DecimalLit fromDouble(double value) {
+ return DecimalLit{static_cast<data_type>(value * kMaxFractionInt)};
+ }
+
+ static DecimalLit fromInt(int64_t value) {
+ return DecimalLit{static_cast<data_type>(value * kMaxFractionInt)};
+ }
+
+ data_type data_;
+
+ static constexpr std::int64_t kPrecisionWidth = 2;
+
+ static constexpr std::int64_t kMaxFractionInt = 100;
--- End diff --
Question: Do we have some `SQL` references for these constant values?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #37: DO NOT MERGE: QUICKSTEP-6: Decimal typ...
Posted by navsan <gi...@git.apache.org>.
Github user navsan commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/37#discussion_r69559549
--- Diff: types/DecimalLit.hpp ---
@@ -0,0 +1,293 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ * limitations under the License.
+ **/
+
+#ifndef QUICKSTEP_TYPES_DECIMAL_LIT_HPP_
+#define QUICKSTEP_TYPES_DECIMAL_LIT_HPP_
+
+#include <cstdint>
+#include <cmath>
+
+namespace quickstep {
+
+/** \addtogroup Type
+ * @{
+ */
+
+/**
+ * @brief A literal representing fixed-precision decimal.
+ **/
+struct DecimalLit {
+ /**
+ * @brief Underlying data type.
+ **/
+ typedef std::int64_t data_type;
+
+ DecimalLit() = default;
+
+ explicit DecimalLit(const int value)
+ : data_(static_cast<data_type>(value * kMaxFractionInt)) {
+ }
+
+ explicit DecimalLit(const std::int64_t value)
+ : data_(static_cast<data_type>(value * kMaxFractionInt)) {
+ }
+
+ explicit DecimalLit(const float value)
+ : data_(static_cast<data_type>(value * kMaxFractionInt)) {
+ }
+
+ explicit DecimalLit(const double value)
+ : data_(static_cast<data_type>(value * kMaxFractionInt)) {
+ }
+
+ inline explicit operator int() const {
+ return static_cast<int>(getIntegerPart());
+ }
+
+ inline explicit operator std::int64_t() const {
+ return static_cast<std::int64_t>(getIntegerPart());
+ }
+
+ inline explicit operator float() const {
+ return static_cast<float>(data_) / kMaxFractionInt;
+ }
+
+ inline explicit operator double() const {
+ return static_cast<double>(data_) / kMaxFractionInt;
+ }
+
+ data_type data_;
+
+ /**
+ * @brief Number of decimals after point.
+ **/
+ static constexpr std::int64_t kPrecisionWidth = 2;
+
+ /**
+ * @brief Normalization factor between Decimal type and floating point types.
+ * It is always equal to pow(10, kPrecisionWidth).
+ **/
+ static constexpr std::int64_t kMaxFractionInt = 100;
+
+ /**
+ * @brief Getter for the fractional part of the Decimal type.
+ *
+ * @return Fractional part of the Decimal number as unsigned.
+ **/
+ inline std::uint64_t getFractionalPart() const {
+ return static_cast<std::uint64_t>(static_cast<std::uint64_t>(std::abs(data_)) % kMaxFractionInt);
+ }
+
+ /**
+ * @brief Getter for the integer part of the Decimal type.
+ *
+ * @return Integer part of the Decimal number as signed.
+ **/
+ inline std::int64_t getIntegerPart() const {
+ return static_cast<std::int64_t>(data_ / kMaxFractionInt);
+ }
+
+ /**
+ * @brief Operator overloading for "less than".
+ *
+ * @param other Other DecimalLit to be compared.
+ * @return True if this is less than other,
+ * false otherwise.
+ **/
+ inline bool operator<(const DecimalLit& other) const {
+ return data_ < other.data_;
+ }
+
+ /**
+ * @brief Operator overloading for "greater than".
+ *
+ * @param other Other DecimalLit to be compared.
+ * @return True if this is greater than other,
+ * false otherwise.
+ **/
+ inline bool operator>(const DecimalLit& other) const {
+ return data_ > other.data_;
+ }
+
+ /**
+ * @brief Operator overloading for "less than or equal to".
+ *
+ * @param other Other DecimalLit to be compared.
+ * @return True if this is less than or equal to other,
+ * false otherwise.
+ **/
+ inline bool operator<=(const DecimalLit& other) const {
+ return data_ <= other.data_;
+ }
+
+ /**
+ * @brief Operator overloading for "greater than or equal to".
+ *
+ * @param other Other DecimalLit to be compared.
+ * @return True if this is greater than or equal to other,
+ * false otherwise.
+ **/
+ inline bool operator>=(const DecimalLit& other) const {
+ return data_ >= other.data_;
+ }
+
+ /**
+ * @brief Operator overloading for "equal to".
+ *
+ * @param other Other DecimalLit to be compared.
+ * @return True if this is equal to other,
+ * false otherwise.
+ **/
+ inline bool operator==(const DecimalLit& other) const {
+ return data_ == other.data_;
+ }
+
+ /**
+ * @brief Operator overloading for "not equal to".
+ *
+ * @param other Other DecimalLit to be compared.
+ * @return True if this is not equal to other,
+ * false otherwise.
+ **/
+ inline bool operator!=(const DecimalLit& other) const {
+ return data_ != other.data_;
+ }
+
+ /**
+ * @brief Operator overloading for "negate".
+ *
+ * @return Negative of this.
+ **/
+ inline DecimalLit operator-() const {
+ DecimalLit result;
+ result.data_ = -result.data_;
+ return result;
+ }
+
+ /**
+ * @brief Operator overloading for "plus".
+ *
+ * @param other Other DecimalLit to be added.
+ * @return Sum of this and other.
+ **/
+ inline DecimalLit operator+(const DecimalLit& other) const {
+ DecimalLit result;
+ result.data_ = data_ + other.data_;
+ return result;
+ }
+
+ /**
+ * @brief Operator overloading for "subtract".
+ *
+ * @param other Other DecimalLit to be subtract.
+ * @return Subtraction of other from this.
+ **/
+ inline DecimalLit operator-(const DecimalLit& other) const {
+ DecimalLit result;
+ result.data_ = data_ - other.data_;
+ return result;
+ }
+
+ /**
+ * @brief Operator overloading for "multiply".
+ *
+ * @param other Other DecimalLit to be multiplied.
+ * @return Multiplication of this and other.
+ **/
+ inline DecimalLit operator*(const DecimalLit& other) const {
+ DecimalLit result;
+ result.data_ = (data_ * other.data_) / kMaxFractionInt;
+ return result;
+ }
+
+ /**
+ * @brief Operator overloading for "division".
+ *
+ * @param other Divisor DecimalLit.
+ * @return Division of this with other.
+ **/
+ inline DecimalLit operator/(const DecimalLit& other) const {
+ DecimalLit result;
+ result.data_ = (data_ * kMaxFractionInt) / other.data_;
+ return result;
+ }
+
+ /**
+ * @brief Operator overloading for "modulo".
+ *
+ * @param other Mod DecimalLit.
+ * @return This modulo other.
+ **/
+ inline DecimalLit operator%(const DecimalLit& other) const {
+ DecimalLit result;
+ result.data_ = data_ % other.data_;
--- End diff --
This doesn't look right to me (I might be mistaken). For a Decimal like 10.59, I don't think % should be defined at all. The semantics of this operation (as defined) aren't clear to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #37: DO NOT MERGE: QUICKSTEP-6: Decimal typ...
Posted by hakanmemisoglu <gi...@git.apache.org>.
GitHub user hakanmemisoglu reopened a pull request:
https://github.com/apache/incubator-quickstep/pull/37
DO NOT MERGE: QUICKSTEP-6: Decimal type
- This request adds the simple Decimal type which represents fixed precision numbers.
- In practice, Decimal type is used with 2 arguments: precision and scale.
- Precision is the number of digits (base 10) that the type can show.
- Scale is the number of digits (base 10) after point.
- For example, Decimal(6, 2) can represent numbers from -9999.99 to +9999.99.
- The type does not accept any precision and scale argument for now. It takes default values 18 for precision and 2 for scale. It is chosen since precision 18 is the limit that 64 bits can represent safely, and scale 2 is what TPCH requires.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep decimal-type
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit 5aa559310b017f03e9ef648980f47198ba2e6e9c
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-05-31T18:14:42Z
New type for fixed precision number: Decimal.
commit d71599fd124d9ddaf97150b52c7e701e4bcd121b
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-14T15:09:25Z
New changes.
commit 400d268b9d28e331707cc58094b9f0decc415d5c
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-15T18:16:18Z
Make scale fixed to 10^2.
commit 4358b6eddd63016f665f0774833ce1d0b81cbee5
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-15T21:23:24Z
Introduced comparator functors for Decimal type.
commit 6b11fe0c214fc3d3d849f0916ba67f40fb37ffdd
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-16T17:03:13Z
Fixed bug where the wrong operator is used.
commit 5646d0320170806cd1f9f515b7793ee91fdfde33
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-17T14:00:17Z
Added dependency in CMakeLists.txt.
commit 18f526050a7109445ce289921399db179c122bec
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-17T18:21:56Z
Additional changes to fix compile errors and documentation is added.
commit 5815103db00e978c156881d1f139244a28fa932d
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-17T21:06:23Z
First part of the unit test.
commit f28c46ecc9450ac01989df0082a8d74a24724b66
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-20T16:35:01Z
Adding numeric cast for Decimal type.
commit 169c1f37cfeb1d46d86af1f85cbc703215d22521
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-20T16:45:58Z
Include DecimalType in NumericCastOperation.
commit 76673f5a1ecd79c54b42805d66c60fe81dc6709f
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-20T16:54:39Z
Added static cast for int.
commit 7e668513fa9e064536d7f562eee3403597b63c7d
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-20T17:18:47Z
Added static cast.
commit 85b0694b0a3479add75ae5a0d4e379dbd35d4621
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-20T18:53:00Z
DecimalLit conversions.
commit 8bb4c61ef0e9a9ca44dd29cb6566ce160d4bbe54
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-20T18:58:39Z
DecimalLit constructors.
commit 88306cbdb9af99221fd6036f7307b96515abed39
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-20T19:03:11Z
default constructor for DecimalLit.
commit ec37551d835781046c2ce24c06eaf1a86fb84816
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-20T19:08:25Z
DecimalLit constructors.
commit 85dab23c79aa787f72dc98b75d729495180b937b
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-20T19:20:44Z
Fix for cast issue.
commit 889c4805e661939a4881a1c096e2a70a494c1212
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-20T19:37:22Z
Fix in vector copy elision.
commit 0acaf423a9fdfaf1d140252f55d824cc7457db65
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-20T21:24:48Z
New fixes.
commit aebb4a3bd2d1bd98c77e7a3db03888db0d931ffb
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-20T21:52:27Z
Operators are updated.
commit cf33c724a0b16168fd4f104bf166bc19abafbe46
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-21T20:14:30Z
Changed proto decsription.
commit 2d17109453c64b96d38fcfc8af77bfc1b44a7582
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-23T17:44:51Z
The changes to prevent errors from linter.
commit 0a3e43f2941f73e5654347fd5b70d87b0a9df6e4
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-23T18:31:09Z
Updated preprocessed lexer and parser files.
commit 21e912c931aa110d3289b7a40e8d8a4ea6499751
Author: Hakan Memisoglu <ha...@apache.org>
Date: 2016-06-23T19:51:51Z
Use constructor instead of builder in unit test.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #37: DO NOT MERGE: QUICKSTEP-6: Decimal typ...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/37#discussion_r67539248
--- Diff: types/CMakeLists.txt ---
@@ -94,6 +96,16 @@ target_link_libraries(quickstep_types_DatetimeType
quickstep_types_port_timegm
quickstep_utility_CheckSnprintf
quickstep_utility_Macros)
+target_link_libraries(quickstep_types_DecimalType
+ glog
+ quickstep_types_DecimalLit
+ quickstep_types_NullCoercibilityCheckMacro
+ quickstep_types_NumericSuperType
+ quickstep_types_Type
+ quickstep_types_TypeID
+ quickstep_types_TypedValue
+ quickstep_utility_Macros
+ quickstep_utility_EqualsAnyConstant)
--- End diff --
Please sort in the alphabet order.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---