You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@santuario.apache.org by "coheigea (via GitHub)" <gi...@apache.org> on 2023/05/17 03:54:27 UTC
[GitHub] [santuario-xml-security-java] coheigea opened a new pull request, #169: Propagate failures from the NodeFilter via a checked exception
coheigea opened a new pull request, #169:
URL: https://github.com/apache/santuario-xml-security-java/pull/169
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [santuario-xml-security-java] seanjmullan commented on a diff in pull request #169: Propagate failures from the NodeFilter via a checked exception
Posted by "seanjmullan (via GitHub)" <gi...@apache.org>.
seanjmullan commented on code in PR #169:
URL: https://github.com/apache/santuario-xml-security-java/pull/169#discussion_r1196925278
##########
src/test/java/org/apache/xml/security/test/dom/interop/BaltimoreTest.java:
##########
@@ -277,37 +277,6 @@ public void test_fifteen_external_dsa() throws Exception {
assertTrue(verify, filename);
}
- /**
Review Comment:
I think it can be useful to modify and keep this as a negative test, that is make sure it throws an exception when Xalan is not available to process the here() function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [santuario-xml-security-java] coheigea commented on a diff in pull request #169: Propagate failures from the NodeFilter via a checked exception
Posted by "coheigea (via GitHub)" <gi...@apache.org>.
coheigea commented on code in PR #169:
URL: https://github.com/apache/santuario-xml-security-java/pull/169#discussion_r1197614473
##########
src/test/java/org/apache/xml/security/test/dom/interop/BaltimoreTest.java:
##########
@@ -277,37 +277,6 @@ public void test_fifteen_external_dsa() throws Exception {
assertTrue(verify, filename);
}
- /**
Review Comment:
Yep fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [santuario-xml-security-java] seanjmullan commented on a diff in pull request #169: Propagate failures from the NodeFilter via a checked exception
Posted by "seanjmullan (via GitHub)" <gi...@apache.org>.
seanjmullan commented on code in PR #169:
URL: https://github.com/apache/santuario-xml-security-java/pull/169#discussion_r1196925278
##########
src/test/java/org/apache/xml/security/test/dom/interop/BaltimoreTest.java:
##########
@@ -277,37 +277,6 @@ public void test_fifteen_external_dsa() throws Exception {
assertTrue(verify, filename);
}
- /**
Review Comment:
I think it can be useful to modify and keep this as a negative test, that is make sure it throws an exception when Xalan is not available to process the here() function, unless there is some other test that already tests that scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [santuario-xml-security-java] coheigea merged pull request #169: Propagate failures from the NodeFilter via a checked exception
Posted by "coheigea (via GitHub)" <gi...@apache.org>.
coheigea merged PR #169:
URL: https://github.com/apache/santuario-xml-security-java/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org