You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/12/17 01:43:24 UTC
[GitHub] [hudi] nsivabalan opened a new pull request, #7491: [HUDI-5408][WIP] Fixing the way we rollback already completed commit in MDT, but failed in DT and re-attempted
nsivabalan opened a new pull request, #7491:
URL: https://github.com/apache/hudi/pull/7491
### Change Logs
when compaction failed after completing in MDT but before completing in DT. and later when we re-attempt to apply the same compaction instant to MDT, we might miss to rollback any partially failed commit in MDT.
We need to ensure anytime we try to apply a commit to MDT, we rollback partially failed commit.
While working on the fix, realized that we are manually deleting the completed instant and proceed further. Its better if we trigger an actual rollback in MDT to keep it clean and avoid such manual interventions as maintaining such code might become tough in the long run.
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #7491: [HUDI-5408][WIP] Fixing the way we rollback already completed commit in MDT, but failed in DT and re-attempted
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #7491:
URL: https://github.com/apache/hudi/pull/7491#issuecomment-1372737383
closing in favor of https://github.com/apache/hudi/pull/7553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan closed pull request #7491: [HUDI-5408][WIP] Fixing the way we rollback already completed commit in MDT, but failed in DT and re-attempted
Posted by GitBox <gi...@apache.org>.
nsivabalan closed pull request #7491: [HUDI-5408][WIP] Fixing the way we rollback already completed commit in MDT, but failed in DT and re-attempted
URL: https://github.com/apache/hudi/pull/7491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org