You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/10/13 19:35:51 UTC

svn commit: r1843777 - /pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/ExtractImages.java

Author: tilman
Date: Sat Oct 13 19:35:51 2018
New Revision: 1843777

URL: http://svn.apache.org/viewvc?rev=1843777&view=rev
Log:
PDFBOX-4071: use foreach loop (also speeds up when many pages)

Modified:
    pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/ExtractImages.java

Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/ExtractImages.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/ExtractImages.java?rev=1843777&r1=1843776&r2=1843777&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/ExtractImages.java (original)
+++ pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/ExtractImages.java Sat Oct 13 19:35:51 2018
@@ -174,9 +174,8 @@ public final class ExtractImages
                 throw new IOException("You do not have permission to extract images");
             }
 
-            for (int i = 0; i < document.getNumberOfPages(); i++) // todo: ITERATOR would be much better
+            for (PDPage page : document.getPages())
             {
-                PDPage page = document.getPage(i);
                 ImageGraphicsEngine extractor = new ImageGraphicsEngine(page);
                 extractor.run();
             }