You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Noel Grandin (Created) (JIRA)" <ji...@apache.org> on 2012/03/23 10:33:26 UTC

[jira] [Created] (PIVOT-846) rework methods for modifying user-level child components of Container subclasses

rework methods for modifying user-level child components of Container subclasses
--------------------------------------------------------------------------------

                 Key: PIVOT-846
                 URL: https://issues.apache.org/jira/browse/PIVOT-846
             Project: Pivot
          Issue Type: Improvement
          Components: wtk
    Affects Versions: 2.1
            Reporter: Noel Grandin
            Assignee: Noel Grandin
            Priority: Minor


For most sub-classes of Container, directly adding/removing child components is not something the user usually wants to do.

This gets especially confusing when users do things like adding a child component to a ScrollPane.

Also, the skin classes add extra components to the Container, potentially making it even more confusing.

I plan to move access to a new method on Container#getChildComponentList(), which will be clearly marked as being of mostly internal interest.

Then I will add convenience methods to the subclasses of Container where it makes sense to treat the subclass as directly containing user-level child components, eg. BoxPane, CardPane, FlowPane, StackPane

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIVOT-846) rework methods for modifying user-level child components of Container subclasses

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandro Martini updated PIVOT-846:
---------------------------------

    Comment: was deleted

(was: Hi

No, I haven't worked on that yet.

Regards, Noel.

)
    
> rework methods for modifying user-level child components of Container subclasses
> --------------------------------------------------------------------------------
>
>                 Key: PIVOT-846
>                 URL: https://issues.apache.org/jira/browse/PIVOT-846
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Noel Grandin
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.1, 2.0.3
>
>
> For most sub-classes of Container, directly adding/removing child components is not something the user usually wants to do.
> This gets especially confusing when users do things like adding a child component to a ScrollPane.
> Also, the skin classes add extra components to the Container, potentially making it even more confusing.
> I plan to move access to a new method on Container#getChildComponentList(), which will be clearly marked as being of mostly internal interest.
> Then I will add convenience methods to the subclasses of Container where it makes sense to treat the subclass as directly containing user-level child components, eg. BoxPane, CardPane, FlowPane, StackPane

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIVOT-846) rework methods for modifying user-level child components of Container subclasses

Posted by "Sandro Martini (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236516#comment-13236516 ] 

Sandro Martini commented on PIVOT-846:
--------------------------------------

Noel, you think could be useful to add new methods in 2.0.2 (and deprecate/mark for internal use others) or is it safer to wait for all changes in 2.1 ?

And a side idea (maybe to go in a dedicated issue): 
add an annotation to mark internal use only methods (useful when usual Java scopes aren't enough) ?

                
> rework methods for modifying user-level child components of Container subclasses
> --------------------------------------------------------------------------------
>
>                 Key: PIVOT-846
>                 URL: https://issues.apache.org/jira/browse/PIVOT-846
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>    Affects Versions: 2.1
>            Reporter: Noel Grandin
>            Assignee: Noel Grandin
>            Priority: Minor
>
> For most sub-classes of Container, directly adding/removing child components is not something the user usually wants to do.
> This gets especially confusing when users do things like adding a child component to a ScrollPane.
> Also, the skin classes add extra components to the Container, potentially making it even more confusing.
> I plan to move access to a new method on Container#getChildComponentList(), which will be clearly marked as being of mostly internal interest.
> Then I will add convenience methods to the subclasses of Container where it makes sense to treat the subclass as directly containing user-level child components, eg. BoxPane, CardPane, FlowPane, StackPane

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIVOT-846) rework methods for modifying user-level child components of Container subclasses

Posted by "Noel Grandin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266490#comment-13266490 ] 

Noel Grandin commented on PIVOT-846:
------------------------------------

Hi

No, I haven't worked on that yet.

Regards, Noel.


                
> rework methods for modifying user-level child components of Container subclasses
> --------------------------------------------------------------------------------
>
>                 Key: PIVOT-846
>                 URL: https://issues.apache.org/jira/browse/PIVOT-846
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Noel Grandin
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.0.2, 2.1
>
>
> For most sub-classes of Container, directly adding/removing child components is not something the user usually wants to do.
> This gets especially confusing when users do things like adding a child component to a ScrollPane.
> Also, the skin classes add extra components to the Container, potentially making it even more confusing.
> I plan to move access to a new method on Container#getChildComponentList(), which will be clearly marked as being of mostly internal interest.
> Then I will add convenience methods to the subclasses of Container where it makes sense to treat the subclass as directly containing user-level child components, eg. BoxPane, CardPane, FlowPane, StackPane

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIVOT-846) rework methods for modifying user-level child components of Container subclasses

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266489#comment-13266489 ] 

Sandro Martini commented on PIVOT-846:
--------------------------------------

Noel, I remember to see a commit on this some week ago (if I remember well :-) ) ... so is it resolved ?

Thanks.

                
> rework methods for modifying user-level child components of Container subclasses
> --------------------------------------------------------------------------------
>
>                 Key: PIVOT-846
>                 URL: https://issues.apache.org/jira/browse/PIVOT-846
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Noel Grandin
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.0.2, 2.1
>
>
> For most sub-classes of Container, directly adding/removing child components is not something the user usually wants to do.
> This gets especially confusing when users do things like adding a child component to a ScrollPane.
> Also, the skin classes add extra components to the Container, potentially making it even more confusing.
> I plan to move access to a new method on Container#getChildComponentList(), which will be clearly marked as being of mostly internal interest.
> Then I will add convenience methods to the subclasses of Container where it makes sense to treat the subclass as directly containing user-level child components, eg. BoxPane, CardPane, FlowPane, StackPane

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIVOT-846) rework methods for modifying user-level child components of Container subclasses

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandro Martini updated PIVOT-846:
---------------------------------

    Comment: was deleted

(was: Noel, I remember to see a commit on this some week ago (if I remember well :-) ) ... so is it resolved ?

Thanks.
)
    
> rework methods for modifying user-level child components of Container subclasses
> --------------------------------------------------------------------------------
>
>                 Key: PIVOT-846
>                 URL: https://issues.apache.org/jira/browse/PIVOT-846
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Noel Grandin
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.1, 2.0.3
>
>
> For most sub-classes of Container, directly adding/removing child components is not something the user usually wants to do.
> This gets especially confusing when users do things like adding a child component to a ScrollPane.
> Also, the skin classes add extra components to the Container, potentially making it even more confusing.
> I plan to move access to a new method on Container#getChildComponentList(), which will be clearly marked as being of mostly internal interest.
> Then I will add convenience methods to the subclasses of Container where it makes sense to treat the subclass as directly containing user-level child components, eg. BoxPane, CardPane, FlowPane, StackPane

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIVOT-846) rework methods for modifying user-level child components of Container subclasses

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandro Martini updated PIVOT-846:
---------------------------------

    Fix Version/s:     (was: 2.0.2)
                   2.0.3
    
> rework methods for modifying user-level child components of Container subclasses
> --------------------------------------------------------------------------------
>
>                 Key: PIVOT-846
>                 URL: https://issues.apache.org/jira/browse/PIVOT-846
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Noel Grandin
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.1, 2.0.3
>
>
> For most sub-classes of Container, directly adding/removing child components is not something the user usually wants to do.
> This gets especially confusing when users do things like adding a child component to a ScrollPane.
> Also, the skin classes add extra components to the Container, potentially making it even more confusing.
> I plan to move access to a new method on Container#getChildComponentList(), which will be clearly marked as being of mostly internal interest.
> Then I will add convenience methods to the subclasses of Container where it makes sense to treat the subclass as directly containing user-level child components, eg. BoxPane, CardPane, FlowPane, StackPane

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIVOT-846) rework methods for modifying user-level child components of Container subclasses

Posted by "Sandro Martini (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandro Martini updated PIVOT-846:
---------------------------------

    Affects Version/s:     (was: 2.1)
        Fix Version/s: 2.1
                       2.0.2
    
> rework methods for modifying user-level child components of Container subclasses
> --------------------------------------------------------------------------------
>
>                 Key: PIVOT-846
>                 URL: https://issues.apache.org/jira/browse/PIVOT-846
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Noel Grandin
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.0.2, 2.1
>
>
> For most sub-classes of Container, directly adding/removing child components is not something the user usually wants to do.
> This gets especially confusing when users do things like adding a child component to a ScrollPane.
> Also, the skin classes add extra components to the Container, potentially making it even more confusing.
> I plan to move access to a new method on Container#getChildComponentList(), which will be clearly marked as being of mostly internal interest.
> Then I will add convenience methods to the subclasses of Container where it makes sense to treat the subclass as directly containing user-level child components, eg. BoxPane, CardPane, FlowPane, StackPane

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIVOT-846) rework methods for modifying user-level child components of Container subclasses

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandro Martini updated PIVOT-846:
---------------------------------

    Fix Version/s:     (was: 2.0.3)
                   2.0.4
    
> rework methods for modifying user-level child components of Container subclasses
> --------------------------------------------------------------------------------
>
>                 Key: PIVOT-846
>                 URL: https://issues.apache.org/jira/browse/PIVOT-846
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Noel Grandin
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.1, 2.0.4
>
>
> For most sub-classes of Container, directly adding/removing child components is not something the user usually wants to do.
> This gets especially confusing when users do things like adding a child component to a ScrollPane.
> Also, the skin classes add extra components to the Container, potentially making it even more confusing.
> I plan to move access to a new method on Container#getChildComponentList(), which will be clearly marked as being of mostly internal interest.
> Then I will add convenience methods to the subclasses of Container where it makes sense to treat the subclass as directly containing user-level child components, eg. BoxPane, CardPane, FlowPane, StackPane

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira