You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/14 05:49:37 UTC

[GitHub] [shardingsphere] dongzl opened a new pull request #10084: fixes PostgreSQL SQLXML data type packet exception.

dongzl opened a new pull request #10084:
URL: https://github.com/apache/shardingsphere/pull/10084


   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on a change in pull request #10084: fixes PostgreSQL SQLXML data type packet exception.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #10084:
URL: https://github.com/apache/shardingsphere/pull/10084#discussion_r612975110



##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-postgresql/src/main/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/text/PostgreSQLDataRowPacket.java
##########
@@ -64,7 +65,7 @@ private void writeSQLXMLData(final PostgreSQLPacketPayload payload, final Object
             payload.writeInt4(((SQLXML) data).getString().getBytes().length);

Review comment:
       Please remove useless @slf4j too




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu merged pull request #10084: fixes PostgreSQL SQLXML data type packet exception.

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #10084:
URL: https://github.com/apache/shardingsphere/pull/10084


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org