You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/05/24 02:24:21 UTC
[GitHub] [spark] panbingkun opened a new pull request, #41289: [SPARK-43767][SQL][TESTS] Fix bug in AvroSuite for 'reading from invalid path throws exception'
panbingkun opened a new pull request, #41289:
URL: https://github.com/apache/spark/pull/41289
### What changes were proposed in this pull request?
The pr aims to fix bug in AvroSuite for 'reading from invalid path throws exception'.
### Why are the changes needed?
- As discussed and analyzed in [41271](https://github.com/apache/spark/pull/41271#issuecomment-1560355918)
- There is a problem with this UT. Its original intention was to test if there is no file with .avro extensions in the directory, and the read should fail. However, this UT triggered the error as FileUtils.touch instead of spark.read.format("avro").load(dir.toString).The root cause for the failure of this case is that the parent directory was not created. When FileUtils.touch is called in version 1.11.0, it just throws java.io.FileNotFoundException, which covers the error.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41289: [SPARK-43767][SQL][TESTS] Fix bug in AvroSuite for 'reading from invalid path throws exception'
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41289:
URL: https://github.com/apache/spark/pull/41289#issuecomment-1560399798
> withTempDir
Yep, Perhaps using `withTempDir` code here is more concise,
Let me do it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41289: [SPARK-43767][SQL][TESTS] Fix bug in AvroSuite for 'reading from invalid path throws exception'
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41289:
URL: https://github.com/apache/spark/pull/41289#issuecomment-1560369407
cc @dongjoon-hyun @HyukjinKwon @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #41289: [SPARK-43767][SQL][TESTS] Fix bug in AvroSuite for 'reading from invalid path throws exception'
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #41289: [SPARK-43767][SQL][TESTS] Fix bug in AvroSuite for 'reading from invalid path throws exception'
URL: https://github.com/apache/spark/pull/41289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org