Re: [PR] CASSANDRA-21138: Add upgrade test for AutoRepair [cassandra]

["jaydeepkumar1984 (via GitHub)" <gi...@apache.org>]

jaydeepkumar1984 commented on PR #4644:
URL: https://github.com/apache/cassandra/pull/4644#issuecomment-4173750118

   > > There is no need for the migration because AutoRepair will automatically [purge](https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/autorepair/AutoRepairUtils.java#L826) the stale hostId entries.
   > 
   > Even though the old entries are purged the issue is that work will be lost if you upgrade mid-repair since repair will be started again from scratch, so migrating the entries will ensure that repair state is resumed properly after the upgrade.
   > 
   > I added repair history and priority migration on [791e64d](https://github.com/apache/cassandra/commit/791e64d4d55f0142f545113bf19317b9c7464a2d), this allows repair history and priorities to be resumed after upgrade, so with that we don't need a special NEWS.txt entry.
   > 
   > I also updated the tests to check that the entries are migrated properly and that repair executes successfully after upgrade, and the priority table is migrated as well.
   > 
   > Let me know what you think @jaydeepkumar1984 @tolbertam
   
   Overall, the approach looks good to me. Wdyt @tolbertam ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org