[GitHub] [tvm] wrongtest-intellif commented on a diff in pull request #14596: [ARITH][TensorIR] Improve CompactBufferRegion for symbolic shape

["wrongtest-intellif (via GitHub)" <gi...@apache.org>]

wrongtest-intellif commented on code in PR #14596:
URL: https://github.com/apache/tvm/pull/14596#discussion_r1163526009


##########
src/tir/transforms/compact_buffer_region.cc:
##########
@@ -203,6 +211,10 @@ class BufferAccessRegionCollector : public StmtExprVisitor {
   }
 
   void VisitStmt_(const BlockNode* op) final {
+    // make sure the analyzer is aware of loop bound info.

Review Comment:
   The buffer compaction is only allowed to work on opaque block without block iters, so we could add sanity check than make bindings? 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org