[GitHub] [pulsar] Jason918 commented on a diff in pull request #17722: support setting bundle number for default namespace when set up cluster

[GitBox <gi...@apache.org>]

Jason918 commented on code in PR #17722:
URL: https://github.com/apache/pulsar/pull/17722#discussion_r979672440


##########
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java:
##########
@@ -63,10 +65,17 @@
  */
 public class PulsarClusterMetadataSetup {
 
+    private static final int DEFAULT_BUNDLE_NUMBER = 16;
+
     private static class Arguments {
         @Parameter(names = { "-c", "--cluster" }, description = "Cluster name", required = true)
         private String cluster;
 
+        @Parameter(names = {"-bc", "--broker-conf"},
+                description = "Configuration file for Broker to get the default bundle numbers "

Review Comment:
   Seems a bit confusing if we only use "DefaultNumberOfNamespaceBundles" from this config file. Most of other parameters in this `Arguments` appears in the config file too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org