[GitHub] [beam] cushon commented on pull request #17317: [BEAM-14117] Unvendor bytebuddy dependency

[GitBox <gi...@apache.org>]

cushon commented on PR #17317:
URL: https://github.com/apache/beam/pull/17317#issuecomment-1183520006

   > Now I just want to poke the tests until they are green, rather than ignoring red signals, even if they seem irrelevant.
   
   Definitely, thanks. The tests were all passing earlier, and I was hoping there was an unrelated breakage at head.
   
   But looking more closely, it's related to the change to stop bundling bytebuddy. With that applied, I get:
   
   ```
   $ ./gradlew -p sdks/java/harness/ test
   ...
   > Task :sdks:java:harness:jmh:test
   
   org.apache.beam.fn.harness.jmh.ProcessBundleBenchmarkTest > testStateWithoutCaching FAILED
       java.util.concurrent.ExecutionException at ProcessBundleBenchmarkTest.java:46
           Caused by: org.apache.beam.vendor.grpc.v1p43p2.io.grpc.StatusRuntimeException at Status.java:526
   ```
   
   And looking at the stderr for the failing test:
   
   ```
   Exception in thread "pool-3-thread-4" java.lang.NoClassDefFoundError: net/bytebuddy/NamingStrategy
   	at org.apache.beam.sdk.transforms.reflect.DoFnInvokers.invokerFor(DoFnInvokers.java:38)
   	at org.apache.beam.sdk.transforms.reflect.DoFnInvokers.tryInvokeSetupFor(DoFnInvokers.java:51)
   	at org.apache.beam.fn.harness.FnApiDoFnRunner.<init>(FnApiDoFnRunner.java:492)
   	at org.apache.beam.fn.harness.FnApiDoFnRunner$Factory.createRunnerForPTransform(FnApiDoFnRunner.java:193)
   	at org.apache.beam.fn.harness.FnApiDoFnRunner$Factory.createRunnerForPTransform(FnApiDoFnRunner.java:162)
   	at org.apache.beam.fn.harness.control.ProcessBundleHandler.createRunnerAndConsumersForPTransformRecursively(ProcessBundleHandler.java:298)
   	at org.apache.beam.fn.harness.control.ProcessBundleHandler.createRunnerAndConsumersForPTransformRecursively(ProcessBundleHandler.java:252)
   	at org.apache.beam.fn.harness.control.ProcessBundleHandler.createBundleProcessor(ProcessBundleHandler.java:825)
   	at org.apache.beam.fn.harness.control.ProcessBundleHandler.lambda$processBundle$0(ProcessBundleHandler.java:502)
   	at org.apache.beam.fn.harness.control.ProcessBundleHandler$BundleProcessorCache.get(ProcessBundleHandler.java:936)
   	at org.apache.beam.fn.harness.control.ProcessBundleHandler.processBundle(ProcessBundleHandler.java:498)
   	at org.apache.beam.fn.harness.control.BeamFnControlClient.delegateOnInstructionRequestType(BeamFnControlClient.java:151)
   	at org.apache.beam.fn.harness.control.BeamFnControlClient$InboundObserver.lambda$onNext$0(BeamFnControlClient.java:116)
   	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
   	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
   	at java.base/java.lang.Thread.run(Thread.java:830)
   Caused by: java.lang.ClassNotFoundException: net.bytebuddy.NamingStrategy
   	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
   	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:182)
   	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:523)
   	... 16 more
   ```
   
   Any idea why the regular non-shadow dependency isn't getting resolved correctly there?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org