You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/10 10:02:50 UTC

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1008: fix(husky): pass the web folder

juzhiyuan opened a new pull request #1008:
URL: https://github.com/apache/apisix-dashboard/pull/1008


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   resolve #803 
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   https://typicode.github.io/husky/#/?id=custom-directory
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1008: fix(husky): pass the web folder

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1008:
URL: https://github.com/apache/apisix-dashboard/pull/1008


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io commented on pull request #1008: fix(husky): pass the web folder

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1008:
URL: https://github.com/apache/apisix-dashboard/pull/1008#issuecomment-742421200


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=h1) Report
   > Merging [#1008](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=desc) (d5a2929) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e1a3132687aac27b2050d2c29e59a365ad3c65fd?el=desc) (e1a3132) will **increase** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1008/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1008      +/-   ##
   ==========================================
   + Coverage   43.96%   44.01%   +0.04%     
   ==========================================
     Files          18       18              
     Lines        1310     1311       +1     
   ==========================================
   + Hits          576      577       +1     
     Misses        643      643              
     Partials       91       91              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1008/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `61.29% <0.00%> (-0.40%)` | :arrow_down: |
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1008/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=footer). Last update [e1a3132...3c30adf](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1008: fix(husky): pass the web folder

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1008:
URL: https://github.com/apache/apisix-dashboard/pull/1008#issuecomment-742421200


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=h1) Report
   > Merging [#1008](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=desc) (de3b50f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/29e6dd51b3b1d40ebcc61cc37275e5a7fda09b31?el=desc) (29e6dd5) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1008/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1008   +/-   ##
   =======================================
     Coverage   41.80%   41.80%           
   =======================================
     Files          23       23           
     Lines        1428     1428           
   =======================================
     Hits          597      597           
     Misses        740      740           
     Partials       91       91           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=footer). Last update [29e6dd5...de3b50f](https://codecov.io/gh/apache/apisix-dashboard/pull/1008?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org