You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/06/22 15:35:48 UTC

[GitHub] [arrow] pitrou commented on pull request #36183: GH-20505: [C++] Optimize DELTA_BINARY_PACKED encoding

pitrou commented on PR #36183:
URL: https://github.com/apache/arrow/pull/36183#issuecomment-1602857918

   While the `min_delta_` might be useful, I don't believe that keeping track of a separate `max_deltas_` array is actually efficient.
   
   Besides, your PR is buggy and doesn't pass the unit tests (see the ongoing CI results).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org