You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2019/12/02 05:30:56 UTC

[kudu-CR] tool: support for changing column comment 

helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14814


Change subject: tool: support for changing column comment
......................................................................

tool: support for changing column comment

Change-Id: I8bfc7f5b1c4f89d01d2f5145b648d15d90f95dfb
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
2 files changed, 40 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/14814/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bfc7f5b1c4f89d01d2f5145b648d15d90f95dfb
Gerrit-Change-Number: 14814
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>

[kudu-CR] tools: support for changing column comment

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14814 )

Change subject: tools: support for changing column comment
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bfc7f5b1c4f89d01d2f5145b648d15d90f95dfb
Gerrit-Change-Number: 14814
Gerrit-PatchSet: 3
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Mon, 02 Dec 2019 18:16:36 +0000
Gerrit-HasComments: No

[kudu-CR] tools: support for changing column comment

Posted by "helifu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14814

to look at the new patch set (#2).

Change subject: tools: support for changing column comment
......................................................................

tools: support for changing column comment

Change-Id: I8bfc7f5b1c4f89d01d2f5145b648d15d90f95dfb
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
2 files changed, 40 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/14814/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8bfc7f5b1c4f89d01d2f5145b648d15d90f95dfb
Gerrit-Change-Number: 14814
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] tools: support for changing column comment

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14814 )

Change subject: tools: support for changing column comment
......................................................................

tools: support for changing column comment

Change-Id: I8bfc7f5b1c4f89d01d2f5145b648d15d90f95dfb
Reviewed-on: http://gerrit.cloudera.org:8080/14814
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
2 files changed, 58 insertions(+), 6 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8bfc7f5b1c4f89d01d2f5145b648d15d90f95dfb
Gerrit-Change-Number: 14814
Gerrit-PatchSet: 4
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>

[kudu-CR] tools: support for changing column comment

Posted by "helifu (Code Review)" <ge...@cloudera.org>.
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14814 )

Change subject: tools: support for changing column comment
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14814/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/14814/2/src/kudu/tools/kudu-tool-test.cc@1113
PS2, Line 1113:     const vector<string> kTableModeRegexes = {
> Update this.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/14814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bfc7f5b1c4f89d01d2f5145b648d15d90f95dfb
Gerrit-Change-Number: 14814
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Mon, 02 Dec 2019 06:33:36 +0000
Gerrit-HasComments: Yes

[kudu-CR] tools: support for changing column comment

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14814 )

Change subject: tools: support for changing column comment
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14814/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/14814/2/src/kudu/tools/kudu-tool-test.cc@1113
PS2, Line 1113:     const vector<string> kTableModeRegexes = {
Update this.



-- 
To view, visit http://gerrit.cloudera.org:8080/14814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bfc7f5b1c4f89d01d2f5145b648d15d90f95dfb
Gerrit-Change-Number: 14814
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 02 Dec 2019 06:00:54 +0000
Gerrit-HasComments: Yes

[kudu-CR] tools: support for changing column comment

Posted by "helifu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14814

to look at the new patch set (#3).

Change subject: tools: support for changing column comment
......................................................................

tools: support for changing column comment

Change-Id: I8bfc7f5b1c4f89d01d2f5145b648d15d90f95dfb
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
2 files changed, 58 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/14814/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8bfc7f5b1c4f89d01d2f5145b648d15d90f95dfb
Gerrit-Change-Number: 14814
Gerrit-PatchSet: 3
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>