[GitHub] [spark] winningsix commented on a change in pull request #27546: [SPARK-30773][ML]Support NativeBlas for level-1 routines

[GitBox <gi...@apache.org>]

winningsix commented on a change in pull request #27546: [SPARK-30773][ML]Support NativeBlas for level-1 routines
URL: https://github.com/apache/spark/pull/27546#discussion_r386498502
 
 

 ##########
 File path: mllib-local/pom.xml
 ##########
 @@ -61,13 +61,17 @@
       This spark-tags test-dep is needed even though it isn't used in this module, otherwise testing-cmds that exclude
       them will yield errors.
     -->
+    <dependency>
 
 Review comment:
   hmm, instead env variables, we can pass this configuration via blas property file considering ```mllib-local``` package does not have access to ```core``` module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org