You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/11 18:15:27 UTC
[GitHub] [maven-resolver] michael-o commented on a diff in pull request #176: Idea: collector listener
michael-o commented on code in PR #176:
URL: https://github.com/apache/maven-resolver/pull/176#discussion_r870615618
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegate.java:
##########
@@ -93,4 +100,28 @@ public DependencyCollector setVersionRangeResolver( VersionRangeResolver version
return this;
}
+ protected void dependencyCollected( RepositorySystemSession session,
+ List<DependencyNode> pathToCollectedNode,
+ DependencyNode collectedNode )
+ {
+ // TODO: this is below "demo", but will be an extension point
Review Comment:
Don't use `String#format()` it is very expensive, your SLF4J placeholder.
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegate.java:
##########
@@ -93,4 +100,28 @@ public DependencyCollector setVersionRangeResolver( VersionRangeResolver version
return this;
}
+ protected void dependencyCollected( RepositorySystemSession session,
+ List<DependencyNode> pathToCollectedNode,
+ DependencyNode collectedNode )
+ {
+ // TODO: this is below "demo", but will be an extension point
+ logger.info( String.format( "%s (context: %s)",
+ collectedNode.getDependency(), collectedNode.getRequestContext() ) );
+ int distance = 0;
+ ListIterator<DependencyNode> reversePathIterator = pathToCollectedNode
+ .listIterator( pathToCollectedNode.size() );
+ while ( reversePathIterator.hasPrevious() )
+ {
+ DependencyNode dn = reversePathIterator.previous();
+ StringBuilder indent = new StringBuilder();
+ for ( int i = 0; i < distance; i++ )
+ {
+ indent.append( " " );
+ }
+ distance++;
+ indent.append( " -> " );
+ logger.info( String.format( "%s%s (context: %s) @ %s", indent, dn, dn.getRequestContext(),
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org