[GitHub] davidyaha commented on issue #5: Fix ts compilation

[GitBox <gi...@apache.org>]

davidyaha commented on issue #5: Fix ts compilation
URL: https://github.com/apache/fineract-cn-fims-web-app/pull/5#issuecomment-409992342
 
 
   Hey @awasum! Thanks for taking the time to review my PR!
   
   Didn't see those vulnerability issues before upgrading my `npm` to version ^6 so that's a cool feature added there that I didn't know bout 😄I prefer to use `yarn` but that's actually quite of a good reason to move back to `npm`..
   
   Back to our topic,  I've taken a look running `npm audit | less` and it seems like all of those "vulnerability" issues are rooted in `karma`, `protractor` and `phantomjs`, which are all part of the angular testing suite. I can upgrade those dependencies, but it might be a good idea to move those fixes to a new PR as it's not part of what I was trying to solve here (app not compiling) and was actually a problem even before I've submitted this PR. Will be happy to open a new PR for the rest of the audit fixes thing.
   
   Let me know your thoughts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services