[jira] [Comment Edited] (HBASE-5257) Allow INCLUDE_AND_NEXT_COL in filters and use it in ColumnPaginationFilter

["ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483938#comment-13483938 ] 

ramkrishna.s.vasudevan edited comment on HBASE-5257 at 10/25/12 7:11 AM:
-------------------------------------------------------------------------

@Lars/@Ted/[~varun]
First of all thanks for the patch.
I have some doubts here
Versions are cell based right? 
Now with this change even if the maxVersions is set as 2, after the first cell is included we jump to the second col itself.
So if col qualifier 'q1' has two versions still we move on to colqualifier 'q2'? Am i missing something ?
{Edit}: removed 'family' word.  
                
      was (Author: ram_krish):
    @Lars/@Ted/[~varun]
First of all thanks for the patch.
I have some doubts here
Versions are cell based right? 
Now with this change even if the maxVersions is set as 2, after the first cell is included we jump to the second col family itself.
So if col qualifier 'q1' has two versions still we move on to colqualifier 'q2'? Am i missing something ?
                  
> Allow INCLUDE_AND_NEXT_COL in filters and use it in ColumnPaginationFilter
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5257
>                 URL: https://issues.apache.org/jira/browse/HBASE-5257
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Lars Hofhansl
>            Assignee: Varun Sharma
>             Fix For: 0.92.2, 0.94.3, 0.96.0
>
>         Attachments: 5257-trunk.txt, 5257-trunk-v2.txt, HBASE-5257-0.92.txt, HBASE-5257-0.94.txt
>
>
> There are various usecases and filter types where evaluating the filter before version are handled either do not make sense, or make filter handling more complicated.
> Also see this comment in ScanQueryMatcher:
> {code}
>     /**
>      * Filters should be checked before checking column trackers. If we do
>      * otherwise, as was previously being done, ColumnTracker may increment its
>      * counter for even that KV which may be discarded later on by Filter. This
>      * would lead to incorrect results in certain cases.
>      */
> {code}
> So we had Filters after the column trackers (which do the version checking), and then moved it.
> Should be at the discretion of the Filter.
> Could either add a new method to FilterBase (maybe excludeVersions() or something). Or have a new Filter wrapper (like WhileMatchFilter), that should only be used as outmost filter and indicates the same (maybe ExcludeVersionsFilter).
> See latest comments on HBASE-5229 for motivation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira