[jira] [Work logged] (ARTEMIS-2170) Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-2170?focusedWorklogId=185521&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185521 ]

ASF GitHub Bot logged work on ARTEMIS-2170:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Jan/19 00:41
            Start Date: 16/Jan/19 00:41
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-454607131
 
 
   Still need to find a way to optimise so we dont have to for loop round all properties, e.g. extra properties seperated or keep the internal properties flag. Currently this is less optimised as if any properties we now cycle through all of them.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 185521)
            Time Spent: 10m
    Remaining Estimate: 0h

> Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
> -----------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2170
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2170
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> CoreMessage::checkProperties perform too many volatile read/write and has a too big body just to handle exceptional cases, while cleanupInternalProperties is called on the hot path of session send, but is performing too many synchronized operations and loopup on TypedProperties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)